Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-22 Thread Pavel Raiskup
On Thursday, September 22, 2016 7:40:08 AM CEST Michal Novotny wrote: > On Wed, Sep 21, 2016 at 3:32 PM, Pavel Raiskup wrote: > > :) Consider that others consume Copr sources ... > > > > > What is important for me is not important for you and vice versa. > > I would say that every commit is import

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-21 Thread Michal Novotny
On Wed, Sep 21, 2016 at 3:32 PM, Pavel Raiskup wrote: > > :) Consider that others consume Copr sources ... > > > What is important for me is not important for you and vice versa. > I would say that every commit is important. > > ... and have Copr working, want to have it as stable as possible,

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-21 Thread Pavel Raiskup
On Wednesday, September 21, 2016 2:57:03 PM CEST Miroslav Suchý wrote: > Dne 21.9.2016 v 12:52 Pavel Raiskup napsal(a): > > Thanks, I'll subscribe there. Let's hope I'll be able to find good > > heuristic to pick important changes for review -- but unfortunately, I can > > not review everything.

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-21 Thread Miroslav Suchý
Dne 21.9.2016 v 12:52 Pavel Raiskup napsal(a): > Thanks, I'll subscribe there. Let's hope I'll be able to find good > heuristic to pick important changes for review -- but unfortunately, I can > not review everything. Is there possibility to highlight important > changes? Define "important chang

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-21 Thread Pavel Raiskup
On Monday, September 19, 2016 1:53:08 PM CEST Miroslav Suchý wrote: > This is not really bug. So I will close it in BZ. But I'm happy to discuss it > here. > > I disagree that we need code review before push. This is quite small project, > with only few active developers. Agreed. That said, I do

Re: Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-19 Thread Vít Ondruch
As I read the recent discussions on this ML, this appears to me to be more about design decisions, not about particular commits ... Vít Dne 19.9.2016 v 13:53 Miroslav Suchý napsal(a): > This is not really bug. So I will close it in BZ. But I'm happy to discuss it > here. > > I disagree that w

Fwd: [Bug 1376844] New: Please start using processes like code-review, etc.

2016-09-19 Thread Miroslav Suchý
This is not really bug. So I will close it in BZ. But I'm happy to discuss it here. I disagree that we need code review before push. This is quite small project, with only few active developers. Although you can find some commits which can be discussed, most of them are straight. If you want t