Re: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Am 28.08.2011 22:54, schrieb Mario Torre: Il giorno dom, 28/08/2011 alle 21.35 +0200, Sebastian Sickelmann ha scritto: Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Hi, Hi created a new webrev with your suggested changes at:

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Am 29.08.2011 21:10, schrieb Xueming Shen: Hi Sebastian, I will help to push the patch, if people all agreed the changes proposed. Thanks for supporting this. I pulled your patch and generated the webrev at http://cr.openjdk.java.net/~sherman/7084245/webrev I already created a new webrev

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Sebastian Sickelmann
Sorry i have forgotten the webrev url. http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_1/ Am 30.08.2011 10:20, schrieb Sebastian Sickelmann: Am 29.08.2011 21:10, schrieb Xueming Shen: Hi Sebastian, I will help to push the patch, if people all agreed the changes

hg: jdk8/tl/jdk: 2 new changesets

2011-08-30 Thread michael . x . mcmahon
Changeset: fe205518c3a7 Author:michaelm Date: 2011-08-30 14:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe205518c3a7 7084560: Crash in net.dll Reviewed-by: chegar Contributed-by: luc...@linux.vnet.ibm.com ! src/windows/native/java/net/NetworkInterface.c !

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Xueming Shen
Hi Sebastian, On 08/30/2011 01:23 AM, Sebastian Sickelmann wrote: Sorry i have forgotten the webrev url. http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_1/ with couple changes from your original patch. (1) Undo the changes in DecimalFormat.java and Format.java.

Re: Request for review: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread Xueming Shen
Sebastian, src/share/classes/sun/misc/Launcher.java in new patch appears to miss a ending } at ln#487 -Sherman On 08/30/2011 10:20 AM, Xueming Shen wrote: Hi Sebastian, On 08/30/2011 01:23 AM, Sebastian Sickelmann wrote: Sorry i have forgotten the webrev url.

hg: jdk8/tl/jdk: 7084245: Update usages of InternalError to use exception chaining

2011-08-30 Thread xueming . shen
Changeset: 8a51f0e24380 Author:sherman Date: 2011-08-30 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a51f0e24380 7084245: Update usages of InternalError to use exception chaining Summary: to use new InternalError constructor with cause chainning Reviewed-by: alanb,

hg: jdk8/tl/jdk: 7083664: test hard code of using c:/temp but this dir might not exist

2011-08-30 Thread weijun . wang
Changeset: f5120b47f93d Author:weijun Date: 2011-08-31 09:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5120b47f93d 7083664: test hard code of using c:/temp but this dir might not exist Reviewed-by: xuelei, ohair ! test/lib/security/java.policy/Ext_AllPolicy.sh !