Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Alan Bateman
On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and they looks fine to me. Joe might want to look at the

Re: Code Review 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative

2011-11-10 Thread Chris Hegarty
On 10/11/2011 05:34, David Holmes wrote: On 10/11/2011 3:03 AM, Chris Hegarty wrote: On 09/11/2011 16:44, Mike Duigou wrote: The change looks good. The creation of node instances could use diamond. ie. Yes, this was my initial reaction too. Since Doug's CVS is also built with JDK6 I guess

Re: Race condition in TimerTask KillThread test

2011-11-10 Thread David Holmes
On 10/11/2011 9:50 PM, Gary Adams wrote: On 11/10/11 2:22 AM, David Holmes wrote: Aside: it would be good if whomever is going to do the commits for you could assist with publishing webrevs for these changes. There was a bulk request to add Vivian's team to the openjdk authors list that may

hg: jdk8/tl/jdk: 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative

2011-11-10 Thread chris . hegarty
Changeset: d6a5da5f6ba0 Author:dl Date: 2011-11-10 12:21 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6a5da5f6ba0 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative Reviewed-by: chegar, mduigou, dholmes !

Re: Garbage collection race condition before final checks

2011-11-10 Thread Gary Adams
On 11/ 8/11 11:13 PM, Mandy Chung wrote: Thanks for picking up this bug and fixing this intermittent issue. PlatformLoggingMXBeanTest.java in the same directory has the same issue. It'd be good to fix that with the same CR. These tests were copied from

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Joe Darcy
Hello, On 11/10/2011 1:29 AM, Alan Bateman wrote: On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and

Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.

2011-11-10 Thread Martin Desruisseaux
Le 10/11/11 16:24, Joe Darcy a écrit : The Float and Double changes look fine. I don't know why the constructors were coded up that way; Maybe because the Float(String) / Double(String) constructors were coded in Java 1.0, while the parseFloat(String) / parseDouble(String) methods were added

hg: jdk8/tl/jdk: 7110111: Minor Java SE javadoc Constructor clean up

2011-11-10 Thread lance . andersen
Changeset: 830d2e46023a Author:lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux martin.desruisse...@geomatys.fr !

Re: code review request : 7091388:Regular unexplained npe's from corba libs after system has been running for days

2011-11-10 Thread Alan Bateman
On 07/11/2011 11:42, Seán Coffey wrote: currently not live on bugs.sun.com but hope to get it up there shortly : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7091388 I'm porting fix for 7091388 forward to JDK8 (and then 7u) This is a fix in the CDRInputStream_1_0.close()/

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-10 Thread Alan Bateman
On 04/11/2011 13:08, Seán Coffey wrote: ok, so updated webrev at : http://cr.openjdk.java.net/~coffeys/webrev.7105952.2/ some minor modifications : * closed variable made private * hg mv instead of rm/add for testcase * testcase padded up some more. * comments changed to block style format