Re: zlib 1.2.3 - 1.2.5

2011-11-29 Thread Alan Bateman
On 28/11/2011 22:06, Xueming Shen wrote: Hi, Here is the webrev for upgrading the bundled zlib from 1.2.3 to 1.2.5 for JDK8 http://cr.openjdk.java.net/~sherman/7110149/webrev The changes to the original zlib source code (other than the copyright attachment) is at

Re: zlib 1.2.3 - 1.2.5

2011-11-29 Thread Ulf Zibis
Am 29.11.2011 11:23, schrieb Alan Bateman: When we talked about the zlib version here (I think back in February) we talked about having the option to use the system's zip library where appropriate. Have you given this any thought recently? +1 Ulf

Last Change for comment on 7081804: Remove cause field from javax.xml.crypto.NoSuchMechnismException

2011-11-29 Thread Sebastian Sickelmann
Hi, I started some cleanup work a while ago and we got into short discussions while cleaning-up javax.xml.crypto. Unfortunately i got no relay for a long time. Tried to get some comments on 2011-10-27 [1] and 2011-11-23 [2] but nobody reacted. Maybe i have done something wrong, maybe i

Re: A method with return type size_t returns negative value

2011-11-29 Thread Alan Bateman
On 28/11/2011 08:36, Jing Lv wrote: Hello Alan, I am fine with the fix on the webrev, suppose it would be applied later? I don't remember (as it's been a long time) exactly I found the issue, maybe some code scan or some strong compiler :) (Problem with my mail server so I can

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread Chris Hegarty
On 11/29/11 06:19 PM, Lance Andersen - Oracle wrote: Looks good to me Me too. Just one minor opportunity for use of in ObjectInputStream Class?[] classObjs = new Class*?*[interfaces.length]; --- Class?[] classObjs = new Class[interfaces.length]; -Chris. Best Lance On Nov 29, 2011, at

Re: A method with return type size_t returns negative value

2011-11-29 Thread Chris Hegarty
On 11/29/11 06:12 PM, Lance Andersen - Oracle wrote: looks ok to me... +1 -Chris. On Nov 29, 2011, at 11:19 AM, Alan Bateman wrote: On 28/11/2011 08:36, Jing Lv wrote: Hello Alan, I am fine with the fix on the webrev, suppose it would be applied later? I don't remember (as it's

hg: jdk8/tl/jdk: 7109837: Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer

2011-11-29 Thread xueming . shen
Changeset: 07e359b01d8a Author:sherman Date: 2011-11-29 13:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07e359b01d8a 7109837: Provide a mechanism for computing an Adler32 checksum for the contents of a ByteBuffer Summary: added methods Adler32/CRC32.update(ByteBuffer)

hg: jdk8/tl/jdk: 9 new changesets

2011-11-29 Thread lana . steuck
Changeset: 2a147f854257 Author:twisti Date: 2011-11-02 02:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a147f854257 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never !

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread Stuart Marks
On 11/29/11 8:10 AM, Alan Bateman wrote: I don't have time on Thursday to get involved in the warnings fest [1]. However I would like to contribute something and to that end the following webrev proposes changes to eliminate the warnings from several classes including java.rmi.**, the

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

2011-11-29 Thread Stuart Marks
On 11/29/11 10:02 AM, Lance Andersen - Oracle wrote: Please review the following changes for JDBC area as part of the warnings clean up day. I will not be able to participate on Thursday so I wanted to try and get this done ahead of time. The changes can be found at

Re: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes)

2011-11-29 Thread David Holmes
cc'ing to jdk8-dev so that people know these classes have already been tackled. David On 30/11/2011 2:10 AM, Alan Bateman wrote: I don't have time on Thursday to get involved in the warnings fest [1]. However I would like to contribute something and to that end the following webrev proposes

Re: 7116445: Miscellaneous warnings in the JDBC/RowSet classes

2011-11-29 Thread David Holmes
cc'ing to jdk8-dev so that people know these classes have already been tackled. David On 30/11/2011 4:02 AM, Lance Andersen - Oracle wrote: Please review the following changes for JDBC area as part of the warnings clean up day. I will not be able to participate on Thursday so I wanted to