Re: RFC 6910473: BigInteger negative bit length, value range, and future prospects

2013-09-20 Thread Dmitry Nadezhin
It is important that BigInteger objects be full-fledged instances on which all methods may be correctly invoked. This bitLength bug started this discussion: P4 JDK-6910473 : java.math.BigInteger.bitLength() may return negative "int" on large numbers https://bugs.openjdk.java.net/browse/JDK-6910473

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Ralph Goers
On Sep 18, 2013, at 9:30 AM, Nick Williams wrote: > > On Sep 3, 2013, at 7:02 PM, Mandy Chung wrote: > > >> So for log4j to work with security manager installed, it would have >> torequire the application to grant certain permissions - can you confirm? > > Maybe one of the other Log4j guys l

Re: RFR (S) 8024599: JSR 292 direct method handles need to respect initialization rules for static members

2013-09-20 Thread John Rose
On Sep 20, 2013, at 8:29 AM, Vladimir Ivanov wrote: > John, > > I don't see much value in documenting buggy behavior of early JDK7 in JDK8 > code. So, I would remove it. OK. I think I had it in mainly to make sure the unit tests did something interesting. > Regarding the test: > 31 * @ru

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
On 9/20/2013 5:25 PM, Remi Forax wrote: What you can do is to call a function that will take the stream as argument and close the stream after its use and before returning. R processStackStream(Function fun) { StackStream stackStream = new StackStream(Thread.currentThread()); // bias t

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Remi Forax
On 09/21/2013 01:58 AM, Mandy Chung wrote: On 9/20/2013 2:46 PM, Jochen Theodorou wrote: Exposing a StackStream API means that you need to eagerly walk the stack and copy the stack frames to it before it returns. I agree it is a much more flexible API. On the other hand, stack walking is seq

hg: jdk8/tl/jdk: 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec

2013-09-20 Thread paul . sandoz
Changeset: c30dc8e7744e Author:psandoz Date: 2013-09-20 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c30dc8e7744e 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec Reviewed-by: alanb ! src/share/classes

Re: RFR (M) 8001110: method handles should have a collectArguments transform, generalizing asCollector

2013-09-20 Thread John Rose
On Sep 20, 2013, at 3:07 PM, Vladimir Ivanov wrote: > I cleaned javadoc a little [1], so it is more readable in the browser now. Thanks; I applied those edits. I fixed the problem of a missing in a few other places too. > The test code looks ok, though the logic is over-complicated. > But t

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
On 9/20/2013 2:46 PM, Jochen Theodorou wrote: Exposing a StackStream API means that you need to eagerly walk the stack and copy the stack frames to it before it returns. I agree it is a much more flexible API. On the other hand, stack walking is sequential and ordered and a stack stream will be

Re: RFR: 8016110: Japanese char (MS932) 0x5C cannot be used as an argument when quoted

2013-09-20 Thread Naoto Sato
Hi Kumar, Here are my comments: cmdtoarg.c - Line 151: 'p' is not used anywhere. Remaining debugging code? - Line 155: Although this seems to do no harm, but it is not necessary. I18NArgTest.java - Currently it is testing only "Katakana SO" which is a single character. Maybe some more cases

Re: SplittableRandom update

2013-09-20 Thread Doug Lea
On 09/20/2013 11:36 AM, Paul Sandoz wrote: Hi Kasper, Can you please log a bug [1] (and also note that ThreadLocal/Random does the same) ? My preference would be to get this code in and fix the error reporting separately. Even though a minor nuisance, I agree; it would be a simple practice

hg: jdk8/tl/jdk: 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

2013-09-20 Thread brian . burkhalter
Changeset: 2552cd270350 Author:bpb Date: 2013-09-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2552cd270350 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent Summary: Explic

Re: RFR (M) 8001110: method handles should have a collectArguments transform, generalizing asCollector

2013-09-20 Thread Vladimir Ivanov
John, I cleaned javadoc a little [1], so it is more readable in the browser now. The test code looks ok, though the logic is over-complicated. But the whole MethodHandlesTest is written in the same vein. Best regards, Vladimir Ivanov diff --git a/src/share/classes/java/lang/invoke/MethodHandle

RFR: 8016110: Japanese char (MS932) 0x5C cannot be used as an argument when quoted

2013-09-20 Thread Kumar Srinivasan
Hi Naoto, Sherman, Akhil, Can you please review this: http://cr.openjdk.java.net/~ksrini/8016110/webrev.0 Bug: http://bugs.sun.com/view_bug.do?bug_id=8016110 The code was provided by IBM, I wrote up the test. Thanks Kumar

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 20:46, schrieb Mandy Chung: [...] I have some trouble in expressing the skipToSecondPredicate without side effect in lambda. With the help from Paul Sandoz (thanks Paul), if I had a stack stream, Thread.getCaller() method would be like this: stream.filter(e -> return REFLECTION

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 18:38, schrieb Peter Levart: [...] As I understand the Thread.firstCaller() does exactly that. "findFirstCallerMatchingPredicate". Choosen name abbreviation is maybe not making the semantic immediately obvious. then sorry, I overlooked that in the link though the usage of this i

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 17:45, schrieb Peter Levart: [...] I think the reasoning behind call-back API is that it moves the logic to construct a suitable data structure to the Java side, skipping intermediary representations and conversions. StackFrameInfo is already a conversion for me. I see some value

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 20:46, schrieb Mandy Chung: [...] Exposing a StackStream API means that you need to eagerly walk the stack and copy the stack frames to it before it returns. I agree it is a much more flexible API. On the other hand, stack walking is sequential and ordered and a stack stream will

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
On 9/20/13 1:58 AM, Jochen Theodorou wrote: Am 20.09.2013 09:09, schrieb Mandy Chung: [...] Stack is a "stream" that allows you to walk partial stack (e.g. find caller) or full stack trace (e.g. throwable). The filtering and mapping operations are lazy to avoid having the VM eagerly copying the

Re: Java 8 RFR 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

2013-09-20 Thread Paul Sandoz
On Sep 19, 2013, at 2:31 PM, Brian Burkhalter wrote: > On Sep 17, 2013, at 6:03 PM, Remi Forax wrote: > >> On 09/18/2013 02:08 AM, Brian Burkhalter wrote: >>> The proposed patch has been updated at the same location: >>> >>> http://cr.openjdk.java.net/~bpb/8024331/. >>> >>> Thanks, >>> >>>

Re: RFR: 8023339 & 8023340 : (xs) Refine throws UOE/NPE Conditions

2013-09-20 Thread Paul Sandoz
Hi Mike, You made changes to the documentation of List.replaceAll which does not perform matching: 398 * @param operator the operator to apply to each element 399 * @throws UnsupportedOperationException if this list is unmodifiable. 400 * Implementations may throw this

Re: Java 8 RFR 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

2013-09-20 Thread Brian Burkhalter
On Sep 20, 2013, at 12:05 PM, Paul Sandoz wrote: >> JDK 8 Reviewers: This patch still needs Official Approval unless of course >> there are objections. >> > > Looks ok to me, Cool. Thanks, Brian

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
Jochen, On 9/20/13 4:19 AM, Jochen Theodorou wrote: Am 20.09.2013 12:05, schrieb Peter Levart: [...] The use-cases described used getCallerClass(int depth) repeatedly to find a caller by iterating over a range of depths and calling getCallerClass(depth). You can use either Thread.walkStack or T

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
On 9/20/13 2:24 AM, Peter Levart wrote: Mandy: I like the API. It covers the use-cases optimally. I can see how StackStreamcould be implemented with a single JNI -> Java callback per StackFrameInfo... Why not using the same call-back principle for Throwable API too. One important design goa

hg: jdk8/tl/jdk: 8024253: ThreadLocal random can use SecureRandom for the initial seed

2013-09-20 Thread paul . sandoz
Changeset: 7913855ff66c Author:psandoz Date: 2013-09-20 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7913855ff66c 8024253: ThreadLocal random can use SecureRandom for the initial seed Reviewed-by: psandoz, chegar, alanb Contributed-by: Doug Lea , Peter Levart , Guy S

Re: RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-09-20 Thread Ivan Gerasimov
Hi Alan! I yet modified the test, so now it can be run both from jprt and as a standalone test. I also added a comment for QA with the instruction on how to test the fix manually. Would you please review the hopefully final webrev? http://cr.openjdk.java.net/~igerasim/8023130/4/webrev/

Re: RFR: 8013839: Enhance Logger API for handling of resource bundles

2013-09-20 Thread Naoto Sato
Hi Daniel, I only looked at the ResourceBundle portion of the changeset, and it looks good to me (assuming it'll go through the CCC). Naoto On 9/20/13 5:33 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8013839: Enhance Logger API for handling of resource bundles, and 4814565:

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Naoto Sato
OK, good. Naoto On 9/20/13 8:40 AM, Alexander Zuev wrote: Naoto, i just tested - jtreg has no issues with deleting files even in non-unicode locales. /Alex On 9/20/13 18:45, Naoto Sato wrote: Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully re

Re: SplittableRandom update

2013-09-20 Thread Kasper Nielsen
Hi, This is minor, but I hate it when bounds check does not include the specified parameters. Makes it much harder to track down a bug, if all you have is a stack trace. - Kasper On Fri, Sep 20, 2013 at 4:11 PM, Doug Lea wrote: > > In the course of writing up a report (coming soon) that inclu

Re: RFR (S) 8024599: JSR 292 direct method handles need to respect initialization rules for static members

2013-09-20 Thread Vladimir Ivanov
John, I don't see much value in documenting buggy behavior of early JDK7 in JDK8 code. So, I would remove it. Regarding the test: 31 * @run main/othervm/timeout=3600 - why do you have timeout set to 1h? I like the idea how you count events. As a suggestion for enhancement - maybe it's m

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Michael McMahon
A few comments: 1) Seems to be two macros _AIX and AIX. Is this intended? NetworkInterface.c 2) line 1098: new style of variable declaration. First time we would have that in this code. I think it should be okay though 3) Can't comment on the AIX functionality, except I notic

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread David M. Lloyd
On 09/20/2013 10:45 AM, Peter Levart wrote: On 09/20/2013 12:56 PM, Jochen Theodorou wrote: Am 20.09.2013 11:34, schrieb Peter Levart: [...] List frames = new ArrayList<>(); Thread.walkStack(frames::add); No so awfull. as I said, it is unclear to me as of if walkStack walks the whole stack o

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Peter Levart
On 09/20/2013 01:19 PM, Jochen Theodorou wrote: that is I think a usecase for some... as I said, getCallerClass(int) is not really ideal for us either. More ideal in this style would be for us public static T findCaller(Predicate predicate, Function function)

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Peter Levart
On 09/20/2013 12:56 PM, Jochen Theodorou wrote: Am 20.09.2013 11:34, schrieb Peter Levart: [...] List frames = new ArrayList<>(); Thread.walkStack(frames::add); No so awfull. as I said, it is unclear to me as of if walkStack walks the whole stack or not. Your code implies it does. If It does

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Alexander Zuev
Naoto, i just tested - jtreg has no issues with deleting files even in non-unicode locales. /Alex On 9/20/13 18:45, Naoto Sato wrote: Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully remove them? Naoto On Sep 20, 2013, at 3:43 AM, Alexander

Re: SplittableRandom update

2013-09-20 Thread Paul Sandoz
Hi Kasper, Can you please log a bug [1] (and also note that ThreadLocal/Random does the same) ? My preference would be to get this code in and fix the error reporting separately. Thanks, Paul. [1] https://bugs.openjdk.java.net/ On Sep 20, 2013, at 8:25 AM, Kasper Nielsen wrote: > Hi, > >

hg: jdk8/tl/jdk: 7200277: [parfait] potential buffer overflow in npt/utf.c

2013-09-20 Thread staffan . larsen
Changeset: 94cc251d0c45 Author:sla Date: 2013-09-20 16:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94cc251d0c45 7200277: [parfait] potential buffer overflow in npt/utf.c Reviewed-by: dsamersoff, dcubed ! src/share/npt/utf.c

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Naoto Sato
Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully remove them? Naoto > On Sep 20, 2013, at 3:43 AM, Alexander Zuev wrote: > > Hi Kumar, > > thanks for suggestion - the corrected (and simplified) webrev can be found > at: > http://cr.openjdk.java.n

Re: RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

2013-09-20 Thread Daniel D. Daugherty
On 9/20/13 3:49 AM, Staffan Larsen wrote: Please review this change to avoid a buffer overflow in npt/utf.c. webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ Thumbs up. src/share/npt/utf.c No comments Dan bug: https://bugs.openjdk.java.net/browse/JDK-7200277 Thanks, /Staffan

SplittableRandom update

2013-09-20 Thread Doug Lea
In the course of writing up a report (coming soon) that includes discussion of SplittableRandom, we had a chance to further analyze and test things, resulting in a few small improvements. Plus some internal renamings to better reflect intent. Plus now with the same initial seed mechanics discusse

hg: jdk8/tl/jdk: 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread alexander . zuev
Changeset: afe857b13b62 Author:kizune Date: 2013-09-20 17:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afe857b13b62 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales Reviewed-by: naoto, ksrini - test/tools/launcher/8017248/ClassÁ.java - test/

Re: RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

2013-09-20 Thread Dmitry Samersoff
Staffan, Looks good for me. PS: > is redundant. -Dmitry On 2013-09-20 13:49, Staffan Larsen wrote: > Please review this change to avoid a buffer overflow in npt/utf.c. > > webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-7200277 > > T

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Chris Hegarty
Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more li

hg: jdk8/tl/nashorn: 2 new changesets

2013-09-20 Thread sundararajan . athijegannathan
Changeset: 195be8ca5c97 Author:sundar Date: 2013-09-20 12:56 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/195be8ca5c97 8025111: undefined or null 'with' expression in empty with block should throw TypeError Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/co

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jörn Huxhorn
On 20. September 2013 at 12:06:42, Remi Forax (fo...@univ-mlv.fr) wrote: On 09/20/2013 11:57 AM, Jörn Huxhorn wrote:  > On 20. September 2013 at 11:35:24, Peter Levart (peter.lev...@gmail.com) > wrote:  > On 09/20/2013 10:57 AM, Jochen Theodorou wrote:  >> Am 20.09.2013 09:28, schrieb Nick William

RFR: 8013839: Enhance Logger API for handling of resource bundles

2013-09-20 Thread Daniel Fuchs
Hi, Please find below a patch for: 8013839: Enhance Logger API for handling of resource bundles, and 4814565: (rb) add method to get basename from a ResourceBundle 1. It adds a ResourceBundle.getBaseBundleName() method, 2. It

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 12:05, schrieb Peter Levart: [...] The use-cases described used getCallerClass(int depth) repeatedly to find a caller by iterating over a range of depths and calling getCallerClass(depth). You can use either Thread.walkStack or Thread.firstCaller for implementing those use-cases.

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 11:34, schrieb Peter Levart: [...] List frames = new ArrayList<>(); Thread.walkStack(frames::add); No so awfull. as I said, it is unclear to me as of if walkStack walks the whole stack or not. Your code implies it does. If It does, I don't see the advantage of suing a Stream he

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Alexander Zuev
Hi Kumar, thanks for suggestion - the corrected (and simplified) webrev can be found at: http://cr.openjdk.java.net/~kizune/8025076/webrev.05 With best regards, /Alex On 9/20/13 3:20, Kumar Srinivasan wrote: Hi Alex, The class can be compiled into the current directory (scratch), this wi

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Remi Forax
On 09/20/2013 11:57 AM, Jörn Huxhorn wrote: On 20. September 2013 at 11:35:24, Peter Levart (peter.lev...@gmail.com) wrote: On 09/20/2013 10:57 AM, Jochen Theodorou wrote: Am 20.09.2013 09:28, schrieb Nick Williams: [...] This is all well and good, but some of us just need a simple array. This

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Peter Levart
On 09/20/2013 10:58 AM, Jochen Theodorou wrote: Am 20.09.2013 09:09, schrieb Mandy Chung: [...] Stack is a "stream" that allows you to walk partial stack (e.g. find caller) or full stack trace (e.g. throwable). The filtering and mapping operations are lazy to avoid having the VM eagerly copying

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jörn Huxhorn
On 20. September 2013 at 11:35:24, Peter Levart (peter.lev...@gmail.com) wrote: On 09/20/2013 10:57 AM, Jochen Theodorou wrote:  > Am 20.09.2013 09:28, schrieb Nick Williams:  > [...]  >> This is all well and good, but some of us just need a simple array.  >> This seems like over-engineering. I jus

RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

2013-09-20 Thread Staffan Larsen
Please review this change to avoid a buffer overflow in npt/utf.c. webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7200277 Thanks, /Staffan

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Peter Levart
On 09/20/2013 10:57 AM, Jochen Theodorou wrote: Am 20.09.2013 09:28, schrieb Nick Williams: [...] This is all well and good, but some of us just need a simple array. This seems like over-engineering. I just want an array of StackFrameInfos/StackTraceFrames. if you need the full stack, then mi

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jörn Huxhorn
On 20. September 2013 at 11:03:49, Jochen Theodorou (blackd...@gmx.org) wrote: Am 20.09.2013 10:50, schrieb Jörn Huxhorn:  [...]  > But I have serious doubts that *this* is going to be more efficient than just > iterating over an array.  +1  > Feel free to add all that functionality but all we a

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Peter Levart
On 09/20/2013 09:28 AM, Nick Williams wrote: On Sep 20, 2013, at 2:09 AM, Mandy Chung wrote: On 9/18/2013 9:22 AM, Nick Williams wrote: Okay. Again, sorry for my absence. This wraps up my feedback for now. I now await responses from Mandy. On Sep 17, 2013, at 3:53 PM, Mandy Chung wrote: Yo

hg: jdk8/tl/jdk: 2 new changesets

2013-09-20 Thread staffan . larsen
Changeset: 58fd427b454d Author:sla Date: 2013-09-20 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58fd427b454d 8024985: com/sun/jdi/StepTest.java failed since jdk8b107 Reviewed-by: dcubed ! test/com/sun/jdi/ExceptionEvents.java ! test/com/sun/jdi/FilterNoMatch.java !

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 10:50, schrieb Jörn Huxhorn: [...] But I have serious doubts that *this* is going to be more efficient than just iterating over an array. +1 Feel free to add all that functionality but all we are asking for right now is access to the call stack array in a way that is as fast,

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 09:09, schrieb Mandy Chung: [...] Stack is a "stream" that allows you to walk partial stack (e.g. find caller) or full stack trace (e.g. throwable). The filtering and mapping operations are lazy to avoid having the VM eagerly copying the entire stack trace data even for the short re

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jochen Theodorou
Am 20.09.2013 09:28, schrieb Nick Williams: [...] This is all well and good, but some of us just need a simple array. This seems like over-engineering. I just want an array of StackFrameInfos/StackTraceFrames. if you need the full stack, then misusing a Predicate and a dummy Consumer to colle

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Jörn Huxhorn
On 20. September 2013 at 09:28:52, Nick Williams (nicholas+open...@nicholaswilliams.net) wrote: > This will give you an idea the API we are thinking about:  > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/walkstack-webrev/  Just to be clear, this means the patch I worked on for a month has been

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Staffan Larsen
Volker, The serviceability-related changes look ok to me (not a Reviewer). /Staffan On 16 sep 2013, at 21:30, Volker Simonis wrote: > Resending this to more lists as requested by Alan Bateman with the kind > request to anybody to review the parts for which he feels responsible:) > > For thos

remove 5u-cpu 8021334

2013-09-20 Thread Ivan Gerasimov

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Nick Williams
On Sep 20, 2013, at 2:09 AM, Mandy Chung wrote: > On 9/18/2013 9:22 AM, Nick Williams wrote: >> Okay. Again, sorry for my absence. This wraps up my feedback for now. I now >> await responses from Mandy. >> >> On Sep 17, 2013, at 3:53 PM, Mandy Chung wrote: >> >>> You asked at a good time. I d

Re: [PATCH] 4851444: Exposing sun.reflect.Reflection#getCallerClass as a public API in Java 8

2013-09-20 Thread Mandy Chung
On 9/18/2013 9:22 AM, Nick Williams wrote: Okay. Again, sorry for my absence. This wraps up my feedback for now. I now await responses from Mandy. On Sep 17, 2013, at 3:53 PM, Mandy Chung wrote: You asked at a good time. I discussed this with John Rose last couple days on this topic. He ha