Hi,
Out of curiosity, is JDK 8's type reification improved enough so
that we can replace
> EnumSet EnumSet.noneOf(Class)
with
> EnumSet EnumSet.noneOf()
and the JDK will figure out the value of E based on the expected
return type? If so, can we make this API change?
Thanks,
G
Changeset: 15651a673358
Author:ksrini
Date: 2013-10-04 16:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/15651a673358
8005542: jtreg test OverrideBridge.java contains @ignore
Reviewed-by: jjg
Contributed-by: steve.si...@oracle.com
- test/tools/javac/generics/Overrid
Enum constructors (as compiled by javac) have synthetic parameters;
constructors of nested classes [1] can have either implicit or synthetic
parameters.
HTH,
-Joe
[1] https://blogs.oracle.com/darcy/entry/nested_inner_member_and_top
On 9/30/2013 8:25 PM, Eric Wang wrote:
Including the coreli
Changeset: bb87db832b31
Author:ksrini
Date: 2013-10-04 16:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bb87db832b31
8003537: javap use internal class name when printing bound of type variable
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javap/ClassWriter.jav
Hi,
Please review a port from lambda repo to tl, it contains a refactoring
of OpTestCase and a small addition to fill test gap.
http://cr.openjdk.java.net/~henryjen/tl/8025968/0/webrev/
Cheers,
Henry
Changeset: 66181f7991bd
Author:bpatel
Date: 2013-10-04 15:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/66181f7991bd
8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8.
Reviewed-by: tbell
! make/docs/Makefile
Changeset: 6b8f5030e5ad
Author:bpatel
Date: 2013-10-04 15:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/6b8f5030e5ad
8025741: Fix jdk/make/docs/Makefile to point to correct docs URL for JDK 8.
Reviewed-by: tbell
! common/makefiles/javadoc/Javadoc.gmk
Changeset: 3e3c321710be
Author:jjg
Date: 2013-10-04 15:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3e3c321710be
8025970: Spurious characters in JavaCompiler
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
On Oct 4, 2013, at 2:40 PM, John Rose wrote:
> Actually it's OK: The name "coll" is defined a couple lines up by the "A
> collection adapter {@code collectArguments(mh, 0, coll)} ...", and the term
> "filter" is persistently applied to it. So I think it is intelligible as
> posted. — John
Changeset: 515d54c1b063
Author:jjg
Date: 2013-10-04 14:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/515d54c1b063
6525408: DiagnosticListener should receive MANDATORY_WARNING in standard
compiler mode
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javac/main
Actually it's OK: The name "coll" is defined a couple lines up by the "A
collection adapter {@code collectArguments(mh, 0, coll)} ...", and the term
"filter" is persistently applied to it. So I think it is intelligible as
posted. — John
On Oct 4, 2013, at 11:34 AM, John Rose wrote:
> Yikes;
Changeset: 2fa6ced325cc
Author:jjg
Date: 2013-10-04 13:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2fa6ced325cc
8022163: javac exits with 0 status and no messages on error to construct an
ann-procesor
Reviewed-by: darcy
!
src/share/classes/com/sun/tools/javac/p
On Oct 3, 2013, at 5:38 PM, Brian Burkhalter wrote:
> On Oct 3, 2013, at 5:35 PM, Alan Bateman wrote:
>
>> On 03/10/2013 16:10, Brian Burkhalter wrote:
>>> Please review and comment at your convenience.
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-7179567
>>> Webrev: http://c
Changeset: 3344ea7404b1
Author:bpatel
Date: 2013-10-04 13:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3344ea7404b1
8024756: method grouping tabs are not selectable
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
! te
Changeset: 6e186ca11ec0
Author:bpatel
Date: 2013-10-04 13:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e186ca11ec0
8008164: Invisible table captions in javadoc-generated html
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWr
Hi,
Please review these small improvements in messages resulting from
parsing date and time errors and corresponding tests.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-better-msg-8025718/
JBS:
https://bugs.openjdk.java.net/browse/JDK-8025718
Thanks, Roger
2013/10/2 15:13 -0700, alan.bate...@oracle.com:
> BTW: Is this important enough to attempt to do this late in 8? I just
> wonder about a significant change like switching to weak references and
> whether it would be more sensible to hold it back to do early in 9.
I share your concern. This is e
Changeset: f031b2fe21cd
Author:dfuchs
Date: 2013-10-04 19:15 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f031b2fe21cd
8025745: Clarify API documentation of JAXP factories.
Summary: Clarifies usage of ServiceLoader in JAXP factories.
Reviewed-by: alanb, joehw, psandoz
! s
Yikes; good catch. I used javac -Xdoclint to find a couple typos in @param
also. — John
On Oct 4, 2013, at 11:17 AM, Christian Thalinger
wrote:
> You have renamed "coll" to "filter" but the documentation still references
> "coll" in multiple places, e.g.:
>
> + * If the filter method h
On 10/4/2013 9:36 AM, Paul Sandoz wrote:
On Oct 4, 2013, at 6:11 PM, Daniel Fuchs wrote:
On 10/4/13 3:33 PM, Alan Bateman wrote:
On 04/10/2013 03:02, Daniel Fuchs wrote:
:
http://cr.openjdk.java.net/~dfuchs/webrev_8025745/webrev.00/
This mostly looks good, the only thing is that it reads
src/share/classes/java/lang/invoke/MethodHandles.java:
You have renamed "coll" to "filter" but the documentation still references
"coll" in multiple places, e.g.:
+ * If the filter method handle {@code coll} consumes one argument and
produces
+ * a non-void result, then {@code collectAr
2013/10/3 16:43 -0700, joe.da...@oracle.com:
> Per previous discussions on the mailing list, we've decided to rename
> the annotation type "jdk.Supported" to "jdk.Exported".
>
> ...
Looks good to me.
One question, though: Is it intended that one use of this annotation
can be overridden by anoth
Changeset: 379c04c090cf
Author:darcy
Date: 2013-10-04 10:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/379c04c090cf
8025913: Rename jdk.Supported to jdk.Exported
Reviewed-by: psandoz, forax, lancea, alanb, mchung, jjg
! src/share/classes/com/sun/source/doctree/Attr
On 10/04/2013 03:37 PM, Aleksey Shipilev wrote:
Hi Peter,
On 10/04/2013 04:43 PM, Peter Levart wrote:
>http://cr.openjdk.java.net/~plevart/jdk8-tl/Cleaners/webrev.02/
So you are taking on assisting the ReferenceHandler directly. Nice idea.
Hi Aleksey,
I will go over your notes in a later fo
Changeset: 7736abdf0805
Author:rfield
Date: 2013-10-04 09:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7736abdf0805
8021186: jdk/lambda/vm/DefaultMethodsTest.java fails
Summary: remove DefaultMethodsTest from jdk/test/problemList.txt
Reviewed-by: mduigou
! test/ProblemL
Changeset: 1de0fac9b962
Author:rriggs
Date: 2013-08-29 20:38 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1de0fac9b962
8023764: Optimize Period addition
Summary: Optimise plus/minus for common cases
Reviewed-by: sherman
Contributed-by: scolebou...@joda.org
! src/share/clas
On 10/03/2013 11:43 PM, Joe Darcy wrote:
Hello,
Per previous discussions on the mailing list, we've decided to rename
the annotation type "jdk.Supported" to "jdk.Exported".
Other than the file rename, the changes to the contents of the type
are below:
/**
- * Indicates whether or not a J
On Oct 4, 2013, at 6:11 PM, Daniel Fuchs wrote:
> On 10/4/13 3:33 PM, Alan Bateman wrote:
>> On 04/10/2013 03:02, Daniel Fuchs wrote:
>>> :
>>>
>>> http://cr.openjdk.java.net/~dfuchs/webrev_8025745/webrev.00/
>> This mostly looks good, the only thing is that it reads "the
>> service-provider wi
On 10/4/13 3:33 PM, Alan Bateman wrote:
On 04/10/2013 03:02, Daniel Fuchs wrote:
:
http://cr.openjdk.java.net/~dfuchs/webrev_8025745/webrev.00/
This mostly looks good, the only thing is that it reads "the
service-provider will use ..." but I think you mean "the
service-provider loading facilit
Changeset: c0d44b1e6b6a
Author:kizune
Date: 2013-10-04 19:38 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0d44b1e6b6a
7096170: should remove unused support for enabling javac logging
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
looks fine.
-sherman
On 10/4/13 7:45 AM, roger riggs wrote:
The webrev has been updated to:
- In the until methods, add exclusive to the descriptions in the
@param tags in addition to the parameter name
- Optimize the use of requireNonNull so it appears only in the paths
for instanceof == f
Changeset: b5aad88cbf12
Author:vinnie
Date: 2013-10-04 16:05 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5aad88cbf12
8008296: keytool utility doesn't support '-importpassword' command
Reviewed-by: weijun
! src/share/classes/sun/security/tools/keytool/Main.java
! src/shar
Hi Pavel,
Thanks for sorting this out. I'm not a reviewer but hopefully Alan will
have a look when he gets a chance. Based on the bug description this
looks good to me though.
-Rob
On 04/10/13 12:39, Pavel Punegov wrote:
Please review this fix for the test bug
Issue: https://bugs.open
Looks good.
Mandy
On 10/3/2013 11:43 PM, Joe Darcy wrote:
Hello,
Per previous discussions on the mailing list, we've decided to rename
the annotation type "jdk.Supported" to "jdk.Exported".
Other than the file rename, the changes to the contents of the type
are below:
/**
- * Indicates
The webrev has been updated to:
- In the until methods, add exclusive to the descriptions in the
@param tags in addition to the parameter name
- Optimize the use of requireNonNull so it appears only in the paths
for instanceof == false
- Clarified in Temporal.until that the *converted* input
Hi Mandy,
On 10/3/13 9:29 PM, Mandy Chung wrote:
test/java/util/ResourceBundle/getBaseBundleName/TestGetBaseBundleName.java
109 return new Vector(java.util.Arrays.asList(
110 new String[] {"dummy"})).elements();
Could you use Collections.enumeration
Changeset: 77ba1e67707c
Author:allwin
Date: 2013-10-04 15:00 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77ba1e67707c
8025829: Add java/lang/instrument/RetransformBigClass.sh to problemlist
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
Hi Peter,
On 10/04/2013 04:43 PM, Peter Levart wrote:
> http://cr.openjdk.java.net/~plevart/jdk8-tl/Cleaners/webrev.02/
So you are taking on assisting the ReferenceHandler directly. Nice idea.
I can only glimpse over the changes at this point...
- You can't add the public methods to java.ref.*
On 04/10/2013 03:02, Daniel Fuchs wrote:
:
http://cr.openjdk.java.net/~dfuchs/webrev_8025745/webrev.00/
This mostly looks good, the only thing is that it reads "the
service-provider will use ..." but I think you mean "the
service-provider loading facility will use ..."
-Alan.
On 03/10/2013 23:43, Joe Darcy wrote:
:
The webrev
http://cr.openjdk.java.net/~darcy/8025913.0/
also contains the update for replacing all previous uses of
jdk.Supported in the langtools repo with jdk.Exported. The Supported
annotation type was not applied outside of langtools.
Thanks Jo
Changeset: 3470bc26128f
Author:sundar
Date: 2013-10-04 16:21 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3470bc26128f
8025771: Enhance Nashorn Contexts
Reviewed-by: jlaskey, hannesw
- make/java.security.override
! make/project.properties
! src/jdk/nashorn/api/scriptin
Hi Aleksey,
This one is even better:
http://cr.openjdk.java.net/~plevart/jdk8-tl/Cleaners/webrev.02/
Instead of hooking up on the ReferenceQueue.poll/remove methods, there
are two new methods in ReferenceQueue: drain/drainLoop - only the 1st
one helps in enqueue-ing while holding the queue's
Please review this fix for the test bug
Issue: https://bugs.openjdk.java.net/browse/JDK-8024660
Webrev: http://cr.openjdk.java.net/~robm/8024660/webrev.01/
Summary:
Add a wait for process C finish before we return and pass the test.
There are also some code improvements made for easier code rea
+1
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Oct 4, 2013, at 2:43 AM, Joe Darcy wrote:
> Hello,
>
> Per previous discussions on the mailing list, we've deci
On 04/10/13 01:35, Alan Bateman wrote:
On 03/10/2013 16:10, Brian Burkhalter wrote:
Please review and comment at your convenience.
Issue:https://bugs.openjdk.java.net/browse/JDK-7179567
Webrev:http://cr.openjdk.java.net/~bpb/7179567/
Summary
* Document and throw IAE from URLClassLoader
On 3 October 2013 23:08, Xueming Shen wrote:
> (2) It appears we started to use "endExclusive" in "until() methods, while
> the param
> has been renamed to be "exclusive" explicitly, personally I prefer
> still keep the
> word "exclusive" in its spec, or at least we want to be consistent
Hi,
Please find below a fix for:
8025745: Clarify API documentation of JAXP factories. [1]
This is an API doc only changes which clarifies the usage of
ServiceLoader by JAXP factories - as was implemented by
JDK-8005954 [2]
Basically it makes it explicit in the doc that the
ServiceLoader will t
On Oct 4, 2013, at 7:28 AM, Alan Bateman wrote:
> On 03/10/2013 16:31, Brent Christian wrote:
>> Please review my fix for 8024709 : "TreeMap.DescendingKeyIterator 'remove'
>> confuses iterator position"
>>
>> There are two possible code paths for performing a "descending" iteration
>> over th
On Oct 4, 2013, at 9:18 AM, Aleksey Shipilev
wrote:
> On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
>> Here is an alternative solution: http://cr.openjdk.java.net/~bpb/7189139.2/.
>
> Seems OK with me,
Same here.
> as long as Miller-Rabin test tolerates the
> lower-entropy PRNG.
>
I thi
On 10/04/2013 09:51 AM, Paul Sandoz wrote:
+1.
Paul.
Yes, nice.
I like the fact that Exported is annotated by itself :)
Rémi
On Oct 4, 2013, at 8:43 AM, Joe Darcy wrote:
Hello,
Per previous discussions on the mailing list, we've decided to rename the annotation type
"jdk.Supported" to
On 10/04/2013 11:18 AM, Aleksey Shipilev wrote:
> On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
>> Here is an alternative solution: http://cr.openjdk.java.net/~bpb/7189139.2/.
>
> Seems OK with me, as long as Miller-Rabin test tolerates the
> lower-entropy PRNG.
>
>> If this seems reasonable, d
Hi Aleksey,
I played with reference handling code and got the following idea:
Instead of iterating over the set of active Cleaners looking for those
that were cleared by the VM, make ReferenceQueue.poll/remove help
ReferenceHandler thread in enqueue-ing the references. This assumes VM
links t
+1.
Paul.
On Oct 4, 2013, at 8:43 AM, Joe Darcy wrote:
> Hello,
>
> Per previous discussions on the mailing list, we've decided to rename the
> annotation type "jdk.Supported" to "jdk.Exported".
>
> Other than the file rename, the changes to the contents of the type are below:
>
> /**
> -
On 10/04/2013 03:34 AM, Brian Burkhalter wrote:
> Here is an alternative solution: http://cr.openjdk.java.net/~bpb/7189139.2/.
Seems OK with me, as long as Miller-Rabin test tolerates the
lower-entropy PRNG.
> If this seems reasonable, does anyone have suggestions as to testing?
I would like to
On 4 okt 2013, at 00:49, Coleen Phillmore wrote:
>
> Thanks Dan -
>
> On 10/3/2013 4:28 PM, Daniel D. Daugherty wrote:
>> > open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
>>
>> test/java/lang/instrument/RedefineMethodInBacktrace.sh
>>No comments.
>>
>> test/java/lang/inst
55 matches
Mail list logo
