Hi Mandy,
On 15/10/2013 3:34 PM, Mandy Chung wrote:
On 10/14/2013 10:02 PM, David Holmes wrote:
http://cr.openjdk.java.net/~dholmes/8026378/webrev/
Looks okay with one question:
[..]
java/util/Collection/ListDefaults.java renamed to
java/util/List/ListDefaults.java
I skimmed on this
Changeset: 09a414673570
Author:jjg
Date: 2013-10-14 23:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570
8025998: Missing LV table in lambda bodies
Reviewed-by: vromero
! src/share/classes/com/sun/tools/javac/code/Flags.java
!
On 10/14/2013 11:03 PM, David Holmes wrote:
It uses testng which in turn requires compact2 because its use of sax/xml
Oh that's right. I missed that is a TestNG test.
thanks
Mandy
On 15/10/2013 5:19 AM, Daniel Fuchs wrote:
Adding awt-dev...
The change looks okay to me but I would suggest sending to awt-dev so
that the folks that maintain this area know about it.
On the test then does initializing SunToolkit cause AWT to be
initialized? I just wonder if this test will
On 15/10/2013 07:03, David Holmes wrote:
It uses testng which in turn requires compact2 because its use of sax/xml
Right, we need to figure out a solution for that as more and more TestNG
tests are added.
Anyway, the changes in the webrev look okay to me too. I suspect that
Hi,
I took a look at the patch, but i am not an expert in this area.
On BigInteger:
99 * @implNote
100 * BigInteger constructors and operations throw {@code
ArithmeticException} when
101 * the result is out of the supported range. The supported range in JDK 8
is
102 * -2sup{@code
Hi David,
On 10/15/13 9:38 AM, David Holmes wrote:
On 15/10/2013 5:19 AM, Daniel Fuchs wrote:
Adding awt-dev...
The change looks okay to me but I would suggest sending to awt-dev so
that the folks that maintain this area know about it.
On the test then does initializing SunToolkit cause AWT
Changeset: abe8d432f714
Author:jbachorik
Date: 2013-10-15 10:26 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abe8d432f714
6804470: JvmstatCountersTest.java test times out on slower machines
Summary: Increasing the default timeout to cater for the slower machines
Changeset: 0b6632e570b0
Author:alanb
Date: 2013-10-15 10:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b6632e570b0
8026398: Can't load jdk.Exported, ClassNotFoundException
Reviewed-by: chegar, mchung
! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java
Changeset: 2c16140fb515
Author:dfuchs
Date: 2013-10-15 13:01 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c16140fb515
8026404: Logging in Applet can trigger ACE: access denied
(java.lang.RuntimePermission modifyThreadGroup)
Summary: The test 'threadGroup.getParent() ==
On 15/10/2013 04:38, Mandy Chung wrote:
Alan,
Thanks for the review. Here is the updated webrev per your feedback:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8015912/webrev.01/
I have also fixed
jdk/test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java due to
the change of
On 14/10/2013 20:43, Brian Burkhalter wrote:
:
Here's the patch updated for this option:
http://cr.openjdk.java.net/~bpb/8010371/webrev.4/
http://cr.openjdk.java.net/%7Ebpb/8010371/webrev.4/
I think this is okay, the only concern is that the host name is no
longer guaranteed to be in the
Changeset: 79649bf21a92
Author:jlahoda
Date: 2013-10-15 16:23 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79649bf21a92
8026180: com.sun.source.tree.NewArrayTree refers to
com.sun.tools.javac.util.List
Summary: Correcting import in NewArrayTree, adding test
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
javac in langtools, which runs on the bootjdk, but generates classes for
the new jdk.
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
javac in langtools, which runs on the
On Oct 15, 2013, at 4:20 PM, Tristan Yan tristan@oracle.com wrote:
Thank you Paul
There is one minor question, I can't compile one of your code, then I
realized that's because grouping by signature is public static T, K, A, D
CollectorT, ?, MapK, D groupingBy(Function? super T, ?
On 2013-10-15 16:40, Alan Bateman wrote:
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built
rmic binary at the end of the build. This patch changes that and
instead builds a bootstrap version of the rmic classes, much like
bootstrap
On Oct 15, 2013, at 4:35 PM, Tristan Yan tristan@oracle.com wrote:
Hi Paul
you have comments suggest that all streams are sequential. There is an
inconsistency in the use and in some cases it is embedded in other stream
usages.
We do not really understand what exactly is meant,
On Oct 15, 2013, at 6:21 AM, Alan Bateman wrote:
Here's the patch updated for this option:
http://cr.openjdk.java.net/~bpb/8010371/webrev.4/http://cr.openjdk.java.net/%7Ebpb/8010371/webrev.4/
I think this is okay, the only concern is that the host name is no longer
guaranteed to be in
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other hand I'm a little bit concerned if this change still
allows it to bootstrap with a non-Oracle based bootstrap JDK. I
remember that we
Here's the updated webrev with the solution by Paul:
http://cr.openjdk.java.net/~igerasim/8024521/1/webrev/
I've also excluded the test from it.
Instead, I'm going to write a manual testing instruction for SQE.
I've tested the fix and it works as expected.
Sincerely yours,
Ivan
On 15.10.2013
On 15/10/2013 16:28, Brian Burkhalter wrote:
The hostname is guaranteed to be in the exception detail:
void
NET_ThrowByNameWithLastError(JNIEnv *env, const char *name,
const char *defaultDetail) {
char errmsg[255];
sprintf(errmsg, errno: %d, error: %s\n,
Anyone to review this?
Alan, do you have any updates on this?
On Mon, 07 of Oct 2013 20:47:22 Pavel Punegov wrote:
Hi Alan,
On Monday 07 October 2013 14:24:40 you wrote:
On 04/10/2013 16:10, Rob McKenna wrote:
Hi Pavel,
Thanks for sorting this out. I'm not a reviewer but hopefully Alan
Hi,
Spot fix for a date time parsing case witha reduced value field when
the chronology
is parsed after the reduced value field. The fix is to add a callback
when the
chronology is set to recompute the value of the field with the new
chronology.
Webrev:
Fine by me (not a formal reviewer)
Stephen
On 15 October 2013 17:03, roger riggs roger.ri...@oracle.com wrote:
Hi,
Spot fix for a date time parsing case witha reduced value field when the
chronology
is parsed after the reduced value field. The fix is to add a callback when
the
chronology
Thanks for this cleanup.
Looks fine to me.
It is disappointing to see some of the tests disabled for compact1 or compact2
because they use unrelated functionality. Is any effort planned to eliminate
unnecessary dependencies?
Mike
On Oct 14 2013, at 22:02 , David Holmes wrote:
On Oct 14 2013, at 02:32 , Paul Sandoz wrote:
Virtually all the cases where CME is thrown in the new Map defaults are
the points where previously the implementation would have looped/retried.
For the cases where no function values are passed it has very limited
value, we know it is
On Oct 15, 2013, at 6:25 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 14 2013, at 02:32 , Paul Sandoz wrote:
Virtually all the cases where CME is thrown in the new Map defaults are
the points where previously the implementation would have looped/retried.
For the cases where
looks good.
On 10/14/2013 10:49 AM, roger riggs wrote:
Hi,
The concrete argument types of Chronology and ZoneId in the
TemporalField.resolve method are too specific and should be generalized to
allow greater access to the Temporal being resolved. They should be replaced by
a single more
Hi,
Please find below a fix for:
8026499: Root Logger level can be reset unexpectedly
https://bugs.openjdk.java.net/browse/JDK-8026499
http://cr.openjdk.java.net/~dfuchs/webrev_8026499/webrev.00/
The issue here is that calling a method like e.g. URL.openConnection()
will trigger the
Changeset: ea422834f880
Author:rriggs
Date: 2013-09-26 23:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea422834f880
8025720: Separate temporal interface layer
Summary: Remove ZoneId and Chronology from TemporalField interface
Reviewed-by: sherman
Contributed-by:
Changeset: bf6b11347b1a
Author:bpatel
Date: 2013-10-15 11:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf6b11347b1a
8026370: javadoc creates empty span class=italic/span
Reviewed-by: jjg
! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java
Changeset: 70a301b35e71
Author:vromero
Date: 2013-10-15 19:36 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/70a301b35e71
8025816: javac crash with method reference with a type variable as the site
Reviewed-by: jjg
!
Hi,
Please help codereview the changes for
8025971: Remove Time-Zone IDs HST/EST/MST
8026197: Slow reading tzdb.dat if the JRE is on a high-latency, remote file
system
http://cr.openjdk.java.net/~sherman/8025971_8026197/webrev
Note: for 8026197, the only real native resource here needed to
On 15/10/2013 16:46, Pavel Punegov wrote:
Anyone to review this?
Alan, do you have any updates on this?
The only thing is the catching of InterruptedException where it should
be a test failure if that happens. However I'm okay with what you have
(and Rob has agreed to sponsor this one).
Changeset: af87dabb4263
Author:msheppar
Date: 2013-06-14 15:49 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/af87dabb4263
8011157: Improve CORBA portablility
Summary: fix also reviewed by Alexander Fomin
Reviewed-by: alanb, coffeys, skoivu
! common/makefiles/RMICompilation.gmk
Hi Sherman,
I can't help but notice that the tzdb.dat file is read using a
doPrivilege block in
ZoneInfoFile.java but not in TzdbZoneRulesProvider.java.
It is not new but is that correct?
Was there an opportunity to check the performance before and after both
in the local a remote cases?
Changeset: d8d6b58f1ebf
Author:vromero
Date: 2013-10-15 21:02 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d8d6b58f1ebf
8024947: javac should issue the potentially ambiguous overload warning only
where the problem appears
Reviewed-by: jjg
!
Changeset: ecb66dc473c1
Author:joehw
Date: 2013-07-16 14:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ecb66dc473c1
8012425: Transform TransformerFactory
Reviewed-by: alanb, dfuchs, mullan
! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java
!
Changeset: 43240b8b995b
Author:mkos
Date: 2013-08-01 16:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/43240b8b995b
8017505: Better Client Service
Reviewed-by: mullan, ahgross, mgrebac
!
Hello all;
As promised on the lambda-libs-spec-experts mailing list I have prepared a
changeset which renames the single arg substream() to skip() and remove the two
arg substream() method (aka slice).
The rationale behind these changes is:
- skip() is easier for new users to locate than
On 10/15/2013 01:03 PM, roger riggs wrote:
Hi Sherman,
I can't help but notice that the tzdb.dat file is read using a doPrivilege
block in
ZoneInfoFile.java but not in TzdbZoneRulesProvider.java.
TzdbZoneRulesProvider is package private. It is initialized inside the
doPrivilege
block in
Changeset: 81d694b1ab2f
Author:msheppar
Date: 2013-06-14 16:31 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/81d694b1ab2f
8011157: Improve CORBA portablility
Summary: fix also reviewed by Alexander Fomin
Reviewed-by: alanb, coffeys, skoivu
!
Changeset: 19e8eebfbe52
Author:jlahoda
Date: 2013-10-15 22:15 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19e8eebfbe52
8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
Summary: A mostly automated rename Annotate.Annotator-Annotate.Worker
Changeset: 5c599c419c1d
Author:hseigel
Date: 2013-07-11 12:59 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c599c419c1d
8016256: Make finalization final
Summary: Add private methods to final methods check
Reviewed-by: coleenp, acorn, ahgross
Contributed-by:
Changeset: b3baca585b7f
Author:jbachorik
Date: 2013-04-23 09:37 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3baca585b7f
8011081: Improve jhat
Summary: Properly escape HTML output
Reviewed-by: alanb, mschoene, sundar
!
Hi Sherman,
On 10/15/2013 4:23 PM, Xueming Shen wrote:
On 10/15/2013 01:03 PM, roger riggs wrote:
Hi Sherman,
I can't help but notice that the tzdb.dat file is read using a
doPrivilege block in
ZoneInfoFile.java but not in TzdbZoneRulesProvider.java.
TzdbZoneRulesProvider is package
Pursuant to comments on the submitted CCC request, the patch previously
approved for this issue has been revised:
http://cr.openjdk.java.net/~bpb/7179567/webrev.6/
The difference is that the URLClassLoader constructors and newInstance()
methods no longer throw a NPE if the URL array parameter
Hello,
Please review refreshing the internal ASM sources to ASM_5_0_BETA,
I have run all the lambda test-ng tests using the lambda repo as well as
the nashorn
regression tests and test262parallel.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026504
Webrev:
Changeset: 84df20dc604a
Author:bpatel
Date: 2013-07-24 15:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84df20dc604a
8016675: Make Javadoc pages more robust
Reviewed-by: jlaskey, ksrini
! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java
Thanks, I will make that correction to all of the primitive streams. (cut and
paste error)
Mike
On Oct 15 2013, at 14:13 , Henry Jen henry@oracle.com wrote:
On 10/15/2013 01:18 PM, Mike Duigou wrote:
Hello all;
As promised on the lambda-libs-spec-experts mailing list I have prepared a
Hi,
Please kindly review the latest update on lambda library spec, and a few
minor code clean up.
Webrev and specdiff can be found at,
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/webrev
http://cr.openjdk.java.net/~henryjen/ccc/8025909/0/specdiff
This webrev also covers update that
Hello Volker,
I just remembered got back to these changes - my email inbox isn't a
very good reminder system.
I am OK with everything I see in the client areas except as below :-
/* Very basic start for AIX - feel free to complete ..
169 */
We should remove this comment. If that means
On 10/15/2013 9:48 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8026499: Root Logger level can be reset unexpectedly
https://bugs.openjdk.java.net/browse/JDK-8026499
http://cr.openjdk.java.net/~dfuchs/webrev_8026499/webrev.00/
The issue here is that calling a method like
Where is the null handling for methods like DoubleStream.allMatch() described?
I don't see an @throws NullPointerException if predicate is null. The class
level functional interface parameters to methods, unless otherwise specified,
may not be null instruction is removed with reference to
An additional fix is needed due to a very recent rename :(
java/net/HttpURLPermission/URLTest.java renamed to
java/net/URLPermission/URLTest.java
Updated webrev:
http://cr.openjdk.java.net/~dholmes/8026378/webrev.v2/
On 16/10/2013 2:19 AM, Mike Duigou wrote:
Thanks for this cleanup.
Looks
The additional change looks fine.
On Oct 15 2013, at 16:14 , David Holmes david.hol...@oracle.com wrote:
An additional fix is needed due to a very recent rename :(
java/net/HttpURLPermission/URLTest.java renamed to
java/net/URLPermission/URLTest.java
Updated webrev:
Changeset: b0c086cd4520
Author:jjg
Date: 2013-10-15 15:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b0c086cd4520
8026564: import changes from type-annotations forest
Reviewed-by: jjg
Contributed-by: wdi...@gmail.com, steve.si...@oracle.com
! make/build.properties
On 16/10/2013 9:19 AM, Mike Duigou wrote:
The additional change looks fine.
Thanks.
On Oct 15 2013, at 16:14 , David Holmes david.hol...@oracle.com wrote:
An additional fix is needed due to a very recent rename :(
java/net/HttpURLPermission/URLTest.java renamed to
Changeset: 3676f04e6553
Author:bpb
Date: 2013-10-15 16:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3676f04e6553
8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes
UnknownHostException to be thrown
Summary: Modify UHE exception message for EAI_AGAIN failures.
Hi Erik,
Many thanks for jumping on this!
On 16/10/2013 12:30 AM, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
On 16/10/2013 12:40 AM, Alan Bateman wrote:
On 15/10/2013 15:30, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap version of the rmic classes, much like bootstrap
Hi Volker,
On 16/10/2013 1:29 AM, Volker Simonis wrote:
Hi Erik, Alan,
first of all I think this is a good change because it helps porters to
build a complete JDK even if the newly build rmic wouldn't run.
On the other hand I'm a little bit concerned if this change still
allows it to
On 16/10/2013 10:02 AM, David Holmes wrote:
Hi Erik,
Many thanks for jumping on this!
On 16/10/2013 12:30 AM, Erik Joelsson wrote:
Currently the RMI stubs in the jdk are built with the newly built rmic
binary at the end of the build. This patch changes that and instead
builds a bootstrap
On Oct 16, 2013, at 7:14 AM, David Holmes david.hol...@oracle.com wrote:
An additional fix is needed due to a very recent rename :(
java/net/HttpURLPermission/URLTest.java renamed to
java/net/URLPermission/URLTest.java
Updated webrev:
Changeset: e33aea66caa3
Author:dholmes
Date: 2013-10-15 20:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e33aea66caa3
8026378: TEST_BUG: Clean up TEST.groups
Reviewed-by: mduigou, mchung, alanb
! test/TEST.groups
Okay you have incited me to throw in my 2c :) I think the CME issue has
been raised a number of times in the past (and if the below doesn't
agree with what I've said in the past Hey! It's a brand new day! ;-) )
But first, Mike the missing spaces are creeping back in if(xxx) :)
For Map I don't
On 10/15/2013 04:05 PM, Mike Duigou wrote:
Where is the null handling for methods like DoubleStream.allMatch()
described? I don't see an @throws NullPointerException if predicate
is null. The class level functional interface parameters to methods,
unless otherwise specified, may not be null
On 10/15/2013 04:05 PM, Mike Duigou wrote:
Where is the null handling for methods like DoubleStream.allMatch()
described? I don't see an @throws NullPointerException if predicate
is null. The class level functional interface parameters to methods,
unless otherwise specified, may not be null
69 matches
Mail list logo
