Re: RFR: 8132306: java/lang/ref/ReferenceEnqueue.java fails with RuntimeException: Error: poll() returned null; expected ref object

On 07/30/2015 03:56 PM, Kim Barrett wrote: New webrev, with both changes: http://cr.openjdk.java.net/~kbarrett/8132306/webrev.01/ Thanks for fixing this. The change looks fine to me. Sorry for the belated reply as I just got back from vacation. I agree that this patch includes both of

Re: RFR(XS): 8133105: Fix getFinalAttributes() on Windows to handle more special cases

On Tue, Aug 11, 2015 at 6:38 AM, Roger Riggs roger.ri...@oracle.com wrote: Hi Volker, Looks fine. Thanks! Is there any way to test this? It seems like it needs a special file system state that would not be readily available. Yes, it's not easy to reproduce the problem. I've tried to

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

Hello Martin, the changes were reverted for the following files: java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java java.base/share/classes/java/util/concurrent/CopyOnWriteArraySet.java java.base/share/classes/java/util/AbstractQueue.java

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Kindly reminder. 06.08.2015 17:49, Konstantin Shefov пишет: Please, look at the modified test http://cr.openjdk.java.net/~kshefov/8060717/webrev.01/ -Konstantin On 08/06/2015 02:06 PM, Konstantin Shefov wrote: Hi Vladimir Thanks for reviewing On 08/06/2015 01:02 PM, Vladimir Ivanov

[JDK-8080741] sigsegv while heap dumping in java_lang_Class::signers(oopDesc*)+0x1b

Hello, very similiar to JDK-8080741 we had a crash with 8u51 on Linux. It looks like it is happening while dumping the heap in a out of memory condition. The bug talks about it is happenign on constrained heap, but it looks more like related to OutOfMemory dumps (in both cases).

Re: RFR JDK-8039390: Unexpected behaviour of String.format with null arguments

Hi Sherman, The spec clarifications and the new test look fine. Thanks, Roger On 8/7/15 1:24 PM, Xueming Shen wrote: Hi, Please help review fix for issue: https://bugs.openjdk.java.net/browse/JDK-8039390 webrev: http://cr.openjdk.java.net/~sherman/8039390 The j.u.Formatter implementation

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

Hi Volker, Thanks for checking into the details of the OS X sysctl. I'm fine with the current implementation. The rest of the updates and the additional tests look fine also. But I need to check on the CCC status. Thanks, Roger On 8/10/15 10:13 AM, Volker Simonis wrote: On Fri, Aug 7,

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

Thanks! Looks good to me. On Tue, Aug 11, 2015 at 4:33 AM, Alexander Stepanov alexander.v.stepa...@oracle.com wrote: Hello Martin, the changes were reverted for the following files: java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

On Tue, Aug 11, 2015 at 5:08 PM, Roger Riggs roger.ri...@oracle.com wrote: Hi Volker, Thanks for checking into the details of the OS X sysctl. I'm fine with the current implementation. The rest of the updates and the additional tests look fine also. Phew! I was already afraid I would have

Re: RFR [9] 8133188: docs: replace tt tags (obsolete in html5) for java.util

Thanks! Regards, Alexander On 8/11/2015 7:10 PM, Martin Buchholz wrote: Thanks! Looks good to me. On Tue, Aug 11, 2015 at 4:33 AM, Alexander Stepanov alexander.v.stepa...@oracle.com mailto:alexander.v.stepa...@oracle.com wrote: Hello Martin, the changes were reverted for the

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

Hi Volker, I looked at the proposed specification of commandLine() after the most recent round of reviews (which is 8131168.v6 I believe) and it looks fine to me. It expresses the intent pretty well. Oh, and the name commandLine is fine and it fits well with the names of the other methods.

Re: RFR (M/L): 8131168: Refactor ProcessHandleImpl_*.c and add implememtation for AIX

.. and of course right after I sent my previous message, I ran across something worth noting. The proposed spec for commandLine() says, * If {@link #command command()} and {@link #arguments arguments()} return non-null * optionals, The preferred term is non-empty instead of non-null. This