RE: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

Hi Joe and Daniel Thank you very much for your suggestions! Now I fully understand the rule(at least I think so :P) I will use a runWithAllPerm block surrounding the user setup code as Daniel's way. Btw, Daniel, ThreadLocal should not need Atomic any more, correct? Frank > -Original

Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

On 26/07/16 00:53, huizhe wang wrote: To avoid having to grant the permission, the test may choose to read the property before setting the SecurityManager. You might not be able to use TestNG Listeners in such case, or maybe you can by initializing the properties before the test starts. Or

Re: RFR: JDK-8044629: (reflect) Constructor.getAnnotatedReceiverType() returns wrong value

I filed a couple of bugs. Here's a relevant JIRA search: https://bugs.openjdk.java.net/issues/?jql=Subcomponent%20%3D%20java.lang%3Areflect%20AND%20watcher%20%3D%20martin Because of the trickiness of local vs inner classes, Alex may want to make a decision on the correct behavior. On Fri, Jul

Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

On 7/25/2016 2:46 AM, Frank Yuan wrote: -Original Message- From: huizhe wang [mailto:huizhe.w...@oracle.com] Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests On 7/22/2016 5:53 AM, Daniel Fuchs wrote: On 22/07/16 10:15, Frank Yuan wrote: Hi Daniel

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

+1 On 7/25/2016 7:43 AM, Stephen Colebourne wrote: I don't have any more comments, +1 Stephen On 25 July 2016 at 07:37, nadeesh tv wrote: Hi Stephen, Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8066806/webrev.11/ Changes:

Re: RFR: jsr166 jdk9 integration wave 8

Wave 8 updated with urgent temporary fix for 8162396: j.u.c java.lang.LinkageError On Thu, Jul 21, 2016 at 1:52 PM, Martin Buchholz wrote: > Thanks! Done. > > On Thu, Jul 21, 2016 at 1:45 PM, Peter Levart > wrote: > >> Hi Martin, >> >> On

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

Hi Brian, On 7/25/2016 1:05 PM, Brian Goetz wrote: A few more comments: - Do you want to tag OIF as a functional interface? (I think yes, you intend to use this with lambdas.) ok - Need explanation of what happens when someone returns UNDECIDED -- and perhaps some motivating

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

Hi Chris, Thanks for the review and comments, Updates in place: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-serial-filter-jdk9-8155760/ SpecDiff: http://cr.openjdk.java.net/~rriggs/filter-diffs/overview-summary.html Javadoc (subset)

RE: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Hi, looking good. I believe you could also remove the comment sections after the headers like: /* * $Id: Constants.java,v 1.7 2006/06/19 19:49:04 spericas Exp $ */ But no need for new webrev for that, of course :-) Best regards Christoph > -Original Message- > From: Daniel Fuchs

Re: RFR (JAXP) 8158084: Catalog API: JAXP XML Processor Support

Thanks Christoph. Fixed those headers. I wished to get these classes free from warnings, but had to find a balance between fixing warnings and adding too much noise to the patch. We could definitely make some dedicated warning patches. -Joe On 7/25/2016 8:27 AM, Langer, Christoph wrote:

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

On 25/07/16 18:38, Langer, Christoph wrote: Hi, looking good. I believe you could also remove the comment sections after the headers like: /* * $Id: Constants.java,v 1.7 2006/06/19 19:49:04 spericas Exp $ */ But no need for new webrev for that, of course :-) Thanks Christoph! I was

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Hi, Here is the later version of the fix: - Header files fixed - Bytecode 1.1 compatible http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.02/ cheers, -- daniel On 25/07/16 16:16, Langer, Christoph wrote: Hi Daniel, yes, I just recognized the header is different everywhere. It is a

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

A few more comments: - Do you want to tag OIF as a functional interface? (I think yes, you intend to use this with lambdas.) - Need explanation of what happens when someone returns UNDECIDED -- and perhaps some motivating explanation of why it is there at all, rather than just returning

RE: RFR (JAXP) 8158084: Catalog API: JAXP XML Processor Support

Hi Joe, looking good to me at a glance and contains some nice cleanups/warning fixes. But of course I'm not a reviewer. I think in src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java src/java.xml/share/classes/jdk/xml/internal/SecuritySupport.java you

RE: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Hi Daniel, yes, I just recognized the header is different everywhere. It is a good idea to consult Joe on this - he was also giving me hints on how to do it correctly when I was touching JAXP. Best regards Christoph > -Original Message- > From: Daniel Fuchs

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Hi Alan, On 23/07/16 07:57, Alan Bateman wrote: On 22/07/2016 17:16, Daniel Fuchs wrote: Hi, Please find below a fix for 8153082: Update XSTL compiler to generate classes that invoke addReads https://bugs.openjdk.java.net/browse/JDK-8153082 This fix removes a dependency from java.xml to an

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

Roger, Mainly looks good. Some comments on the spec: - Use the Present Simple Tense consistently, e.g. "Return*S* an ObjectInputFilter computed from a string of patterns." - ObjectInputFilter. Was there a comment already on the use of links? For example the following is showing in

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

Hi Christoph, On 22/07/16 20:23, Langer, Christoph wrote: Hi Daniel, looks good to me. Maybe you'll want to take the chance to update the apache headers in the xalan files? Thanks for your review! I'm only an occasional wanderer in JAXP land - which files do you see have an outdated

Re: RFR (JAXP): 8021787: javax.xml.datatype.XMLGregorianCalendar.getMonth() return is documented wrong

Hi Joe, Roger, thank you for your replays. A have changed javadoc as Joe suggested (hope I didn't missed any in-line comments) and added a bunch of "s" and "The" to Returns and @return. Hope now it looks better and more consistent: http://cr.openjdk.java.net/~snikandrova/8021787/webrev.02/

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

I don't have any more comments, +1 Stephen On 25 July 2016 at 07:37, nadeesh tv wrote: > Hi Stephen, > > Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8066806/webrev.11/ > > Changes: Included the suggestions of Stephen > >

RE: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

> -Original Message- > From: huizhe wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit > tests > > > > On 7/22/2016 5:53 AM, Daniel Fuchs wrote: > > On 22/07/16 10:15, Frank Yuan wrote: > >> Hi Daniel > >> > >> Thank you

Re: RFR:JDK-8066806:java.time.format.DateTimeFormatter cannot parse an offset with single digit hour

Hi Stephen, Thanks for the comments. Please see the updated webrev http://cr.openjdk.java.net/~ntv/8066806/webrev.11/ Changes: Included the suggestions of Stephen Thanks and regards, Nadeesh On 7/22/2016 3:38 PM, Stephen Colebourne wrote: These tests are expected to throw exceptions:

Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

On 7/22/2016 5:53 AM, Daniel Fuchs wrote: On 22/07/16 10:15, Frank Yuan wrote: Hi Daniel Thank you very much for your review and the comments! -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP