Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Igor, just noticed your change. It is indeed necessary to clarify what is the best practice here. Thanks, Felix On 2017/6/1 11:32, Igor Ignatyev wrote: Hi Felix, I have suggested the exact opposite change[1-3] to fix the same problem. [1]

Re: JDK10: RFR(xxs): 8181207: 8177809 breaks AIX 5.3, 6.1 builds

Hi Thomas, one minor comment apart from what Christoph gave, you can combine the the two explicit assignment statements to one in all three places. rv = (jlong)sb.st_mtimespec.tv_sec * 1000; rv += (jlong)sb.st_mtimespec.tv_nsec / 100; to rv= (jlong)sb.st_mtimespec.tv_sec * 1000

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Felix, I have suggested the exact opposite change[1-3] to fix the same problem. [1] https://bugs.openjdk.java.net/browse/JDK-8181391 [2] http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048012.html [3] http://cr.openjdk.java.net/~iignatyev//8181391/webrev.00/index.html Thanks,

Re: JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java

Thank you all for reviewing. Pushed with minor update as Roger suggested. Thanks, Amy On 5/31/17 5:11 AM, Roger Riggs wrote: Hi Amy, LimitDirectMemory.java: 61 - Can you add a usage message to the exception identifying the arguments. It is good practice to provide a message so when

Re: (doc-only) 9 RFR of JDK-8181082: class-level since tag issues in java.base & java.datatransfer module

Looks fine to me. Thank you for clarification. - huaming...@oracle.com wrote: > Ping. > > Thank you > > -Hamlin > > > On 2017/5/31 8:13, Hamlin Li wrote: > > Hi Alan, Sergey, > > > > Sorry for delayed reply, I have been on vacation for last few days. > > > > I do have a tool (still under

Re: (doc-only) 9 RFR of JDK-8181082: class-level since tag issues in java.base & java.datatransfer module

Ping. Thank you -Hamlin On 2017/5/31 8:13, Hamlin Li wrote: Hi Alan, Sergey, Sorry for delayed reply, I have been on vacation for last few days. I do have a tool (still under development, it's based on javadoc doclet) to scan versions (currently from 1.7 to 9) of jdk source, find since

Re: (10) RFR of JDK-8166142: Refactor java.io.serialization shell tests to java

Hi Roger, Thank you for detailed reviewing, fixed as you suggested except below comment: 81-83/93/95: use SHARE.resolve(xxx).toString to compute the paths. As the code is constructing a class path with 2 paths rather than constructing a path. new webrev:

Re: RFR 9+-: 8180582: The bind to rmiregistry is rejected by registryFilter even though registryFilter is set

Hi Roger, RegistryImpl change looks fine. I have a quibble on the regex used in the test. 162 Matcher m = Pattern 163 .compile(".*maxdepth=(\\d*)") 164 .matcher(Objects.requireNonNullElse(registryFilter, "")); 165 int depthOverride = m.find()

Re: RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

Hi Mandy, 8180793[1], which moved j.t.l.wrappers.* to j.t.lib package, has been propagated to jdk10/jdk10. I have updated the patch accordingly -- http://cr.openjdk.java.net/~iignatyev//8180386/webrev.01/index.html could you please take a look? [1]

Re: RFR(S) : 8180898: remove JavaToolUtils testlibrary class

On 31/05/2017 19:04, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8180898/webrev.00/index.html Looks okay to me.

RFR(S) : 8180898: remove JavaToolUtils testlibrary class

http://cr.openjdk.java.net/~iignatyev//8180898/webrev.00/index.html > 209 lines changed: 0 ins; 209 del; 0 mod; 0 Hi all, 8180895[1] has updated the sole user of JavaToolUtils class to use other testlibrary classes, JavaToolUtils itself does not provide any unique methods, so it should be

Re: RFR: JDK-8176784 - Amend HREF to technote/guides in CORBA API docs to unilinks for guides

thanks Roger ... i'll make it consistent and add the tag in this instance and check for others occurrences, also. I used the same anchor text for the translation to @extLink regards Mark On 31/05/2017 18:11, Roger Riggs wrote: Hi Mark, org/omg/CORBA/package.html: for consistency should

Re: RFR: JDK-8176784 - Amend HREF to technote/guides in CORBA API docs to unilinks for guides

Hi Mark, org/omg/CORBA/package.html: for consistency should {@extLink jidlexception Java IDL exceptions } be the same as others: {@extLink jidlexception documentation on JavaIDL exceptions} I'm not sure if the is really needed. I'd remove it if not necessary. Otherwise looks fine.

Re: (10) RFR of JDK-8166142: Refactor java.io.serialization shell tests to java

Hi Hamlin, RenamePackageTest.java: - 48,61: rename "sutup" -> "setup" 81-83/93/95: use SHARE.resolve(xxx).toString to compute the paths. ClassPathTest.java: 42: add a space before "{" 56: Generally, exception messages should not end in "."; they are phrases so they could be printed with

RFR: JDK-8176784 - Amend HREF to technote/guides in CORBA API docs to unilinks for guides

Hi, please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8176784-IV/webrev.02/ which address the issue raised in https://bugs.openjdk.java.net/browse/JDK-8176784 this results in changes to href in the corba javadoc, such that the relative links to

Re: JDK10: RFR(xxs): 8181207: 8177809 breaks AIX 5.3, 6.1 builds

Hi Volker, Good suggestions! I completely overlooked the ..._n members in stat64 struct. It seems it is even documented: https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.files/stat.h.htm new webrev:

Re: RFR(XXS) : 8181307: tests added/changed by 8166139 should be updated to use the latest testlibrary

+1, looks good. Roger On 5/31/2017 11:19 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8181307/webrev.00/index.html 2 lines changed: 1 ins; 0 del; 1 mod; Hi all, misfortunately, 8180887[1] was created and tested before 8166139[2] has been integrated. then the fixes met in

Re: jdk9 vs. jdk8 : TimeZone getDisplayName(Locale.GERMAN) for TZ=MET

On 31.05.2017 17:11, Baesken, Matthias wrote: I wonder why the display names for timezone MET changed ( I observed this on Linux and Solaris) when I compare jdk8 to jdk9 . The test is very small, it just outputs for Locale.GERMAN the display name. With jdk8 we get a translated german

RFR(XXS) : 8181307: tests added/changed by 8166139 should be updated to use the latest testlibrary

http://cr.openjdk.java.net/~iignatyev//8181307/webrev.00/index.html > 2 lines changed: 1 ins; 0 del; 1 mod; Hi all, misfortunately, 8180887[1] was created and tested before 8166139[2] has been integrated. then the fixes met in jdk10/jdk10, java/net/URLClassLoader/closetest/CloseTest.java

jdk9 vs. jdk8 : TimeZone getDisplayName(Locale.GERMAN) for TZ=MET

I wonder why the display names for timezone MET changed ( I observed this on Linux and Solaris) when I compare jdk8 to jdk9 . The test is very small, it just outputs for Locale.GERMAN the display name. With jdk8 we get a translated german timezone name, but not with jdk9 (this is a bit

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Igor, On May 31, 2017, at 7:23 AM, Igor Ignatyev wrote: > thank you for your review. You’re welcome. > regarding '@Deprecated(since=“9”, forRemoval=true)', since the only users of > testlibrary classes are our own tests and we do not need to inform anyone or >

Re: RFR 9: (doclint) 8181156 html5 doclint issues in java.base javadoc

On 31/05/2017 15:34, Roger Riggs wrote: Please review javadoc markup change to update to html5 acceptable to doclint. The table formatting is updated to html5 markup. The Docs build is updated to require doclint html5. Webrev: jdk:

RFR 9: (doclint) 8181156 html5 doclint issues in java.base javadoc

Please review javadoc markup change to update to html5 acceptable to doclint. The table formatting is updated to html5 markup. The Docs build is updated to require doclint html5. Webrev: jdk: http://cr.openjdk.java.net/~rriggs/webrev-base-html5-8181156/ build:

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Brian, thank you for your review. regarding '@Deprecated(since=“9”, forRemoval=true)', since the only users of testlibrary classes are our own tests and we do not need to inform anyone or wait for a new release to remove them, I don't think it makes much sense to have such attributes. PS

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Alan, we believe it's a jtreg bug. we have seen similar intermittent failures in hotspot testing[1], Ioi(cc'ed) did a really great job analyzing the root cause[2], in to words jtreg puts a part of testlibrary to one path and another part to a different path. [3] is his suggested fix for

Re: RFR 9+-: 8180582: The bind to rmiregistry is rejected by registryFilter even though registryFilter is set

Thanks Daniel for the review and corrected link. On 5/30/2017 7:04 PM, Daniel Fuchs wrote: Hi Roger, On 30/05/17 19:26, Roger Riggs wrote: Hi Daniel, Fixed, there is no need for the unbind since the registry is not reused and it might cause a spurious success. (Also corrected the

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi, New webrev can be found here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8176508/02/ Previous review comments have been addressed. New changes since last webrev upload: Few “opens xxx to java.xml.bind” in the

Re: Proposal: javax.naming.spi.NamingManager.clearInitialContextFactoryBuilder()

On 18.05.2017 00:20, Andrew Guibert wrote: Hi Alan, I've checked within IBM and it appears we do not have any OpenJDK committers. Still trying to chase down if we have anyone in IBM who can drive this commit. Do you know of anyone? Hi Andrew, you can find a list of JDK 10 Committers at

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

> On 31 May 2017, at 10:42, Felix Yang wrote: > > Hi there, > >please review the patch to various jdk tests to explicitly compiling test > libraries and the lib's dependencies. Though it could be a jtreg issue (I > think so), it is necessary to get the tests

Re: RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi Felix, Looks good to me. Did you try to run each test in isolation (removing JT* between 2 runs) to check that they compile all they need? If you haven't committed yet then I guess a little for f in $(hg st . -nma) ; do \ rm -r JT* ; \ jtreg -verbose:summary -jdk $f ; \

RFR 8181299/10, Several jdk tests fail with java.lang.NoClassDefFoundError: jdk/test/lib/process/StreamPumper

Hi there, please review the patch to various jdk tests to explicitly compiling test libraries and the lib's dependencies. Though it could be a jtreg issue (I think so), it is necessary to get the tests running firstly. Bug: https://bugs.openjdk.java.net/browse/JDK-8181299 Webrev:

Re: JDK10: RFR(xxs): 8181207: 8177809 breaks AIX 5.3, 6.1 builds

Hi Thomas, as far as I can see, AIX supports both, the st_[a,c,m]time members in the stat64 structure for seconds and the corresponding st_[a,c,m]time_n members for nanosecond resolution since at least 5.3. Can you please use both - there's no reason to discriminate AIX here :) Also, can you

Re: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java

On 31/05/2017 09:10, Amy Lu wrote: Thank you Alan! Webrev updated according to the suggestions: http://cr.openjdk.java.net/~amlu/8181301/webrev.01 Looks good.

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

On 31/05/2017 09:05, Felix Yang wrote: Hi Alan even with explicit compilation, I also observed failures. I'm curious what is the best practice here. IMO, there could be a potential jtreg bug. One of the tests listed in JDK-8181299 is java/net/URLConnection/6212146/TestDriver.java. In

Re: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java

On 5/31/17 4:01 PM, Alan Bateman wrote: On 31/05/2017 04:57, Amy Lu wrote: java/nio/channels/AsynchronousChannelGroup/run_any_task.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181301 webrev:

Re: JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java

On 26/05/2017 03:42, Amy Lu wrote: java/nio/Buffer/LimitDirectMemory.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181126 webrev: http://cr.openjdk.java.net/~amlu/8181126/webrev.00/ This looks okay to me. -Alan

Re: RFR(S) : 8180805 : move RandomFactory to the top level testlibrary

Hi Alan even with explicit compilation, I also observed failures. I'm curious what is the best practice here. IMO, there could be a potential jtreg bug. See: https://bugs.openjdk.java.net/browse/JDK-8181299 https://bugs.openjdk.java.net/browse/JDK-8181300 Thanks, Felix On 2017/5/31

Re: JDK 10 RFR of JDK-8181301: Refactor shell test AsynchronousChannelGroup/run_any_task.sh to java

On 31/05/2017 04:57, Amy Lu wrote: java/nio/channels/AsynchronousChannelGroup/run_any_task.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181301 webrev: http://cr.openjdk.java.net/~amlu/8181301/webrev.00/ This looks okay to me

Re: RFR(S) : 8180888: move jdk.testlibrary.JarUtils to the top level testlibrary

On 31/05/2017 01:40, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8180888/webrev.00/index.html 354 lines changed: 148 ins; 149 del; 57 mod; Hi all, could you please review this changeset which moves JarUtils to the top level testlibrary? webrev: