Re: [10] RFR 8186046 Minimal ConstantDynamic support

2017-11-05 Thread David Holmes
On 4/11/2017 7:28 AM, Paul Sandoz wrote: On 3 Nov 2017, at 11:14, Karen Kinnear wrote: 6. SD::find_java_mirror_for_type You have resolve_or_null/fail doing CHECK_(empty) which should check for a NULL constant_type_klass. This is followed by an explicit if

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

2017-11-05 Thread ZhengJun Li
Yes, all the tests are passed. > 在 2017年11月6日，05:05，Lance Andersen 写道： > > Hi Jack, > > Overall looks OK. I am assuming all of the test suites are passing? > > Best > Lance >> On Nov 2, 2017, at 7:34 AM, Lance Andersen wrote: >> >> Hi

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

2017-11-05 Thread Lance Andersen
Hi Jack, Overall looks OK. I am assuming all of the test suites are passing? Best Lance > On Nov 2, 2017, at 7:34 AM, Lance Andersen wrote: > > Hi Jack > > Its on my list to finish by the end of the week. > > Best > Lance >> On Nov 2, 2017, at 4:34 AM, Jack Li

Re: RFR JDK-8185582, Update Zip implementation to use Cleaner, not finalizers

2017-11-05 Thread Peter Levart
On 11/03/17 09:48, Peter Levart wrote: Hi Sherman, I think this looks good now. Thanks. Regards, Peter Just one more thing. Re-reading the code once more after a few days made me re-think about why in my last version I did what I did with CleanableResource.inflaters field. In

Re: RFR: 8067661 transferTo() for Appendable

2017-11-05 Thread Patrick Reinhart
> Am 05.11.2017 um 11:02 schrieb Alan Bateman : > > On 05/11/2017 08:34, Patrick Reinhart wrote: >> After discussing [0] for about the API for the new transferTo() method on >> Appendable, I have created an initial >> Version of the actual implementation for review: >>

RFR - 8190482: InnocuousThread creation should not require the caller to possess enableContextClassLoaderOverride

2017-11-05 Thread Chris Hegarty
Currently JDK code that wants to create innocuous threads is required to do so within a privileged context that has the "enableContextClassLoaderOverride" RuntimePermission ( since the InnocuousThread class overrides setContextClassLoader ). This permissions should not be required, especially

Re: RFR: 8067661 transferTo() for Appendable

2017-11-05 Thread Alan Bateman
On 05/11/2017 08:34, Patrick Reinhart wrote: After discussing [0] for about the API for the new transferTo() method on Appendable, I have created an initial Version of the actual implementation for review: http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.00/index.html Any

RFR: 8067661 transferTo() for Appendable

2017-11-05 Thread Patrick Reinhart
After discussing [0] for about the API for the new transferTo() method on Appendable, I have created an initial Version of the actual implementation for review: http://cr.openjdk.java.net/~reinhapa/reviews/8067661/webrev.00/index.html Any comments/suggestions are welcome, also I will need a