Great!
So far we (sap) have developed the AIX port alone, good to finally
have IBM on our side :)
For authorship/committership info, see:
See: http://openjdk.java.net/contribute/
Among other things, your patches need to be ran through a battery of
tests at http://hg.openjdk.java.net/jdk/submit/
Hi Thomas,
Yes, there are many more to come :)
- Bhaktavatsal
-"Thomas Stüfe" wrote: -
To: Ichiroh Takiguchi , Bhaktavatsal R Maram
From: "Thomas Stüfe"
Date: 05/11/2018 11:49AM
Cc: Volker Simonis , Java Core Libs
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM
Hi,
I'll test and review next week. We also have some in-house tests which
I'd like to run.
You IBM folks should really apply for authorship so that this
contribution process gets streamlined. After all, if something breaks
in this code, you want to be able to fix it, yes? So even if you do
not c
Hi.
I tested this fix on AIX.
I got following results.
$ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
Ja_JP x-IBM943C IBM-943CIBM-943C
$ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
Ja_JP.IBM-943 x-IBM943C IBM-943CIBM-943C
$ LANG=Zh_TW ~/jdk/bin/java Pri
Any reviews/sponsors please?
-Jaikiran
On 03/05/18 6:24 PM, Jaikiran Pai wrote:
Hi,
This mail contains a potential patch to the issue[1] that I had
reported a couple of years back. The issue is still valid and
reproducible with latest upstream JDK.
In brief, if a certain code has:
public
Hi Ichiroh,
Yes, moving SimpleEUCEncoder.java to sun.nio.cs package would leave build tools
untouched. But, I think that for platforms other than AIX,
SimpleEUCEncoder.java in java.base module would not add any value.
- Bhaktavatsal
-Ichiroh Takiguchi wrote: -
To: Bhaktavatsal R Maram
Hello Bhaktavatsal.
I think we should move
from
src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java
to
src/java.base/share/classes/sun/nio/cs/SimpleEUCEncoder.java
instead of moving to
src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java.template
Then we do
Hi David,
On 5/10/2018 1:39 PM, David Lloyd wrote:
Would it be allowed to enable the serial lint without using the
@Serial annotation?
Certainly.
A limited serial lint checker already exists in javac and we enable that
check it in the JDK build. Basically it checks that a serializable clas
Hi Christoph,
Thanks for doing this! Yes, I'm fine with the additional cleanup as
well. They were so obsolete, like 20 years :-), plus the old bug system
was long gone.
Yes, running test jaxp_all would be good.
Best regards,
Joe
On 5/10/2018 2:08 PM, Langer, Christoph wrote:
Hi Joe,
tha
Hi Joe,
The words are fine.
The field serialPersistentFields is also not used with @Externalizable.
I would guess the lint checker would flag those methods and field for
warnings for Externalizable classes
since they might mislead to think they were used.
Roger
On 5/10/2018 5:03 PM, joe da
Hi Alexey,
looks good to me. Symbols don't seem to be needed outside libzip (java.base).
Best regards
Christoph
> -Original Message-
> From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of
> Alexey Ivanov
> Sent: Mittwoch, 9. Mai 2018 16:35
> To: core-libs ; hotspot-de
Hi Joe,
thanks for reviewing.
Then this would be my proposal with removing the obsolete stuff:
http://cr.openjdk.java.net/~clanger/webrevs/8202915.1/
I also removed some code that was already commented out (with some BUG tags...)
Are you fine with that?
I'll run it through the jtreg suite befo
PS After additional reading, I propose to add the follow clause to where
using the annotation is not appropriate:
* the {@code writeObject}, {@code readObject}, and {@code
* readObjectNoData} methods in a class that is {@code
* Externalizable}. While the {@code Externalizable} interface exten
Hi,
On 5/9/2018 6:49 PM, Vincent Ryan wrote:
Thanks Roger for your comments.
The main motivator for this class is to provide a basic hex. encoder/decoder
for smaller amounts of binary data
and to provide a hexdump encoder for larger amounts of binary data, while
recognising the need to cater
Would it be allowed to enable the serial lint without using the
@Serial annotation?
On Thu, May 10, 2018 at 10:55 AM, joe darcy wrote:
> Hello,
>
> Please review the webrev (code below) to address
>
> JDK-8202385: Annotation to mark serial-related fields and methods
> http://cr.openjdk.ja
Hi Roger,
Right; there are a few other distinguished methods defined for
externalization, but they are defined on the as methods on the
Externalizable interface as far as I can tell. The existence of
externalization is mentioned in the javac lint bug JDK-8202385.
I'll add as sentence indicat
Hi Joe,
Since Externalizable extends Serializable, should it or its methods be
mentioned,
either in the list to be marked as @Serial or not to be.
Thanks, Roger
On 5/10/2018 11:55 AM, joe darcy wrote:
Hello,
Please review the webrev (code below) to address
JDK-8202385: Annotation to m
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8202764
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8202764/webrev.00/
This is a regression caused by 8181157, where time zone names are
incorrectly retrieved (not following th
Thanks for bringing in what's been in SAP's JVM. The change looks good
to me. On whether to remove the commented lines (the unused
getContentSpecType method), I would say yes since that was replaced with
that of a DTDGrammar method a long long time ago :-)
Cheers,
Joe
On 5/10/2018 9:01 AM, La
One addition: I think it would be more appropriate to completely remove the
commented lines but I didn't dare to do so yet. What do you think?
From: Langer, Christoph
Sent: Donnerstag, 10. Mai 2018 17:51
To: core-libs-dev@openjdk.java.net; 'Joe Wang'
Subject: RFR (S): 8202915: [JAXP] Performance
On 10/05/2018 16:34, Bernd Eckenfels wrote:
Hello,
(I noticed changes to the Tests to remove FX Launcher have been discussed here.
So Maybe it is the Right list to ask: are there plans to provide better
launchers (especially for Windows) with Jlink?)
The Java packager/FX have binaries which a
Hello,
Please review the webrev (code below) to address
JDK-8202385: Annotation to mark serial-related fields and methods
http://cr.openjdk.java.net/~darcy/8202385.0/
The proposed java.io.Serial annotation type is intended to be used along
with an augmented implementation of javac's "s
Hi,
here is a little contribution that has been in SAP's JVM for several. In method
XMLDTDValidator::getAttributeTypeName(XMLAttributeDecl attrDecl), a
StringBuilder, preallocated to the expected length vs. a default StringBuffer
could help performance for "XMLSimpleType.TYPE_ENUMERATION". I al
On 5/10/18 5:59 AM, Kevin Rushforth wrote:
Here is the updated webrev:
http://cr.openjdk.java.net/~kcr/8202553/webrev.01/
+1
This stripped down version of FX test module looks better. FYI. @build
/* will build a module under the source directory of the test.
What you have (doing the c
Hello,
(I noticed changes to the Tests to remove FX Launcher have been discussed here.
So Maybe it is the Right list to ask: are there plans to provide better
launchers (especially for Windows) with Jlink?)
The Java packager/FX have binaries which are a bit better to use as launhers
than the r
Hi Kevin,
Thanks for making the changes, this is very manageable and maintainable
going forward. :)
Looks good!.
Thanks
Kumar
On 5/10/2018 5:59 AM, Kevin Rushforth wrote:
Here is the updated webrev:
http://cr.openjdk.java.net/~kcr/8202553/webrev.01/
As discussed offline, this strips do
Hi All,
In bug 8201540 (Extend the set of supported charsets in java.base on AIX)[1] we
moved default charsets that are available in OpenJDK to java.base module except
to IBM964. Charset IBM964 is bit tricky. Its Encoder is extended from
sun.nio.cs.ext.SimpleEUCEncoder. So, SimpleEUCEncoder als
Here is the updated webrev:
http://cr.openjdk.java.net/~kcr/8202553/webrev.01/
As discussed offline, this strips down the Mock LauncherImpl class to
just allow testing of the inputs. There is no need for it to try to
mimic the behavior of the FX launcher. It is sufficient to test the
argument
> On 10 May 2018, at 01:08, Weijun Wang wrote:
>
>
>
>> On May 10, 2018, at 6:49 AM, Vincent Ryan wrote:
>>
>>>
>>> - As Max observes, being able to supply the delimiters might be a good
>>> addition. (I'm thinking IP addresses too).
>>
>> Sure. Add another toHexString method that takes
29 matches
Mail list logo
