Review request: JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported

This patch includes the following changes that will reduce the number of internal classes made accessible to jdk.unsupported module via qualified exports. 1. move shared secrets to a new jdk.internal.access package. jdk.internal.misc package has been a dumping ground for various kinds of

Re: [PATCH] improve javadoc in TreeSet#add api documentation

Hello Stuart, Thank you for providing this opportunity. I'm up for this challenge and I'd love to take this task. The only huddle would be, how to proceed, ie planning things step by step, as this is my first time. If you can help me with the planning, I'll do the rest and fix these issues.

Re: [PATCH] improve javadoc in TreeSet#add api documentation

Hi Kishor, This is indeed an issue with the documentation. The root of the issue is that the implementations of the SortedSet and SortMap interfaces do not use the equals() method to determine set or map membership. Instead they use a comparison method (a Comparator, if provided, or the

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Let’s try this again: http://cr.openjdk.java.net/~bpb/6516099/webrev.04/ The method skipNBytes(long) is now defined in terms of the skip(n) and read(n) with the behavior for negative n being left open for subclasses. Thanks, Brian > On

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 12:39 PM, Sean Mullan wrote: I also replaced getCallerPD with the faster getProtectionDomain and removed a stale comment about impliesCreateAccessControlContext being called by the VM. It should be safe to remove now, but I left it in to minimize changes. I would just remove it,

Re: [12] RFR: 8213046: Define Japanese new Era character

+1 On 11/01/2018 04:55 PM, Lance Andersen wrote: ship it :-) On Nov 1, 2018, at 4:51 PM, Naoto Sato wrote: Indeed. Added the period. http://cr.openjdk.java.net/~naoto/8213046/webrev.02/ Naoto On 11/1/18 1:03 PM, Lance Andersen wrote: Looks better. Unless it is my eyes, the period seems

Re: PipedInputStream improvement

Jonathan, Roger told Ilya yesterday about that. But I guess the point is we cannot proceed even with discussion until the OCA has been signed. Is that right? > On 1 Nov 2018, at 21:07, Jonathan Gibbons wrote: > > You need to sign the Oracle Contributors Agreement (OCA) before contributing >

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 2:34 PM, dean.l...@oracle.com wrote: @Hidden is internal and no CSR is needed. FYI.  JDK-8212620 is the RFE to consider providing a standard mechanism to hide frames from stack trace. OK, I already filed JDK-8213234 but I think I should just close it as a duplicate of

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 1:45 PM, Mandy Chung wrote: On 11/1/18 1:18 AM, Vladimir Ivanov wrote: I think it's a good idea, but I believe it would require a CSR request. Do you mind if I file a separate issue for jdk.internal.vm.annotation.Hidden? Sure. Most of the annotations in

Re: PipedInputStream improvement

You need to sign the Oracle Contributors Agreement (OCA) before contributing code. See https://openjdk.java.net/contribute/ -- Jon On 11/01/2018 01:04 PM, Pavel Rappo wrote: On 29 Oct 2018, at 19:33, Ilya Gazman wrote: Hey guys, I created a more efficient version of java.io.PipedStream.

Re: [12] RFR: 8213046: Define Japanese new Era character

ship it :-) > On Nov 1, 2018, at 4:51 PM, Naoto Sato wrote: > > Indeed. Added the period. > > http://cr.openjdk.java.net/~naoto/8213046/webrev.02/ > > Naoto > > On 11/1/18 1:03 PM, Lance Andersen wrote: >> Looks better. Unless it is my eyes, the period seems missing after the blog >> URL.

Re: [12] RFR: 8213046: Define Japanese new Era character

Indeed. Added the period. http://cr.openjdk.java.net/~naoto/8213046/webrev.02/ Naoto On 11/1/18 1:03 PM, Lance Andersen wrote: Looks better.  Unless it is my eyes, the period seems missing after the blog URL. On Nov 1, 2018, at 3:53 PM, Naoto Sato > wrote:

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 1:18 AM, Vladimir Ivanov wrote: I think it's a good idea, but I believe it would require a CSR request. Do you mind if I file a separate issue for jdk.internal.vm.annotation.Hidden? Sure. Most of the annotations in jdk.internal.vm.annotation were originally located in

Re: PipedInputStream improvement

> On 29 Oct 2018, at 19:33, Ilya Gazman wrote: > > Hey guys, > > I created a more efficient version of java.io.PipedStream. I would like to > have a conversation with you about my implementation and how we can test > and benched marked it and eventually maybe even submit it for the next Java >

Re: [12] RFR: 8213046: Define Japanese new Era character

Looks better. Unless it is my eyes, the period seems missing after the blog URL. > On Nov 1, 2018, at 3:53 PM, Naoto Sato wrote: > > Updated the webrev. Dropped the "," after "May" too. > > http://cr.openjdk.java.net/~naoto/8213046/webrev.01/ > > Naoto > > On 11/1/18 11:31 AM, Naoto

Re: [12] RFR: 8213046: Define Japanese new Era character

Updated the webrev. Dropped the "," after "May" too. http://cr.openjdk.java.net/~naoto/8213046/webrev.01/ Naoto On 11/1/18 11:31 AM, Naoto Sato wrote: Hi Lance, On 11/1/18 11:26 AM, Lance Andersen wrote: Hi Naoto + * The code point, U+32FF, is reserved by the Unicode Consortium + * to

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 3:21 PM, dean.l...@oracle.com wrote: On 11/1/18 9:48 AM, Sean Mullan wrote: On 11/1/18 1:29 AM, dean.l...@oracle.com wrote: On 10/31/18 9:39 PM, Bernd Eckenfels wrote:

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 9:48 AM, Sean Mullan wrote: On 11/1/18 1:29 AM, dean.l...@oracle.com wrote: On 10/31/18 9:39 PM, Bernd Eckenfels wrote: http://cr.openjdk.java.net/~dlong/8212605/webrev.1/src/java.base/share/classes/java/security/AccessController.java.udiff.html In checkContext should the

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 10:01 AM, Sean Mullan wrote: Some of the copyrights need to be updated to 2018. Fixed. All else looks good to me as I had reviewed an earlier version of this before. We have talked about doing this for a while now, so I am finally glad we and are able to pretty much eliminate

Re: [12] RFR: 8213046: Define Japanese new Era character

Hi Lance, On 11/1/18 11:26 AM, Lance Andersen wrote: Hi Naoto + * The code point, U+32FF, is reserved by the Unicode Consortium + * to represent the Japanese square character for the new era that begins + **from* May, 2019. Relevant methods in the Character class return the same + *

Re: [12] RFR: 8213046: Define Japanese new Era character

Hi Naoto + * The code point, U+32FF, is reserved by the Unicode Consortium + * to represent the Japanese square character for the new era that begins + * from May, 2019. Relevant methods in the Character class return the same + * properties as for the existing Japanese era characters (e.g.,

[12] RFR: 8213046: Define Japanese new Era character

Hello, Please review a javadoc fix to this issue: https://bugs.openjdk.java.net/browse/JDK-8213046 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8213046/webrev.00/ This is to clarify the previously pushed change (8211398) in the javadoc of Character class. Naoto

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

Some of the copyrights need to be updated to 2018. All else looks good to me as I had reviewed an earlier version of this before. We have talked about doing this for a while now, so I am finally glad we and are able to pretty much eliminate one of the more common SecurityManager related

Re: JDK 12 RFR of JDK-6304578: (reflect) toGenericString fails to print bounds of type variables on generic methods

last iteration looks good to me, Vicente On 10/25/18 5:47 PM, joe darcy wrote: Hi Peter, Coming back to this review after my Code One activities this year have run their course... On 10/17/2018 3:07 PM, Peter Levart wrote: Hi Joe, On 10/17/2018 09:16 PM, joe darcy wrote: PS In response

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

On 11/1/18 1:29 AM, dean.l...@oracle.com wrote: On 10/31/18 9:39 PM, Bernd Eckenfels wrote: http://cr.openjdk.java.net/~dlong/8212605/webrev.1/src/java.base/share/classes/java/security/AccessController.java.udiff.html In checkContext should the security manager be null checked first instead

Re: Proposal Extending API for Streams (or other potentially long builder or chain calls)

Hello Ivan, Yes. It is practically the same request, only method name is different. I do not particularly care how this method is called. So I'm not only one who miss this method. In the next thread the name "transform" is proposed to match method for String. jOOλ

PipedInputStream improvement

Hey guys, I created a more efficient version of java.io.PipedStream. I would like to have a conversation with you about my implementation and how we can test and benched marked it and eventually maybe even submit it for the next Java release. My name is Ilya Gazman, I work at DoubleVerify, and I

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On Oct 30, 2018, at 1:10 PM, Andy Herrick wrote: > > On 10/30/2018 12:09 PM, Alan Bateman wrote: >>> ... >> Alex has suggested jdk.jpackager to avoid giving the impression that it's >> the "JDK packager". Also several existing tool modules have the tool name in >> the module name (jdk.jdeps,

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 2018-10-24 19:18, Erik Joelsson wrote: Hello, Nice to see this finally happening! Are we actually adding a new demo? I thought we were working towards getting rid of the demos completely. CompileJavaModules.gmk: The jdk.packager_CLEAN_FILES could be replaced with a simple

Re: RFR(JDK12/java.xml) 8212871: Broken links give 401-Unauthorized

Looks fine Joe. > On Nov 1, 2018, at 12:45 AM, Joe Wang wrote: > > Thanks Lance! I somehow copied the wrong link. Although they point to the > same document, the shorter version (without the prefix and date) is better. Yes saw that. Best to change though unless that is a temporary URL >

Re: RFR: JDK-8212828 Allow POSIX_SPAWN to be used for ProcessImpl on Linux

Thank you all. I just pushed. I set David as contributor since he provided the original patch. Cheers, Thomas On Thu, Nov 1, 2018 at 9:11 AM Alan Bateman wrote: > > On 31/10/2018 13:45, Roger Riggs wrote: > > Hi Thomas, > > > > The webrev looks fine. > > > > Please remove the @author tag in the

Re: RFR(M) 8212605: Pure-Java implementation of AccessController.doPrivileged

I think it's a good idea, but I believe it would require a CSR request. Do you mind if I file a separate issue for jdk.internal.vm.annotation.Hidden? Sure. Most of the annotations in jdk.internal.vm.annotation were originally located in java.lang.invoke. Not sure CSR will be required in

Re: RFR: JDK-8212828 Allow POSIX_SPAWN to be used for ProcessImpl on Linux

On 31/10/2018 13:45, Roger Riggs wrote: Hi Thomas, The webrev looks fine. Please remove the @author tag in the Linux (2nd) test block in Basic.java. Author tags are losing favor and there's no need to repeat it. I agree, no need to repeat it here. The webrev otherwise looks good to me too