Review Request JDK-8218419: Can't get annotations that are present on packages in -Xbootclasspath/a

BootClassLoader mistakenly overrides the 1-arg loadClassOrNull method instead of the 2-arg loadClassOrNull method. A class defined to the bootstrap class loader is intended to call JVM entry point to find such class rather than ClassLoader::defineClass method via the implementation-specific

Re: RFR: JDK-8217894: jpackage CLI syntax changes

On 2/5/2019 5:52 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java.frames.html Line 108 and 113 looks same. I think one of them can be removed.

Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

Thanks, Lance and Roger! The changeset is pushed now. Best, Joe On 2/5/19, 11:52 AM, Lance Andersen wrote: Hi Joe, The change seems reasonable... On Feb 5, 2019, at 1:37 PM, Joe Wang > wrote: Please review a quick fix for preserving the initial state of the

Re: RFR: JDK-8217894: jpackage CLI syntax changes

Hi Andy, http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java.frames.html Line 108 and 113 looks same. I think one of them can be removed.

Re: RFR 8182117 : Document Zip File System Properties

Hi Christoph Thank you for the feedback, Please see below > On Feb 5, 2019, at 11:22 AM, Langer, Christoph > wrote: > >>> * >>> + * The {@linkplain java.nio.file.FileSystems FileSystems} {@code >> newFileSystem} >>> + * static factory methods can be used to create a new Zip file system or

Re: RFR 8182117 : Document Zip File System Properties

Thank you for the feedback. Please see below > On Feb 5, 2019, at 3:31 AM, Alan Bateman wrote: > > A few comments > > On 04/02/2019 19:36, Lance Andersen wrote: >> : >> >> + * The Zip file system provider treats a Zip or JAR file as a file system >> + * providing the ability to manipulate

Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

Hi Joe, The change seems reasonable... > On Feb 5, 2019, at 1:37 PM, Joe Wang wrote: > > Please review a quick fix for preserving the initial state of the > Transformer. The faulty impl passes a reference of the initial property > setting to the working copy during reset, thus causes it to be

8218460: Test generation scripts do not invoke stream preprocessor correctly

https://bugs.openjdk.java.net/browse/JDK-8218460 http://cr.openjdk.java.net/~bpb/8218460/webrev.00/ A full test run will be effected with the generated tests except those generated by test/jdk/java/lang/invoke/VarHandles/generate-vh-tests.sh Unfortunately it appears that tests in this folder

Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

Looks good. Thanks, Roger On 02/05/2019 01:37 PM, Joe Wang wrote: Please review a quick fix for preserving the initial state of the Transformer. The faulty impl passes a reference of the initial property setting to the working copy during reset, thus causes it to be altered by an user

RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

Please review a quick fix for preserving the initial state of the Transformer. The faulty impl passes a reference of the initial property setting to the working copy during reset, thus causes it to be altered by an user setting. Further reset would then no longer be able to return to the

Re: RFR(JDK 13/java.xml) 8206132: DOM parser does not honor DocumentBuilderFactory.setExpandEntityReferences(false)

Thanks, Roger and Lance! The changeset is pushed now. Best, Joe On 2/4/19, 11:00 AM, Lance Andersen wrote: Hi Joe +1 On Feb 4, 2019, at 12:34 PM, Joe Wang > wrote: Resend. Please review at your convenience. Thanks, Joe Original Message

RE: RFR 8182117 : Document Zip File System Properties

Hi Lance, Alan, Overall looks good to me. > > A few comments > > > > > + * The Zip file system provider treats a Zip or JAR file as a file system > > + * providing the ability to manipulate its contents. > It might be a bit clearer to reduce this to: "The Zip file system > provider treats the

RFR: JDK-8217894: jpackage CLI syntax changes

Please review the jpackage fix for  [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). In response to internal and external feedback, the following syntax changes are being made to jpackage Command Line Interface (CLI): 1.) remove

Re: RFR: JDK-8218186 Clean up CLDR generation in build

Thanks, Magnus. The change looks good to me too. Naoto On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote: On 2019-02-01 14:43, naoto.s...@oracle.com wrote: Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Yes. I have verified this

Re: RFR 8218227 : StringBuilder constructor throws confusing NegativeArraySizeException

Hi Ivan, ok, looks fine to me. Thanks, Roger On 02/04/2019 05:12 PM, Ivan Gerasimov wrote: The reason for keeping HugeCapacity separate was that they require extra memory to be available, and they are skipped otherwise. And we want all "regular" Capacity tests to run always on all systems.

Re: [13] RFR 8217969, 8218265: Base64.Decoder.decode methods ... and java/util/Base64/TestEncodingDecodingLength.java failing

Looks good. Thanks, Roger On 02/05/2019 04:23 AM, Nishit Jain wrote: Thanks Roger, Naoto for reviewingthe changes Updated the webrev - Used ByteBuffer.wrap(inputBytes) instead of ByteBuffer.allocate(size) - Added Decoder.decode(ByteBuffer)method test. (line 58)

Re: RFR: JDK-8218186 Clean up CLDR generation in build

On 2019-02-01 14:43, naoto.s...@oracle.com wrote: Hi Magnus, I am assuming that the generated resource bundles are exactly the same as before this fix, correct? Yes. I have verified this using the COMPARE_BUILD functionality. /Magnus Naoto On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote: The

Re: [13] RFR 8217969, 8218265: Base64.Decoder.decode methods ... and java/util/Base64/TestEncodingDecodingLength.java failing

Thanks Roger, Naoto for reviewingthe changes Updated the webrev - Used ByteBuffer.wrap(inputBytes) instead of ByteBuffer.allocate(size) - Added Decoder.decode(ByteBuffer)method test. (line 58) http://cr.openjdk.java.net/~nishjain/8217969_8218265/webrev.01/ Regards, Nishit Jain On 05-02-2019

Re: RFR 8182117 : Document Zip File System Properties

A few comments On 04/02/2019 19:36, Lance Andersen wrote: : + * The Zip file system provider treats a Zip or JAR file as a file system + * providing the ability to manipulate its contents. It might be a bit clearer to reduce this to: "The Zip file system provider treats the contents of a

Re: RFR: JDK-8217317 : Create jpackage native library for windows

On 2019-02-01 23:38, Alexander Matveev wrote: Hi Magnus, http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/ Looks great, thank you! I can't comment on the actual source code changes, so you'll need a thumbs up from someone in core libs as well. Moved files to libjpackage and remove