Thank you, Daniel, Vyom
Pushed.
Regards,
Chris
> On 18 Mar 2020, at 6:03 PM, Daniel Fuchs wrote:
>
> Hi Chris,
>
> Thanks for that!
>
> It looks good to me.
>
> best regards,
>
> -- daniel
>
> On 16/03/2020 07:26, Chris Yin wrote:
>> Thanks for reviewing, Daniel, Vyom.
>> Hi, Daniel
>> I
On 3/18/20 12:13 PM, Maurizio Cimadamore wrote:
On 18/03/2020 18:40, Mandy Chung wrote:
On 3/18/20 11:16 AM, Maurizio Cimadamore wrote:
So, maybe I'm saying something naive, but isn't the difference
between the two mechanisms mostly there to distinguish between JNI
libraries and non-JNI
Looks good.
/Erik
On 2020-03-18 14:24, Roger Riggs wrote:
Hi,
Some small updates to the source files to minimize the changes to javadoc
of the _Stub classes.
And fixes to the points Magnus raises below.
http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/
Thanks, Roger
On
On Mar 18, 2020, at 3:01 PM, John Rose wrote:
>
> explicitCastArguments
P.S. That method has an intentionally scary name,
but behind the name, it’s just “asType, the JVM edition,
plus narrowing primitive conversions”. The design
center for asType is safe and sane conversions as
allowed by
On Mar 18, 2020, at 8:54 AM, Brian Goetz wrote:
>
> Overall, the approach seems sound, and I like that you are introducing only
> one new bootstrap that is usable for a range of things. A few comments and
> questions.
>
> 1. Not sure the explicit source type carries its weight, but
Hi Jorn,
This needs a CSR request before it can be pushed.
Thanks,
David
On 19/03/2020 12:08 am, Jorn Vernee wrote:
Hi,
Can someone please sponsor this patch that makes Boolean, Character,
Byte, and Short implement Constable?
Bug: https://bugs.openjdk.java.net/browse/JDK-8241100
Webrev:
The change has been pushed [1].
Brian
[1] http://hg.openjdk.java.net/jdk/jdk/rev/af221c1b1671
> On Mar 17, 2020, at 5:52 PM, Brent Christian
> wrote:
>
> Adding -XX:+CompactStrings seems reasonable to me. (And I think it's a
> betters solution than, say, increasing -Xmx to allow running
Hi,
Some small updates to the source files to minimize the changes to javadoc
of the _Stub classes.
And fixes to the points Magnus raises below.
http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-4/
Thanks, Roger
On 3/18/20 9:01 AM, Magnus Ihse Bursie wrote:
On 2020-03-17
On 18/03/2020 18:40, Mandy Chung wrote:
On 3/18/20 11:16 AM, Maurizio Cimadamore wrote:
So, maybe I'm saying something naive, but isn't the difference
between the two mechanisms mostly there to distinguish between JNI
libraries and non-JNI libraries?
I think such distinction is kind of
On 3/18/20 11:16 AM, Maurizio Cimadamore wrote:
So, maybe I'm saying something naive, but isn't the difference between
the two mechanisms mostly there to distinguish between JNI libraries
and non-JNI libraries?
I think such distinction is kind of blurry at the moment. One thing
for
So, maybe I'm saying something naive, but isn't the difference between
the two mechanisms mostly there to distinguish between JNI libraries and
non-JNI libraries?
E.g. maybe we should add JNI somewhere in one of the factory (the one
used by System.loadLibrary) and then document what are the
On 3/18/20 8:59 AM, Alan Bateman wrote:
On 17/03/2020 23:09, Mandy Chung wrote:
I have similar comment to myself and didn't come up good static
factory method names. I give it a try again: what about
newNativeLibraries and newNativeLibrariesWithNoAutoUnload?
Would
Hi Naoto,
ok to correct some time later.
The bug hasn't been updated, it still appears to be in progress. (They
are working to fix hgupdater)
I think waiting more than an hour for reviews is a good idea,
24hrs might be a minimum unless its urgent to fix a broken build.
Regards, Roger
On
On 17/03/2020 23:09, Mandy Chung wrote:
I have similar comment to myself and didn't come up good static
factory method names. I give it a try again: what about
newNativeLibraries and newNativeLibrariesWithNoAutoUnload?
Would newTrustedNativeLibraries work? Everything else in the updated
Hi Roger, thanks for the review.
On 3/18/20 7:42 AM, Roger Riggs wrote:
Hi Naoto,
EquivMapsGenerator.java: 242
It looks odd to put the warning about being an auto-generated file in
the middle of the declarations.
Perhaps add it to the headerText.
The existing maps are not pre-sized, is it
Overall, the approach seems sound, and I like that you are introducing only one
new bootstrap that is usable for a range of things. A few comments and
questions.
1. Not sure the explicit source type carries its weight, but whether it does
or not is probably informed by whatever we do for
On 13/03/2020 14:54, Denghui Dong wrote:
Good suggestion, moved.
Webrev: http://cr.openjdk.java.net/~ddong/8238665/webrev.03/
This looks much better.
What would you think about renaming the JFR event to
"DirectBufferStatistics"? The concern I have with the proposed naming is
that it will
Hi Naoto,
EquivMapsGenerator.java: 242
It looks odd to put the warning about being an auto-generated file in
the middle of the declarations.
Perhaps add it to the headerText.
The existing maps are not pre-sized, is it important to pre-size the new
ones.
There's no particular reason to
Hi,
Can someone please sponsor this patch that makes Boolean, Character,
Byte, and Short implement Constable?
Bug: https://bugs.openjdk.java.net/browse/JDK-8241100
Webrev: http://cr.openjdk.java.net/~jvernee/8241100/webrev.00/
Having the other box types implement Constable makes them easier
On 2020-03-17 23:07, Roger Riggs wrote:
Hi Magnus, Erik,
Thanks for the pointers, I'm not familiar with those early build
intricacies.
Updated:
http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/
Looking much better!
Please remove the reference to "rmic" in Global.gmk as
This looks good to me. Thanks for hanging in there!
/Erik
On 2020-03-17 15:07, Roger Riggs wrote:
Hi Magnus, Erik,
Thanks for the pointers, I'm not familiar with those early build
intricacies.
Updated:
http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073-2/
More cleanup:
-
Hi Chris,
Thanks for taking care of this followup fix.
I see at least three other places where `notifiers` is accessed
without a null check. It might be good to fix these three other
places too just in case.
(two addNamingListener methods and 1 removeNamingListener)
All of them are already
Hi Chris,
Thanks for that!
It looks good to me.
best regards,
-- daniel
On 16/03/2020 07:26, Chris Yin wrote:
Thanks for reviewing, Daniel, Vyom.
Hi, Daniel
I modified the test as you suggested to cover the potential issue with
URIBuilder, many thanks. Updated webrev as below:
Hello
Please review following changes to fix corner issue in
com.sun.jndi.ldap.EventSupport, thanks
Bug: https://bugs.openjdk.java.net/browse/JDK-8241130
Webrev: http://cr.openjdk.java.net/~xyin/8241130/webrev.00/
This is a follow up item which related to 8202117. When testing the second
Thank you Roger!
Pushed.
With kind regards,
Ivan
On 3/17/20 5:20 PM, Roger Riggs wrote:
Hi Ivan,
I see the CSR is approved.
I'm fine with the change.
Regards, Roger
On 2/25/20 3:18 PM, Ivan Gerasimov wrote:
Thank you Roger for reviewing CSR and the release note!
On 2/11/20 12:49 PM,
25 matches
Mail list logo
