Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

Hi Brian, thanks for your review. I've decided to push into jdk/jdk instead of jdk15. please let me know if you think this patch needs to be in jdk15, and I'll backport it there. Cheers, -- Igor > On Jul 30, 2020, at 2:39 PM, Brian Burkhalter > wrote: > > Hi Igor, > > This test looks all r

[PING?] RFR(S): 8248910: NPE when freeing the memory for a slice from a buffer

Ping... Any suggestions? Thanks, Felix > -Original Message- > From: Yangfei (Felix) > Sent: Wednesday, July 8, 2020 11:35 AM > To: core-libs-dev@openjdk.java.net > Subject: RFR(S): 8248910: NPE when freeing the memory for a slice from a > buffer > > Hi, > > Bug: https://bugs.openj

Re: RFR 8233048: WeekFields.ISO is not a singleton

Looks good Naoto. Thanks, Roger On 7/30/20 5:53 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8233048 The proposed chageset is located at: https://cr.openjdk.java.net/~naoto/8233048/webrev.00/ java.time.temporal.

RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

Please review the jpackage fix for bug [1] at [2]. - DMG image can get detach even if "hdiutil detach" return resource busy error. Fixed by stopping trying detach if DMG already got detach. [1] https://bugs.openjdk.java.net/browse/JDK-8250646 [2] http://cr.openjdk.java.net/~almatvee/8250646/we

Re: RFR 8233048: WeekFields.ISO is not a singleton

+1 -Joe On 7/30/20 2:53 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8233048 The proposed chageset is located at: https://cr.openjdk.java.net/~naoto/8233048/webrev.00/ java.time.temporal.WeekFields.ISO is instan

Re: RFR 8233048: WeekFields.ISO is not a singleton

+1 Stephen On Thu, 30 Jul 2020 at 22:54, wrote: > > Hi, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8233048 > > The proposed chageset is located at: > > https://cr.openjdk.java.net/~naoto/8233048/webrev.00/ > > java.time.temporal.WeekFields.ISO

RFR 8233048: WeekFields.ISO is not a singleton

Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8233048 The proposed chageset is located at: https://cr.openjdk.java.net/~naoto/8233048/webrev.00/ java.time.temporal.WeekFields.ISO is instantiated using the constructor, which is a different object r

Re: [15] RFR(S) : 6501010 : test/java/io/File/GetXSpace.java fails on Windows

Hi Igor, This test looks all right to me. Sorry for the late review. Thanks, Brian > On Jul 20, 2020, at 11:28 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//6501010/webrev.00 > >> 98 lines changed: 18 ins; 31 d

Re: [aarch64-port-dev ] RFR (XXL): 8223347: Integration of Vector API (Incubator): AArch64 backend changes

On 7/29/20 7:44 PM, Andrew Haley wrote: On 20/07/2020 04:51, Ningsheng Jian wrote: Since we are getting ready to propose Vector API target to JDK 16 [1]. I have regenerated webrev of aarch64 backend parts from panama repo, which has been rebased to jdk/jdk very recently, by: $ hg update vector-

Re: RFR [16/java.xml] 8250638: Address reliance on default constructors in java.xml

+1 > On Jul 30, 2020, at 12:20 PM, Joe Wang wrote: > > Hello, > > Please review a change to remove reliance of default constructors in java.xml. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8250638 > CSR: https://bugs.openjdk.java.net/browse/JDK-8250800 > > Patch: > > diff --git a/src/j

RE: RFR(s): Support graceful application termination on Windows shutdown/logoff

Hi core-libs-dev, I've been searching extensively the mailing list archives and JBS, but I cannot find any more information on this topic, apart from the two linked bug reports [1] and [2]. I apologize for my newbie 😊 search skills, can someone please help review the email I sent to hotspot-run

Re: RFR [16/java.xml] 8250638: Address reliance on default constructors in java.xml

Look fine Joe; thanks, -Joe On 7/30/2020 9:20 AM, Joe Wang wrote: Hello, Please review a change to remove reliance of default constructors in java.xml. JBS: https://bugs.openjdk.java.net/browse/JDK-8250638 CSR: https://bugs.openjdk.java.net/browse/JDK-8250800 Patch: diff --git a/src/java.

RFR [16/java.xml] 8250638: Address reliance on default constructors in java.xml

Hello, Please review a change to remove reliance of default constructors in java.xml. JBS: https://bugs.openjdk.java.net/browse/JDK-8250638 CSR: https://bugs.openjdk.java.net/browse/JDK-8250800 Patch: diff --git a/src/java.xml/share/classes/org/xml/sax/HandlerBase.java b/src/java.xml/share/

Re: RFR: JDK-8244288 Specialized implementations for putIfAbsent, merge, compute* methods in TreeMap derived maps

Hi Tagir, Thanks for your measured patience. I will take a look. Paul. > On Jul 26, 2020, at 9:04 AM, Tagir Valeev wrote: > > Hello! > > A gentle ping: please review > https://bugs.openjdk.java.net/browse/JDK-8244288 > http://cr.openjdk.java.net/~tvaleev/webrev/8244288/r1/ > The details are l

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

>> We don't need it; this is ancient history. Nonetheless, feel free to >> be consistent with the old style. I'll approve it. I understand. Thank you, Andrew! On 2020/07/30 21:13, Yasumasa Suenaga wrote: Hi Koichi, Looks good your change. BTW have you got a sponsor? I will sponsor you if you

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Hi Koichi, Looks good your change. BTW have you got a sponsor? I will sponsor you if you do not have yet. Thanks, Yasumasa On 2020/07/30 18:45, Andrew Haley wrote: On 7/30/20 6:58 AM, Koichi Sakata wrote: I just formatted the patch to be same as the other code. Moreover, I saw the follow

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, I have added myself as a reviewer to the CSR [1]. It would be good to get someone from security-dev to do the same, and then move the CSR state to "Proposed". best regards, -- daniel [1] https://bugs.openjdk.java.net/browse/JDK-8247311 On 30/07/2020 10:17, Alexey Bakhtin wrote: Ge

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

On 7/30/20 6:58 AM, Koichi Sakata wrote: > I just formatted the patch to be same as the other code. > > Moreover, I saw the following code in k_standard.c. > > if (_LIB_VERSION == _SVID_) >exc.retval = zero; > else >exc.retval = zero/zero; > > Do we need to do like that in this patch? It

Re: [PING?] RFR(s): 8247863: Unreachable code in OperatingSystemImpl.getTotalSwapSpaceSize()

On Thu, 2020-07-30 at 05:28 +, Baesken, Matthias wrote: > > The only reason why a 0 was observed, was because the cgroup interface > > files were missing and the old code mapped that to a 0. That's no > > longer the case and, thus, it seems it would make the code clearer if > > it wouldn't be t

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Gentle ping Regards Alexey > On 15 Jul 2020, at 14:18, Alexey Bakhtin wrote: > > Hello Daniel, > > I’ve updated CSR as you suggested and added kerberos ldap setup commands for > the client host in the JDK-8245527 > > Regards > Alexey