Hi Philippe,
On 22/09/2020 3:57 pm, Philippe Marschall wrote:
Hello
I am looking for a sponsor for JDK-8138732 [1]. The ready to integrate
PR is here [2].
Sorry I can't volunteer to sponsor this.
Changes between the current code and the reviewed code:
- I removed the jdk.internal export to
Hello
I am looking for a sponsor for JDK-8138732 [1]. The ready to integrate
PR is here [2].
Changes between the current code and the reviewed code:
- I removed the jdk.internal export to jdk.jfr, that was a review comment.
- I had to rebase and resolve a merge conflict with JDK-8243066.
[1]
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name
> in a new package
On Fri, 18 Sep 2020 23:11:46 GMT, Jason Tatton
wrote:
>> "the JVM has knowledge of the AVX capability of the chip it’s running on and
>> disables the AVX2 code path for chips
>> which suffer from the performance degradation which has been outlined in
>> this discussion"
>> Does it? The white p
Hi,
I'd like to propose a fix for JDK-8253451 [1] performance regression.
Webrev.00:
* http://cr.openjdk.java.net/~mbalao/webrevs/8253451/8253451.webrev.00
As explained in [1], the idea for the fix is to optimize the regexp
string for the most common group and decimal separator characters acro
> https://bugs.openjdk.java.net/browse/JDK-8231591
>
> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
> multiple launcher and tests to make sure installer
> will create shortcuts for all launchers.
> - Fixed Linux DesktopIntegration to create shortcuts for additional laun
On Mon, 21 Sep 2020 14:39:33 GMT, Alexey Semenyuk wrote:
> How about testing of other jpackage command line options in two phase mode?
> Like "--name", "--version"? Any plans to
> add them?
Plan was to file separate bugs for any additional options. I do not think we
should put everything in on
On Mon, 21 Sep 2020 09:20:56 GMT, Andrew Dinn wrote:
>>> Can you explain where this restricted effect is documented?
>>
>> Certainly! I’ve found that determining the capability of the CPU and whether
>> to enable AVX2 support if the chip
>> supports it is mostly controlled in: [vm_version_x86.c
On Tue, 22 Sep 2020 00:38:43 GMT, Serguei Spitsyn wrote:
>> Reviewed in the good old hg times :)
>> See also
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
>
> Hi Richard,
>
> Could you consider to place the classes EscapeBarrier and
> JvmtiDeferredUpdate
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by
> jlink.
Ian Graves h
On Mon, 21 Sep 2020 15:52:15 GMT, Alan Bateman wrote:
>> 1. I agree that it's awkward and I'm not a huge fan. I'm okay doing it this
>> way, but this is recreating the reproducer
>> for https://bugs.openjdk.java.net/browse/JDK-8252730 which is two identical
>> JDK's in different directories. I
On Thu, 17 Sep 2020 07:45:52 GMT, Goetz Lindenmaier wrote:
>> Marked as reviewed by goetz (Reviewer).
>
> Reviewed in the good old hg times :)
> See also
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041453.html
src/hotspot/share/opto/macro.cpp:
@@ -1091,11 +1091,11
On Mon, 21 Sep 2020 14:05:08 GMT, Alexey Semenyuk wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8231591
>>
>> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
>> multiple launcher and tests to make sure installer
>> will create shortcuts for all launchers.
>> - Fixed
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Mon, 21 Sep 2020 19:36:03 GMT, Andy Herrick wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and
>> Linux
>> When jpackage builds a package from an app-image that was not generated by
>> jpackage, the tool should give user a
>> warning message, and then comple
On Mon, 21 Sep 2020 21:53:05 GMT, Joe Darcy wrote:
>> Please review the fix for [1]. The intention of this patch is to make
>> records final removing the need to
>> use --enable-preview in order to be able to include a record declaration in
>> a source or for the VM to execute code
>> compiled
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
8253208: Move CDS related code
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Mon, 21 Sep 2020 21:36:39 GMT, Vicente Romero wrote:
>> Co-authored-by: Vicente Romero
>> Co-authored-by: Harold Seigel
>> Co-authored-by: Jonathan Gibbons
>> Co-authored-by: Brian Goetz
>> Co-authored-by: Maurizio Cimadamore
>> Co-authored-by: Joe Darcy
>> Co-authored-by: Chris Hegarty
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote:
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-a
Co-authored-by: Vicente Romero
Co-authored-by: Harold Seigel
Co-authored-by: Jonathan Gibbons
Co-authored-by: Brian Goetz
Co-authored-by: Maurizio Cimadamore
Co-authored-by: Joe Darcy
Co-authored-by: Chris Hegarty
Co-authored-by: Jan Lahoda
-
Commit messages:
- 8246774: Recor
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by
> jlink.
Ian Graves h
> 8253149: Building an installer from invalid app image fails on Windows and
> Linux
> When jpackage builds a package from an app-image that was not generated by
> jpackage, the tool should give user a
> warning message, and then complete the package anyway.
Andy Herrick has updated the pull req
On Mon, 21 Sep 2020 12:18:40 GMT, Alan Bateman wrote:
> Update to Deflater.c looks good.
>
> DeflaterDictionaryTests looks like is a shaping up to be a good test for
> setDictionary. Are there other assertions that
> should be checked, e.g. setDictionary(ByteBuffer) is specified to consume all
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
> Hi all,
>
> Please review the fix for JDK-8252739 which addresses an issue introduced by
> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored
> the offset specified by
> Deflater.setDictionary. Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly
> as well as the java/u
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
On Sun, 20 Sep 2020 06:10:53 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8253208: Move CDS related code to a separate class
>
> src/java.base/share/native/libjava/CDS.c line 49:
>
>> 47: JNIEXPORT jbo
> With more CDS related code added to VM, it is time to move CDS code to a
> separate class. CDS is the new class which is
> specific to CDS.
> Tests: tier1-4
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
8253208: Move CDS related code
On Mon, 21 Sep 2020 14:17:18 GMT, Ian Graves wrote:
>> test/jdk/tools/jlink/JLinkReproducible3Test.java line 112:
>>
>>> 110: }
>>> 111: }
>>> 112:
>>
>> The update to ImageFileCreator looks good.
>>
>> A few nits in JLinkReproducible3Test:
>> 1. Invoking copyJDKs with two destination loca
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Mon, 21 Sep 2020 08:15:20 GMT, Bernhard Urban-Forster
wrote:
>> Hey @erikj79, thank you so much for giving it a try!
>>
>>> Our linux-aarch64 build fails with this:
>>> cc: error: unrecognized command line option '-std=c++14'
>>> when compiling
>>> build/linux-aarch64/buildjdk/hotspot/varia
> Continuing this review as a PR on github with the comments below
> incorporated. I expect there will be a few more
> iterations before integrating.
> On 06/09/2020 19:47, Alan Bateman wrote:
>> On 26/08/2020 15:24, Michael McMahon wrote:
>>>
>>> As I mentioned the other day, I wasn't able to use
On Sat, 19 Sep 2020 02:42:27 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8231591
>
> - Added MultiLauncherTwoPhaseTest which uses predefine app image with
> multiple launcher and tests to make sure installer
> will create shortcuts for all launchers.
> - Fixed Li
On Sat, 19 Sep 2020 16:04:36 GMT, Alan Bateman wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using File.walk for copy
>
> test/jdk/tools/jlink/JLinkReproducible3Test.java line 112:
>
>> 110: }
>> 111: }
>> 112
On Sun, 20 Sep 2020 14:14:51 GMT, Roger Riggs wrote:
>> # JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter
>>
>> Debugging functions that utilize ASN.1, DER, and BER encoded streams is
>> difficult without test utilities to show the contents.
>> The ASN.1 formatter reads a s
On Sun, 20 Sep 2020 21:23:17 GMT, Andy Herrick wrote:
> 8253149: Building an installer from invalid app image fails on Windows and
> Linux
> When jpackage builds a package from an app-image that was not generated by
> jpackage, the tool should give user a
> warning message, and then complete th
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote:
> JDK-8230652
> Extracting the commands displayed by verbose output (including commands
> called thru ToolProvider) , to contain the the
> command, it's output, and it's return value on separate lines and formatted
> in a way that they can b
> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1
> byte encoded Strings). It is provided for
> x86 and ARM64. The implementation is greatly inspired by the indexOf(char)
> intrinsic for StringUTF16. To incorporate it
> I had to make a small change to StringLatin1.jav
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
> hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the
> issue, I fixed a parameter des
On Sun, 20 Sep 2020 22:22:47 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8252739 which addresses an issue introduced by
>> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored
>> the offset specified by
>> Deflater.setDictionary. Mach5 jdk-t
> This pull request is identical with the RFR previously sent for the Mercurial
> repository:
>
> https://mail.openjdk.java.net/pipermail/javadoc-dev/2020-August/001796.html
>
> I'm copy-pasting the comments from the original RFR below.
>
> Most of the new code is added to the Extern class wher
On Fri, 18 Sep 2020 11:56:09 GMT, Jason Tatton
wrote:
>> This is an implementation of the indexOf(char) intrinsic for StringLatin1 (1
>> byte encoded Strings). It is provided for
>> x86 and ARM64. The implementation is greatly inspired by the indexOf(char)
>> intrinsic for StringUTF16. To inco
On 21/09/2020 09:18, Bernhard Urban-Forster wrote:
> Thank you Andrew. Is the goal to reduce the patch diff in
> `assembler_aarch64.cpp`? If so, we need to get rid of the
> retry in your patch to avoid additional calls to `random`, e.g. something
> like this (the diff for the generated part
> wou
On Fri, 18 Sep 2020 23:11:46 GMT, Jason Tatton
wrote:
> >Can you explain where this restricted effect is documented?
> Certainly! I’ve found that determining the capability of the CPU and whether
> to enable AVX2 support if the chip
> supports it is mostly controlled in: vm_version_x86.cp
I'm also thinking about something:
If `T find()` gets implemented on `Iterable` with the contract that
this method always ends, this implies that the amount of elements
available in the Iterable is finite, which makes it possible to define
a `int size()` by providing a trivial predicate.
This woul
Hi all,
Correct me if I'm wrong, but isn't the goal of Iterable be used as
argument in a enhanced for-loop, that is: just allow a enhanced
syntax.
(Similarly, AUtoCloseable is what allows the try-with-resource syntax;
Throwable is what allows the throw syntax)
As such, isn't it out of scope of It
Hi,
Plaese review JDK-8245527 fix which implements LDAP Channel Binding support for
Java GSS/Kerberos.
Initial review is available at core-devs:
https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068197.html
This version removes "tls-unique" CB type from the list of possible chann
On Fri, 18 Sep 2020 18:38:34 GMT, Bernhard Urban-Forster
wrote:
>> Our linux-aarch64 build fails with this:
>> cc: error: unrecognized command line option '-std=c++14'
>> when compiling
>> build/linux-aarch64/buildjdk/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch
>>
>> I'm
Hi Nir,
at first I thought "Wow, it would be really cool to have that method in
Iterable! Why isn't it there already?"
But after thinking about it, I'm now convinced that it would be a bad
idea. Because it extends the scope of this small, tiny Iterable
interface to something bigger which it
On Fri, 18 Sep 2020 20:34:55 GMT, Erik Joelsson wrote:
> I assume you need the rest of the PATH on Windows.
Doesn't look like it actually. I've reverted it, thanks for catching it.
-
PR: https://git.openjdk.java.net/jdk/pull/212
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
52 matches
Mail list logo
