Re: RFR: 8180352: Add Stream.toList() method [v2]

2020-11-09 Thread Stuart Marks
On Sun, 8 Nov 2020 15:55:58 GMT, Peter Levart wrote: >> Hi Stuart, >> >> I would like to discuss the serialization. You introduce new >> CollSer.IMM_LIST_NULLS type of immutable collection. This means that if this >> change goes into JDK16 for example, JDK15 and before will not be able to >>

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread David Holmes
On 10/11/2020 2:34 am, Jorn Vernee wrote: On Mon, 9 Nov 2020 12:11:56 GMT, Jorn Vernee wrote: I agree with Coleen. I'll give this another try, but I think last time I tried this resolution of the class failed when trying to build the JDK, seemingly since it exists in an incubator module, w

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v16]

2020-11-09 Thread David Holmes
On Mon, 9 Nov 2020 18:25:27 GMT, Maurizio Cimadamore wrote: >> This patch contains the changes associated with the first incubation round >> of the foreign linker access API incubation >> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory >> access support (see JEP 393 [

Re: RFR: 8247781: Day periods support [v11]

2020-11-09 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v16]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v12]

2020-11-09 Thread Corey Ashford
On Mon, 26 Oct 2020 19:27:59 GMT, Paul Murphy wrote: >> Because the bytes are displayed e15..e8, instead of the other way around, >> it's hard to follow. As an example, consider just the last four bytes of >> the table, but displayed in the reverse order: >> >> 00||b0:0..500||b0:6..7||b1

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:52:27 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:56:38 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo in upcall helper for aarch64 > > src/java.base/share/classes/java/lang/System.java line 2086: > >> 2084

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Fri, 6 Nov 2020 22:02:31 GMT, Coleen Phillimore wrote: >> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 81: >> >>> 79: #endif >>> 80: >>> 81: Method* method = k->lookup_method(mname_sym, mdesc_sym); >> >> This "method" appears unused. > > This should be moved into javaCl

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 12:11:56 GMT, Jorn Vernee wrote: >> I agree with Coleen. > > I'll give this another try, but I think last time I tried this resolution of > the class failed when trying to build the JDK, seemingly since it exists in > an incubator module, which is not always added to the modu

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Fri, 6 Nov 2020 22:07:39 GMT, Coleen Phillimore wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v26]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Integrated: 8254078: DataOutputStream is very slow post-disabling of Biased Locking

2020-11-09 Thread Andrew Haley
On Wed, 7 Oct 2020 13:30:14 GMT, Andrew Haley wrote: > DataOutputStream is very slow post-disabling of Biased Locking. This > was discovered when benchmarking a transaction library, which showed > significant performance loss when moving to JDK 15. WIth some small > changes to DataOutputStream we

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v25]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
Hi David, On 09/11/2020 14:51, David Holmes wrote: Hi Jorn, On 9/11/2020 9:57 pm, Jorn Vernee wrote: On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 99: 97:   if (thread == NULL) { 98: JavaVM_ *vm = (JavaVM *)(&main

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread David Holmes
Hi Jorn, On 9/11/2020 9:57 pm, Jorn Vernee wrote: On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 99: 97: if (thread == NULL) { 98: JavaVM_ *vm = (JavaVM *)(&main_vm); 99: vm -> functions -> AttachCurrentThreadAs

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v24]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v23]

2020-11-09 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which can

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v22]

2020-11-09 Thread Maurizio Cimadamore
On Sun, 8 Nov 2020 16:28:41 GMT, Alan Bateman wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 29 commits: >> >> - Fix post-merge issues caused by 8219014 >> - Merge branch 'master' into 8254162 >>

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:31:15 GMT, David Holmes wrote: >> src/hotspot/cpu/aarch64/universalUpcallHandler_aarch64.cpp line 55: >> >>> 53: >>> 54: // FIXME: This should be initialized explicitly instead of lazily/racily >>> 55: static void upcall_init() { >> >> The FIXME is right this should be in

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 03:29:05 GMT, David Holmes wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v15]

2020-11-09 Thread Jorn Vernee
On Mon, 9 Nov 2020 06:07:32 GMT, Nick Gasson wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 82190

RFR: 8256037: [TESTBUG] com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails due to the hard coded threshold is small

2020-11-09 Thread Jie Fu
Hi all, May I get reviews for this change? com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some of our testing platforms. The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller than that (e.g., 1026 ms) on our platforms. The fix just increases the

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v3]

2020-11-09 Thread Roland Westrelin
On Sat, 7 Nov 2020 11:38:37 GMT, Vladimir Ivanov wrote: >> Roland Westrelin has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > src/hotspot/share/opto/castnode.

Re: RFR: 8255150: Add utility methods to check long indexes and ranges [v4]

2020-11-09 Thread Roland Westrelin
> This change add 3 new methods in Objects: > > public static long checkIndex(long index, long length) > public static long checkFromToIndex(long fromIndex, long toIndex, long length) > public static long checkFromIndexSize(long fromIndex, long size, long length) > > This mirrors the int utility