Hi Stuart,
1: If there is no match at all, then results yields the empty stream. I
don't think anything else is required.
2/3: I wrote a fair number of regex patterns in Java, ever since they
appeared in 2002. I can say with confidence that I never once used
hitEnd/requireEnd, or seen it
Fixed by using correct localized resources.
-
Commit messages:
- 8255619: Localized WinResources.properties have MsiInstallerStrings_en.wxl
resource
Changes: https://git.openjdk.java.net/jdk/pull/1638/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1638=00
Issue:
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
Marked as reviewed by mikael (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1531
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal
> - Revise "value-based class" & apply
On Fri, 4 Dec 2020 16:02:33 GMT, Roger Riggs wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Fri, 4 Dec 2020 19:13:45 GMT, Roger Riggs wrote:
>> The preconditions aren't checked, because this is an internal method, and
>> the code size is minimized in order to help inlining. That's also why
>> `hugeLength` is a separate method. (I guess I could add comments to this
>> effect.)
On Thu, 3 Dec 2020 22:54:13 GMT, Ivan Šipka wrote:
>> Defined new test groups as defined in ticket. @fguallini
>
> Ivan Šipka has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous
On Fri, 4 Dec 2020 22:38:24 GMT, Mandy Chung wrote:
>> This patch replaces some uses of `Reference::get` to `Reference::refersTo`
>> to avoid keeping a referent strongly reachable that could cause unnecessary
>> delay in collecting such object. I only made change in some but not all
>>
Integration of JEP 390, addressing the following issues:
8252180: [JEP 390] Deprecate wrapper class constructors for removal
8254047: [JEP 390] Revise "value-based class" & apply to wrappers
8252181: [JEP 390] Define & apply annotation jdk.internal.ValueBased
8252183: [JEP 390] Add 'lint' warning
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1531
On Fri, 4 Dec 2020 22:06:03 GMT, Martin Buchholz wrote:
> Add missing semicolon
>
> Martin's first github pr.
Looks trivially fine.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1633
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes in core libraries when working with Kim on
Add missing semicolon
Martin's first github pr.
-
Commit messages:
- JDK-8243614-typo
Changes: https://git.openjdk.java.net/jdk/pull/1633/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1633=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8243614
Stats: 1 line in
On Fri, 4 Dec 2020 20:39:58 GMT, Joe Darcy wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add class level clarification of use of uppercase for primitive conversions
>> Switched order of declaration of a couple
On Fri, 4 Dec 2020 20:14:13 GMT, Peter Levart wrote:
>> Good point on checking k != null. A cleaner check:
>>
>> // then check for equality if the referent is not cleared
>> Object k = e.get();
>> return k != null || key.equals(k);
>
> You meant: `return k != null &&
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
Build changes look good and I'm happy there are so few of them!
-
Marked as reviewed by erikj (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1531
On Tue, 1 Dec 2020 07:38:13 GMT, David Holmes wrote:
>> Start of JDK 17 updates.
>
> Looks good - 99% sym stuff :)
>
> Doesn't look like the hotspot deprecated flag test will need updating this
> time, as no newly deprecated flags marked for obsoletion in 17.
Usual start of release update:
*
On Tue, 1 Dec 2020 07:33:25 GMT, David Holmes wrote:
>> Start of JDK 17 updates.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 226:
>
>> 224: REIFIABLE_TYPES_INSTANCEOF(JDK16,
>> Fragments.FeatureReifiableTypesInstanceof, DiagKind.PLURAL),
>> 225:
On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote:
> Start of JDK 17 updates.
Looks good - 99% sym stuff :)
Doesn't look like the hotspot deprecated flag test will need updating this
time, as no newly deprecated flags marked for obsoletion in 17.
src/hotspot/share/opto/type.cpp line 827:
>
Start of JDK 17 updates.
-
Commit messages:
- Update tests.
- Merge branch 'master' into JDK-8257450
- Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
- Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
- JDK-8257450
-
On Fri, 4 Dec 2020 19:44:33 GMT, Mahendra Chhipa
wrote:
> jaxp.library.SimpleHttpServer
> https://bugs.openjdk.java.net/browse/JDK-8212035
Changes requested by dfuchs (Reviewer).
test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
> 78:
On Fri, 4 Dec 2020 20:32:02 GMT, Daniel Fuchs wrote:
>> jaxp.library.SimpleHttpServer
>> https://bugs.openjdk.java.net/browse/JDK-8212035
>
> test/jdk/sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java line 80:
>
>> 78: creator.buildSignedMultiReleaseJar();
>> 79:
>> 80:
On Fri, 4 Dec 2020 19:51:54 GMT, Mandy Chung wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test base,
On Wed, 2 Dec 2020 16:33:15 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Wed, 2 Dec 2020 16:33:15 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Fri, 4 Dec 2020 20:16:14 GMT, Mandy Chung wrote:
>> src/java.management/share/classes/com/sun/jmx/mbeanserver/WeakIdentityHashMap.java
>> line 127:
>>
>>> 125: T got = get();
>>> 126: return got != null && wr.refersTo(got);
>>> 127: }
>>
>> Here you could
On Fri, 4 Dec 2020 16:58:56 GMT, Brian Burkhalter wrote:
> Please review this trivial change to make the `writeBuffer` array field final
> and move it to the beginning of the class where other fields are declared.
This pull request has now been integrated.
Changeset: e27ea4d1
Author:Brian
On Fri, 4 Dec 2020 19:47:17 GMT, Peter Levart wrote:
>> This patch replaces some uses of `Reference::get` to `Reference::refersTo`
>> to avoid keeping a referent strongly reachable that could cause unnecessary
>> delay in collecting such object. I only made change in some but not all
>>
On Fri, 4 Dec 2020 20:05:23 GMT, Kevin Rushforth wrote:
>> This patch replaces some uses of `Reference::get` to `Reference::refersTo`
>> to avoid keeping a referent strongly reachable that could cause unnecessary
>> delay in collecting such object. I only made change in some but not all
>>
On Fri, 4 Dec 2020 20:09:01 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/util/WeakHashMap.java line 293:
>>
>>> 291: // then checks for equality
>>> 292: Object k = e.get();
>>> 293: return key == k || key.equals(k);
>>
>> I think `key == k` is already
On Fri, 4 Dec 2020 18:12:36 GMT, Kim Barrett wrote:
>> This patch replaces some uses of `Reference::get` to `Reference::refersTo`
>> to avoid keeping a referent strongly reachable that could cause unnecessary
>> delay in collecting such object. I only made change in some but not all
>>
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
On Wed, 2 Dec 2020 10:00:21 GMT, Chris Hegarty wrote:
>> Update Class::isRecord to only return true for classes that are final.
>>
>> The removal of non-specified JVM checks on classes with a Record Attribute
>> (see JDK-8255342), has resulted in more types of loadable classes that may
>>
On Fri, 4 Dec 2020 18:23:55 GMT, Brent Christian wrote:
> Please review this fix for the intermittently-failing
> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>
> The change replaces System.gc()+sleep() with the more robust gcAwait()
> mechanic used elsewhere in the test base,
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
jaxp.library.SimpleHttpServer
https://bugs.openjdk.java.net/browse/JDK-8212035
-
Commit messages:
- JDK-8212035 merge jdk.test.lib.util.SimpleHttpServer with
Changes: https://git.openjdk.java.net/jdk/pull/1632/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1632=00
On Fri, 4 Dec 2020 17:49:25 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/jdk/internal/util/ArraysSupport.java line 640:
>>
>>> 638: int prefLength = oldLength + Math.max(minGrowth, prefGrowth);
>>> // might overflow
>>> 639: if (0 < prefLength && prefLength <=
Hi Cay,
Thanks for mentioning this. It's good to know that adding this provides value to
people who are actually trying to use this stuff (as opposed to adding stuff merely
for the sake of completeness, as often seems to arise).
I've added some notes to JDK-8065554.
Looking at this more
On Fri, 4 Dec 2020 16:54:26 GMT, Pavel Rappo wrote:
>> @pavelrappo Please see my updated CSR below. Thanks.
>>
>> # Map::compute should have the implementation requirement match its default
>> implementation
>>
>> ## Summary
>>
>> The implementation requirement of Map::compute does not match
Please review this fix for the intermittently-failing
java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
The change replaces System.gc()+sleep() with the more robust gcAwait() mechanic
used elsewhere in the test base, [as pointed out by
On Fri, 4 Dec 2020 06:50:14 GMT, Stuart Marks wrote:
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
On Fri, 4 Dec 2020 09:19:23 GMT, Aleksey Shipilev wrote:
>> This patch replaces some uses of `Reference::get` to `Reference::refersTo`
>> to avoid keeping a referent strongly reachable that could cause unnecessary
>> delay in collecting such object. I only made change in some but not all
>>
On Fri, 4 Dec 2020 16:22:28 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Fri, 4 Dec 2020 15:53:01 GMT, Roger Riggs wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Fri, 4 Dec 2020 15:47:51 GMT, Roger Riggs wrote:
>> This rewrites the doc of ArraysSupport.newLength, adds detail to the
>> exception message, and adds a test. In addition to some renaming and a bit
>> of refactoring of the actual code, I also made two changes of substance to
>> the code:
On Fri, 4 Dec 2020 17:22:29 GMT, Brian Burkhalter wrote:
>> Please review this trivial change to make the `writeBuffer` array field
>> final and move it to the beginning of the class where other fields are
>> declared.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
> Please review this trivial change to make the `writeBuffer` array field final
> and move it to the beginning of the class where other fields are declared.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8257750: Change "byte
On Fri, 4 Dec 2020 16:58:56 GMT, Brian Burkhalter wrote:
> Please review this trivial change to make the `writeBuffer` array field final
> and move it to the beginning of the class where other fields are declared.
Marked as reviewed by naoto (Reviewer).
-
PR:
On Fri, 4 Dec 2020 16:58:56 GMT, Brian Burkhalter wrote:
> Please review this trivial change to make the `writeBuffer` array field final
> and move it to the beginning of the class where other fields are declared.
Marked as reviewed by lancea (Reviewer).
-
PR:
Please review this trivial change to make the `writeBuffer` array field final
and move it to the beginning of the class where other fields are declared.
-
Commit messages:
- 8257750: writeBuffer field of java.io.DataOutputStream should be final
Changes:
On Sat, 28 Nov 2020 08:42:52 GMT, John Lin
wrote:
>> @johnlinp In any case, you'd also need to update the surrounding prose; we
>> need to remove this:
>> returning the current value or {@code null} if absent:```
>
> @pavelrappo Please see my updated CSR below. Thanks.
>
> # Map::compute
On Fri, 4 Dec 2020 16:22:28 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Fri, 4 Dec 2020 13:25:04 GMT, Alan Bateman wrote:
>> Jan Lahoda has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference conversion to allow for stricter
>> checking of cast
On Fri, 4 Dec 2020 06:50:14 GMT, Stuart Marks wrote:
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
On Mon, 30 Nov 2020 15:08:51 GMT, Pavel Rappo wrote:
>> @johnlinp, thanks for updating the CSR draft; it is much better now.
>>
>> @stuart-marks, I think we could further improve this snippet. This `if`
>> statement seems to use an optimization:
>>
>> if (oldValue != null ||
On Fri, 4 Dec 2020 14:05:54 GMT, Erik Joelsson wrote:
>> My understanding of JEPs is that they should be viewed as living documents.
>> In this case, I think it's perfectly valid to update JEP 201 with additional
>> source code layout. Both for this and for the other missing dirs.
>
>
On Fri, 4 Dec 2020 13:12:27 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Fri, 4 Dec 2020 12:30:02 GMT, Alan Bateman wrote:
>> And I can certainly move jdwp.spec to java.base instead. That's the reason I
>> need input on this: All I know is that is definitely not the responsibility
>> of the Build Group to maintain that document, and I made my best guess at
>>
On Fri, 4 Dec 2020 14:03:08 GMT, Erik Joelsson wrote:
>>> And I can certainly move jdwp.spec to java.base instead.
>>
>> If jdwp.spec has to move to the src tree then src/java.se is probably the
>> most suitable home because Java SE specifies JDWP as an optional interface.
>> So nothing to
> The default implementation of javax.xml.stream.XMLEventReader produced a
> StartDocument event that always indicated that the "standalone" attribute was
> set.
>
> The root cause of this was that the
> com.sun.xml.internal.stream.events.XMLEventAllocatorImpl always set the
> "standalone"
On Fri, 4 Dec 2020 13:12:27 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference conversion to allow for stricter
>> checking of cast
On Fri, 4 Dec 2020 11:38:51 GMT, Magnus Ihse Bursie wrote:
> And I can certainly move jdwp.spec to java.base instead.
If jdwp.spec has to move to the src tree then src/java.se is probably the most
suitable home because Java SE specifies JDWP as an optional interface. So
nothing to do with
On Wed, 2 Dec 2020 18:47:10 GMT, Maurizio Cimadamore
wrote:
> The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
> annotations. This causes odd behavior on certain benchmarks, especially if
> these methods are called many times in the body of a single method.
This
On Fri, 4 Dec 2020 11:14:49 GMT, Alan Bateman wrote:
>> To facilitate review, here is a list on how the different directories under
>> make/data has moved.
>>
>> **To java.base:**
>> * blacklistedcertsconverter
>> * cacerts
>> * characterdata
>> * charsetmapping
>> * cldr
>> * currency
>> *
On Fri, 4 Dec 2020 11:37:41 GMT, Magnus Ihse Bursie wrote:
>> Are you proposing any text or guidelines to be added to JEP 201 as part of
>> this?
>>
>> I think the location of jdwp.spec and its location in the build tree may
>> need to be looked at again. It was convenient to have it in the
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
On Fri, 4 Dec 2020 10:29:48 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> The accessor methods in the `MemoryAccess` class are missing `@ForceInline`
> annotations. This causes odd behavior on certain benchmarks, especially if
> these methods are called many times in the body of a single method.
Maurizio Cimadamore has updated the pull request incrementally with
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie wrote:
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
A lot (but not all) of the data in make/data is tied to a specific module. For
instance, the publicsuffixlist is used by java.base, and fontconfig by
java.desktop. (A few directories, like mainmanifest, is *actually* used by make
for the whole build.)
These data files should move to the
On Wed, 2 Dec 2020 16:33:15 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Wed, 2 Dec 2020 16:33:15 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung wrote:
> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to
> avoid keeping a referent strongly reachable that could cause unnecessary
> delay in collecting such object. I only made change in some but not all
> classes
On Tue, 24 Nov 2020 10:58:43 GMT, Alan Bateman wrote:
> The attribute_length of known Module attributes in the module-info.class
> is currently ignored. It should be checked and the class rejected if the
> attribute length doesn't exactly match the length of the info in the
> attribute.
>
78 matches
Mail list logo
