On Wed, 14 Apr 2021 14:08:50 GMT, Roger Riggs wrote:
> The most recent intermittent failure showed that the error occurred during VM
> initialization.
> Only the tty output was diverted, but not log output.
> Add diversion of log output as well tty output.
>
> Add `-Xlog:all=warning:stderr`
On Thu, 15 Apr 2021 01:57:01 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Wed, 14 Apr 2021 18:01:10 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update existing NarrowNamesTest to match expectations
>> - Naoto's review suggestion
>
>
> Can I please get a review for this proposed fix for
> https://bugs.openjdk.java.net/browse/JDK-8262108?
>
> As noted in a comment in that issue, the bug relates to the return value of
> `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation
> has started returning
- Issue was reproducible when install-dir points to some invalid location.
- Fixed by defaulting DMG drag and drop location to /Applications folder and
--install-dir will be ignored with warning for DMG.
- I do not see any way to support other valid, but uncommon locations for drag
and drop.
Hi Ralph,
I've added an apache-log4j-interest label to the issue.
cheers,
dalibor topic
On 14.04.2021 19:00, Ralph Goers wrote:
I don’t have an account in the bug tracking system. Could someone possibly
update the issue noted below to indicate that Apache Log4j 2 would also like
that
On Wed, 14 Apr 2021 11:38:15 GMT, Jorn Vernee wrote:
>> This patch implements 2 leftover TODOs for implementing var handle invoker
>> MH caching (lambda forms for those were already shared/cached).
>>
>> This piggybacks on the existing mechanism for method handle invoker caching.
>>
>>
On Wed, 14 Apr 2021 21:26:52 GMT, Claes Redestad wrote:
>> This patch reduces work done initializing VarForms - mostly observed when
>> loading each VarHandle implementation class.
>>
>> - Lazily resolve MemberNames.
>> - Streamline MethodType creation. This reduces the number of MethodTypes
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
>
On Wed, 14 Apr 2021 19:54:26 GMT, Florent Guillaume
wrote:
>> While JDK-8148937 improved StringJoiner class by replacing internal use of
>> getChars that copies out characters from String elements into a char[] array
>> with StringBuilder which is somehow more optimal, the improvement was
>>
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
>
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
>
> This patch reduces work done initializing VarForms - mostly observed when
> loading each VarHandle implementation class.
>
> - Lazily resolve MemberNames.
> - Streamline MethodType creation. This reduces the number of MethodTypes
> created.
>
> Net effect is a reduction in bytecode executed
Please review the changes to support CLDR version 39. The vast majority of the
changes are purely data changes from Unicode. The only change affected in logic
was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with CLDR's
Norwegian language code switch
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
On Tue, 13 Apr 2021 18:57:20 GMT, Andy Herrick wrote:
> two changes:
> One to jpackage, when recursively removing directory, when IOException
> occurs, record it and continue (deleting as much as possible) before throwing
> the exception.
> The other to tests, when running jpackage via
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote:
> While JDK-8148937 improved StringJoiner class by replacing internal use of
> getChars that copies out characters from String elements into a char[] array
> with StringBuilder which is somehow more optimal, the improvement was
> marginal
While JDK-8148937 improved StringJoiner class by replacing internal use of
getChars that copies out characters from String elements into a char[] array
with StringBuilder which is somehow more optimal, the improvement was marginal
in speed (0% ... 10%) and mainly for smaller strings, while GC
On Wed, 14 Apr 2021 17:14:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Wed, 14 Apr 2021 17:36:21 GMT, Alexey Semenyuk wrote:
> postVisitDirectory() and visitFile() methods can be potentially called
> concurrently by walkFileTree()
I don't think they can.
> Javadoc ... doesn't say anything about synchronization, so I think it is fair
> to assume it is not
> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
change static final from 'proxy' to 'PROXY'
-
Changes:
- all:
On Tue, 13 Apr 2021 21:10:56 GMT, Kevin Rushforth wrote:
> Are you sure you need an `AtomicReference` to set the exception? I don't see
> any use of multiple threads, but I might be missing something. If you do need
> it, you need to fix the order of arguments.
`postVisitDirectory()` and
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via
Add check for null.
-
Commit messages:
- Check for null source
- Make makeXXXSpliterator final
- Move makeXXXSpilterator from public (@hidden) to protected. No API change.
Changes: https://git.openjdk.java.net/jdk/pull/3495/files
Webrev:
> This patch reduces work done initializing VarForms - mostly observed when
> loading each VarHandle implementation class.
>
> - Lazily resolve MemberNames.
> - Streamline MethodType creation. This reduces the number of MethodTypes
> created.
>
> Net effect is a reduction in bytecode executed
On Wed, 14 Apr 2021 11:35:14 GMT, Claes Redestad wrote:
>> This patch reduces work done initializing VarForms - mostly observed when
>> loading each VarHandle implementation class.
>>
>> - Lazily resolve MemberNames.
>> - Streamline MethodType creation. This reduces the number of MethodTypes
On Wed, 14 Apr 2021 12:27:55 GMT, Jim Laskey wrote:
>> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make makeXXXSpliterator final
I don't see the
On Wed, 14 Apr 2021 17:14:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
> Can I please get a review for this proposed fix for
> https://bugs.openjdk.java.net/browse/JDK-8262108?
>
> As noted in a comment in that issue, the bug relates to the return value of
> `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation
> has started returning
I don’t have an account in the bug tracking system. Could someone possibly
update the issue noted below to indicate that Apache Log4j 2 would also like
that enhancement?
Thanks,
Ralph
> On Apr 5, 2021, at 1:26 PM, Roger Riggs wrote:
>
> Hi,
>
> Java does not have a data type with enough
On Wed, 14 Apr 2021 12:27:55 GMT, Jim Laskey wrote:
>> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make makeXXXSpliterator final
To me this looks
On Wed, 14 Apr 2021 15:03:19 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added comment to System.out/err init.
>
> src/java.base/share/classes/java/lang/System.java line 166:
>
>> 164: *
> Please review the changes for the subject issue. This has been suggested in
> a recent discussion thread for the JEP 400
> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
> A CSR has also been drafted, and comments are welcome
>
On Wed, 14 Apr 2021 15:27:36 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Could I get the following trivial doc changes reviewed please, caused by:
>>
>> - broken tags in MethodHandles referring to package.html instead of
>> package-summary.html
>>
>> - references to a package level #unixdomain
On Fri, 9 Apr 2021 09:41:19 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Cast one of the operands of this subtraction operation to a "long".
>
> Here:
>
> Spliterator makeSplitsSpliterator(long index,
> long fence, SplittableGenerator source) {
> ...
>
On Tue, 13 Apr 2021 22:18:58 GMT, Joe Darcy wrote:
> The results from Class.getDeclaredMethods can include bridge and other
> synthetic methods, which can be unexpected by users (JDK-6815786,
> JDK-8142904) and appear to be inherited methods. The javadoc for
> Class.getDeclaredMethods should
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor
On Tue, 13 Apr 2021 15:03:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8262108?
>>
>> As noted in a comment in that issue, the bug relates to the return value of
>> `Calendar.getDisplayNames` for the
On Tue, 13 Apr 2021 18:01:49 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the following patch which adds additional permissions needed
> for when JTREG upgrades to a newer version of TestNG.
>
> Best,
> Lance
This pull request has now been integrated.
Changeset: ffb37718
Author:
On Fri, 9 Apr 2021 09:41:19 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Cast one of the operands of this subtraction operation to a "long".
>
> Here:
>
> Spliterator makeSplitsSpliterator(long index,
> long fence, SplittableGenerator source) {
> ...
>
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor
On Wed, 14 Apr 2021 11:38:15 GMT, Jorn Vernee wrote:
>> This patch implements 2 leftover TODOs for implementing var handle invoker
>> MH caching (lambda forms for those were already shared/cached).
>>
>> This piggybacks on the existing mechanism for method handle invoker caching.
>>
>>
On Fri, 9 Apr 2021 09:41:19 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Cast one of the operands of this subtraction operation to a "long".
>
> Here:
>
> Spliterator makeSplitsSpliterator(long index,
> long fence, SplittableGenerator source) {
> ...
>
On Wed, 14 Apr 2021 11:31:55 GMT, Claes Redestad wrote:
>> No, since VarHandles are not publicly extensible, the exception should not
>> occur unless something has gone very wrong (the correspondence between
>> access mode and implementing method is broken).
>
> Unfortunately the change to
On Tue, 13 Apr 2021 19:59:30 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor
On Wed, 14 Apr 2021 12:03:12 GMT, Jaroslav Bachorik
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerMemoryUsageEvent.java line
>> 46:
>>
>>> 44: public final class ContainerMemoryUsageEvent extends AbstractJDKEvent {
>>> 45: @Label("Memory Pressure")
>>> 46:
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor
The most recent intermittent failure showed that the error occurred during VM
initialization.
Only the tty output was diverted, but not log output.
Add diversion of log output as well tty output.
Add `-Xlog:all=warning:stderr` and `-Xlog:all=warning:stdout` to correspond to
Hi,
Could I get the following trivial doc changes reviewed please, caused by:
- broken tags in MethodHandles referring to package.html instead of
package-summary.html
- references to a package level #unixdomain anchor that no longer exists.
- a tag missing a "../" in SocketChannel
Thanks,
On Tue, 13 Apr 2021 12:47:50 GMT, Сергей Цыпанов
wrote:
> In mentioned method this code snippet
>
> int len = baseName.length() + 1 + name.length();
> StringBuilder sb = new StringBuilder(len);
> name = sb.append(baseName.replace('.', '/'))
> .append('/')
> .append(name)
>
On Tue, 13 Apr 2021 12:47:50 GMT, Сергей Цыпанов
wrote:
> In mentioned method this code snippet
>
> int len = baseName.length() + 1 + name.length();
> StringBuilder sb = new StringBuilder(len);
> name = sb.append(baseName.replace('.', '/'))
> .append('/')
> .append(name)
>
On Tue, 13 Apr 2021 12:47:50 GMT, Сергей Цыпанов
wrote:
> In mentioned method this code snippet
>
> int len = baseName.length() + 1 + name.length();
> StringBuilder sb = new StringBuilder(len);
> name = sb.append(baseName.replace('.', '/'))
> .append('/')
> .append(name)
>
On Tue, 13 Apr 2021 22:50:12 GMT, Andy Herrick wrote:
>> two changes:
>> One to jpackage, when recursively removing directory, when IOException
>> occurs, record it and continue (deleting as much as possible) before
>> throwing the exception.
>> The other to tests, when running jpackage via
> Move makeXXXSpilterator from public (@hidden) to protected. No API ch
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Make makeXXXSpliterator final
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3469/files
On Wed, 14 Apr 2021 10:25:09 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>>
On Wed, 14 Apr 2021 11:17:14 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>>
On Wed, 14 Apr 2021 11:38:15 GMT, Jorn Vernee wrote:
>> This patch implements 2 leftover TODOs for implementing var handle invoker
>> MH caching (lambda forms for those were already shared/cached).
>>
>> This piggybacks on the existing mechanism for method handle invoker caching.
>>
>>
On Wed, 14 Apr 2021 11:41:09 GMT, Alan Bateman wrote:
>> In mentioned method this code snippet
>>
>> int len = baseName.length() + 1 + name.length();
>> StringBuilder sb = new StringBuilder(len);
>> name = sb.append(baseName.replace('.', '/'))
>> .append('/')
>> .append(name)
>>
On Tue, 13 Apr 2021 14:36:39 GMT, Alan Bateman wrote:
>> In mentioned method this code snippet
>>
>> int len = baseName.length() + 1 + name.length();
>> StringBuilder sb = new StringBuilder(len);
>> name = sb.append(baseName.replace('.', '/'))
>> .append('/')
>> .append(name)
>>
On Tue, 13 Apr 2021 12:47:50 GMT, Сергей Цыпанов
wrote:
> In mentioned method this code snippet
>
> int len = baseName.length() + 1 + name.length();
> StringBuilder sb = new StringBuilder(len);
> name = sb.append(baseName.replace('.', '/'))
> .append('/')
> .append(name)
>
On Tue, 13 Apr 2021 15:24:13 GMT, Paul Sandoz wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments:
>> - Use boolean instead of index for var handle cache
>
>
> This patch implements 2 leftover TODOs for implementing var handle invoker MH
> caching (lambda forms for those were already shared/cached).
>
> This piggybacks on the existing mechanism for method handle invoker caching.
>
> Testing: Local testing `java/lang/invoke` tests. Tier 1-3
>
>
On Tue, 13 Apr 2021 12:47:50 GMT, Сергей Цыпанов
wrote:
> In mentioned method this code snippet
>
> int len = baseName.length() + 1 + name.length();
> StringBuilder sb = new StringBuilder(len);
> name = sb.append(baseName.replace('.', '/'))
> .append('/')
> .append(name)
>
> This patch reduces work done initializing VarForms - mostly observed when
> loading each VarHandle implementation class.
>
> - Lazily resolve MemberNames.
> - Streamline MethodType creation. This reduces the number of MethodTypes
> created.
>
> Net effect is a reduction in bytecode executed
On Wed, 14 Apr 2021 00:46:36 GMT, Paul Sandoz wrote:
>> Thanks for reviewing!
>>
>> Is there's a way to provoke this exception through the public API? If not
>> then the suggested behavior change seems reasonable.
>
> No, since VarHandles are not publicly extensible, the exception should not
On Wed, 14 Apr 2021 08:31:55 GMT, Jaroslav Bachorik
wrote:
>> With this change it becomes possible to surface various cgroup level metrics
>> (available via `jdk.internal.platform.Metrics`) as JFR events.
>>
>> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
>>
> Hi all,
>
> Please review the following patch which adds additional permissions needed
> for when JTREG upgrades to a newer version of TestNG.
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Add back
On Apr 14, 2021, at 2:13 AM, Alan Bateman
mailto:al...@openjdk.java.net>> wrote:
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen
mailto:lan...@openjdk.org>> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for
when JTREG upgrades to a newer
> This patch reduces work done initializing VarForms - mostly observed when
> loading each VarHandle implementation class.
>
> - Lazily resolve MemberNames.
> - Streamline MethodType creation. This reduces the number of MethodTypes
> created.
>
> Net effect is a reduction in bytecode executed
- Mail original -
> De: "Kengo TODA"
> À: "core-libs-dev"
> Envoyé: Mercredi 14 Avril 2021 11:03:14
> Objet: Re: ObjectMethods seems generating wrong methods for array-type field
Hello,
> I found that the JLS 16 does not cover the array type record component:
>
I found that the JLS 16 does not cover the array type record component:
https://docs.oracle.com/javase/specs/jls/se16/html/jls-8.html#jls-8.10.3
So it could be not a core-lib issue but a JLS issue.
Do I need to forward this thread to another mailing list?
If so, please let me know which is the
Hi Kengo,
I don't think this is a bug, as records are designed to "act as
transparent carriers for immutable data". A record having an array-typed
component is far from being immutable because everyone can change the
array contents. So you probably shouldn't opt for records for such use
On Wed, 14 Apr 2021 08:28:37 GMT, Jaroslav Bachorik
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
>> 163:
>>
>>> 161: private static void initializeContainerEvents() {
>>> 162: containerMetrics = Container.metrics();
>>> 163: if
> With this change it becomes possible to surface various cgroup level metrics
> (available via `jdk.internal.platform.Metrics`) as JFR events.
>
> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is
> turned into JFR events to start with.
> * CPU related metrics
> *
On Mon, 12 Apr 2021 18:53:07 GMT, Erik Gahlin wrote:
>> Jaroslav Bachorik has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove trailing spaces
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 163:
>
>>
On Wed, 14 Apr 2021 02:56:11 GMT, Joe Darcy wrote:
>> The results from Class.getDeclaredMethods can include bridge and other
>> synthetic methods, which can be unexpected by users (JDK-6815786,
>> JDK-8142904) and appear to be inherited methods. The javadoc for
>> Class.getDeclaredMethods
JDK-8240679 introduced a change where the information exposed via the
GarbageCollectorMXBean went from being related to the GC pauses to instead be
related to the GC cycles. This helped provide more accurate heap usage
information. However, some users have noticed that that you no longer get
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the following patch which adds additional permissions needed
>> for when JTREG upgrades to a newer version of TestNG.
>>
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with
On Fri, 9 Apr 2021 09:41:19 GMT, Aleksey Shipilev wrote:
> SonarCloud reports:
> Cast one of the operands of this subtraction operation to a "long".
>
> Here:
>
> Spliterator makeSplitsSpliterator(long index,
> long fence, SplittableGenerator source) {
> ...
>
82 matches
Mail list logo
