On Mon, 2 Aug 2021 23:30:55 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 17 -> JDK 18
This pull request has now been integrated.
Changeset: c8add223
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/c8add223a10030e40ccef42e081fd0d8f00e0593
Stats: 534
> Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to
> `java.lang.Math` and `java.lang.StrictMath`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8271225: Some verbiage updates
-
Changes:
-
On Mon, 2 Aug 2021 23:53:59 GMT, Jesper Wilhelmsson
wrote:
>> Forwardport JDK 17 -> JDK 18
>
> Jesper Wilhelmsson has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert "8271150: Remove EA from JDK 17 version string starting with Initial
> Forwardport JDK 17 -> JDK 18
Jesper Wilhelmsson has updated the pull request incrementally with one
additional commit since the last revision:
Revert "8271150: Remove EA from JDK 17 version string starting with Initial
RC promotion on Aug 5, 2021(B34)"
This reverts commit
Forwardport JDK 17 -> JDK 18
-
Commit messages:
- Merge
- 8067223: [TESTBUG] Rename Whitebox API package
- 8271150: Remove EA from JDK 17 version string starting with Initial RC
promotion on Aug 5, 2021(B34)
The webrevs contain the adjustments done while merging with regards to
On Mon, 2 Aug 2021 13:45:17 GMT, Andy Herrick wrote:
> JDK-8271344: Windows product version issue
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4958
On Mon, 2 Aug 2021 18:03:42 GMT, Claes Redestad wrote:
> Trivially avoid some redundant calls when creating threads.
> (ThreadGroup.checkAccess is final, and all it does is call
> security.checkAccess(g) if there's a SM installed)
This pull request has now been integrated.
Changeset:
On Mon, 2 Aug 2021 19:40:12 GMT, Roger Riggs wrote:
>> Trivially avoid some redundant calls when creating threads.
>> (ThreadGroup.checkAccess is final, and all it does is call
>> security.checkAccess(g) if there's a SM installed)
>
> LGTM
Thanks again @RogerRiggs!
-
PR:
On Mon, 2 Aug 2021 19:59:57 GMT, Raffaello Giulietti
wrote:
> Hello,
>
> please review this tiny change in the implementation of
> j.l.Math.floorMod(int, int).
>
> While the results are unaffected, all of
> floorDiv(int, int)
> floorDiv(long, long)
> floorMod(long, long)
> use x
Hello,
please review the changes in documentation of floorDiv() and floorMod() in all
their variants. Some are clarifications, some are corrections.
Here's an example of a confusing formulation in the current doc
> "the / operator returns the integer closest to zero"
Literally, the integer
On Mon, 2 Aug 2021 18:27:00 GMT, Claes Redestad wrote:
> Trivial startup hack/cleanup to use the `classLoader` field directly rather
> than the `getClassLoader0` accessor.
>
> Before aa12c8fbf5b020d168cf29412643bf15514b0439 there was no `classLoader`
> field and `getClassLoader0` was a
On 3/08/2021 2:25 am, Igor Ignatyev wrote:
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following substitutions:
> -
On Mon, 2 Aug 2021 19:44:22 GMT, Mandy Chung wrote:
> Do you see any startup improvement by this change?
Very tiny, ~90 calls on bootstrap.
> This looks okay.
Thanks!
> I assume you concern about the early startup when this method is running in
> interpreted mode. Do you see any startup
Hello,
please review this tiny change in the implementation of j.l.Math.floorMod(int,
int).
While the results are unaffected, all of
floorDiv(int, int)
floorDiv(long, long)
floorMod(long, long)
use x ^ y in the tests to correct the result if needed.
Not only is the proposed change
On Mon, 2 Aug 2021 18:27:00 GMT, Claes Redestad wrote:
> Trivial startup hack/cleanup to use the `classLoader` field directly rather
> than the `getClassLoader0` accessor.
>
> Before aa12c8fbf5b020d168cf29412643bf15514b0439 there was no `classLoader`
> field and `getClassLoader0` was a
On Mon, 2 Aug 2021 18:03:42 GMT, Claes Redestad wrote:
> Trivially avoid some redundant calls when creating threads.
> (ThreadGroup.checkAccess is final, and all it does is call
> security.checkAccess(g) if there's a SM installed)
LGTM
-
Marked as reviewed by rriggs (Reviewer).
On Mon, 7 Jun 2021 00:09:33 GMT, Joe Darcy wrote:
> Make explicit illegal argument cases of Class.arrayType.
>
> Please also review the corresponding CSR:
> https://bugs.openjdk.java.net/browse/JDK-8268300
This pull request has been closed without being integrated.
-
PR:
Trivial startup hack/cleanup to use the `classLoader` field directly rather
than the `getClassLoader0` accessor.
Before aa12c8fbf5b020d168cf29412643bf15514b0439 there was no `classLoader`
field and `getClassLoader0` was a native method that retrieved the
`ClassLoader` by calling into the
Trivially avoid some redundant calls when creating threads.
(ThreadGroup.checkAccess is final, and all it does is call
security.checkAccess(g) if there's a SM installed)
-
Commit messages:
- Merge branch 'master' into thread_access
- Avoid calling ThreadGroup.checkAccess when no
On Mon, 2 Aug 2021 15:56:39 GMT, Vladimir Kozlov wrote:
> I agree with these revised changes for JDK 17.
Thanks for your review, Vladimir.
I'll rerun my testing before integrating (just for good luck).
-- Igor
-
PR: https://git.openjdk.java.net/jdk17/pull/290
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>>
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following substitutions:
> - `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
> -
> 4890732: GZIPOutputStream doesn't support optional GZIP fields
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
delete trailing spaces
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3072/files
- new:
> 4890732: GZIPOutputStream doesn't support optional GZIP fields
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 15 commits:
- refine code
- Merge branch 'master' into gzip-field
- change since version to 18
- Merge
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
>>
Dear Lance,
OK, Thanks for your reviewing and effort!
BRs,
Lin
From: Lance Andersen
Date: Monday, August 2, 2021 at 11:43 PM
To: Lin Zang
Cc: "core-libs-dev@openjdk.java.net"
Subject: [Internet]Re: RFR: 4890732: GZIPOutputStream doesn't support optional
GZIP fields [v9]
On Aug 2, 2021, at
On Mon, 2 Aug 2021 14:38:23 GMT, Coleen Phillimore wrote:
> This looks good. Thanks for fixing the mysterious (to me) cast.
Thank you, Coleen!
-
PR: https://git.openjdk.java.net/jdk/pull/4874
On Sun, 25 Jul 2021 21:56:10 GMT, Lance Andersen wrote:
> Hi,
>
> As discussed in the
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
> thread, this is the revised patch to address the use of '.' and '..' within
> Zip FS
>
> Zip FS needs to use "." and ".." as
On Mon, 26 Jul 2021 20:47:59 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 13 commits:
>>
>> - change since version to 18
>> - Merge branch 'master' into gzip-field
>> - Merge branch
On Aug 2, 2021, at 10:39 AM, Lin Zang
mailto:lz...@openjdk.java.net>> wrote:
On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman
mailto:al...@openjdk.org>> wrote:
Thank you for reviving the discussion.
I have not gone through the latest update in detail but there are some changes
that are
On Mon, 2 Aug 2021 13:27:15 GMT, Claes Redestad wrote:
> Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from
> AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission
> when no SecurityManager is installed
This pull request has now been integrated.
On Mon, 2 Aug 2021 14:30:08 GMT, Roger Riggs wrote:
>> Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from
>> AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission
>> when no SecurityManager is installed
>
> LGTM
Thanks for the review @RogerRiggs!
On Mon, 2 Aug 2021 13:45:17 GMT, Andy Herrick wrote:
> JDK-8271344: Windows product version issue
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4958
On Mon, 26 Jul 2021 20:55:00 GMT, Lance Andersen wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 13 commits:
>>
>> - change since version to 18
>> - Merge branch 'master' into gzip-field
>> - Merge branch
On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman wrote:
>> Thank you for reviving the discussion.
>>
>> I have not gone through the latest update in detail but there are some
>> changes that are needed. Before moving forward with the CSR, I would like to
>> give time for additional feedback on
On Sun, 1 Aug 2021 08:17:08 GMT, Thomas Stuefe wrote:
>> Short: this patch makes NMT available in custom-launcher scenarios and
>> during gtests. It simplifies NMT initialization. It adds a lot of
>> NMT-specific testing, cleans them up and makes them sideeffect-free.
>>
>> -
>>
>>
On Mon, 2 Aug 2021 13:27:15 GMT, Claes Redestad wrote:
> Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from
> AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission
> when no SecurityManager is installed
LGTM
-
Marked as reviewed by rriggs
On Fri, 30 Jul 2021 09:32:22 GMT, Thomas Stuefe wrote:
>> [Not a review, just a drive-by comment.] This is a normal and idiomatic
>> overload on the const-ness of `this`.
>
> To expand on Kim's answer. This is a way to solve const/nonconst problems
> like
On Fri, 30 Jul 2021 09:44:57 GMT, Thomas Stuefe wrote:
> Is that a real-life problem? Are there cases where the launcher would want to
> live on if the JVM failed to load?
There are a lot of other reasons why the launcher couldn't live on if the JVM
fails to load. This was only one of them.
Hi Andy,
> sorry - code looks for certificate key starting with: "Developer ID
> Application: " + in order to not
> have to put full user name in. I missed that that with null user name that
> causes it to look for anything starting with "Developer ID Application: "
> (same thing with
JDK-8271344: Windows product version issue
-
Commit messages:
- JDK-8271344: Windows product version issue
Changes: https://git.openjdk.java.net/jdk/pull/4958/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4958=00
Issue:
Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from
AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission
when no SecurityManager is installed
-
Commit messages:
- Use SecurityConstants.ACCESS_PERMISSION in MethodHandles
Changes:
On Wed, 2 Jun 2021 12:10:46 GMT, Сергей Цыпанов
wrote:
> After I've renamed remove branch GitHub for some reason has closed original
> https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
This pull request has now been integrated.
Changeset: 249d6418
Author:Sergey
On Wed, 2 Jun 2021 14:10:38 GMT, Сергей Цыпанов
wrote:
> There is a few JDK classes duplicating the contents of Long.hashCode() for
> hash code calculation. They should explicitly delegate to Long.hashCode().
This pull request has now been integrated.
Changeset: 6a3f8343
Author:Sergey
On Fri, 9 Jul 2021 11:50:38 GMT, Сергей Цыпанов
wrote:
> `AbstractStringBuilder.charAt(int)` does bounds check before calling
> `charAt()` (for non-latin Strings):
>
> @Override
> public char charAt(int index) {
> checkIndex(index, count);
> if (isLatin1()) {
> return
On Thu, 22 Apr 2021 14:07:20 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've found
> out, that in a few of JDK core classes, e.g. in `j.l.Class` expressions like
> `baseName.replace('.', '/') + '/' + name` are not compiled into
>
On Wed, 30 Jun 2021 08:40:21 GMT, Сергей Цыпанов
wrote:
> As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double` and
> `Float` in their implementations of `Object.toString()` delegate to own
> utility `toString(primitive)` methods.
>
> Unlike those, `Boolean`, `Byte`,
> After I've renamed remove branch GitHub for some reason has closed original
> https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
Сергей Цыпанов has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 11 commits:
-
On Mon, 2 Aug 2021 12:29:00 GMT, Сергей Цыпанов
wrote:
>> As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double`
>> and `Float` in their implementations of `Object.toString()` delegate to own
>> utility `toString(primitive)` methods.
>>
>> Unlike those, `Boolean`, `Byte`,
On Mon, 2 Aug 2021 11:09:30 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8269665: Update copy-right year
>> - 8269665: Reuse String.valueOf(boolean)
>
>
> As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double` and
> `Float` in their implementations of `Object.toString()` delegate to own
> utility `toString(primitive)` methods.
>
> Unlike those, `Boolean`, `Byte`, `Character` and `Short` just duplicate the
> contents of
On Tue, 27 Jul 2021 10:25:22 GMT, Matthias Baesken wrote:
> What do you think about accepting, when setting -1/unlimited, a high limit
> number like 20.000+ as well (and and a comment that on some setups unlimited
> means just "high number" but not unlimited?
This seems most reasonable. I'd
On Mon, 2 Aug 2021 11:34:00 GMT, Сергей Цыпанов
wrote:
>> `AbstractStringBuilder.charAt(int)` does bounds check before calling
>> `charAt()` (for non-latin Strings):
>>
>> @Override
>> public char charAt(int index) {
>> checkIndex(index, count);
>> if (isLatin1()) {
>> return
On Mon, 26 Jul 2021 08:27:20 GMT, Сергей Цыпанов
wrote:
>> After I've renamed remove branch GitHub for some reason has closed original
>> https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it.
>
> Сергей Цыпанов has updated the pull request with a new target base due to a
>
On Mon, 2 Aug 2021 10:52:26 GMT, Claes Redestad wrote:
>> Сергей Цыпанов has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into 8270160
>> - Merge branch 'master' into 8270160
>>
> `AbstractStringBuilder.charAt(int)` does bounds check before calling
> `charAt()` (for non-latin Strings):
>
> @Override
> public char charAt(int index) {
> checkIndex(index, count);
> if (isLatin1()) {
> return (char)(value[index] & 0xff);
> }
> return
On Mon, 26 Jul 2021 08:27:14 GMT, Сергей Цыпанов
wrote:
>> There is a few JDK classes duplicating the contents of Long.hashCode() for
>> hash code calculation. They should explicitly delegate to Long.hashCode().
>
> Сергей Цыпанов has updated the pull request with a new target base due to a
>
On Sun, 4 Jul 2021 21:35:31 GMT, Сергей Цыпанов
wrote:
>> As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double`
>> and `Float` in their implementations of `Object.toString()` delegate to own
>> utility `toString(primitive)` methods.
>>
>> Unlike those, `Boolean`, `Byte`,
On Mon, 26 Jul 2021 08:22:28 GMT, Сергей Цыпанов
wrote:
>> `AbstractStringBuilder.charAt(int)` does bounds check before calling
>> `charAt()` (for non-latin Strings):
>>
>> @Override
>> public char charAt(int index) {
>> checkIndex(index, count);
>> if (isLatin1()) {
>> return
On Thu, 15 Jul 2021 11:56:31 GMT, Сергей Цыпанов
wrote:
>> `AbstractStringBuilder.charAt(int)` does bounds check before calling
>> `charAt()` (for non-latin Strings):
>>
>> @Override
>> public char charAt(int index) {
>> checkIndex(index, count);
>> if (isLatin1()) {
>> return
On Mon, 26 Jul 2021 08:31:23 GMT, Сергей Цыпанов
wrote:
>> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've
>> found out, that in a few of JDK core classes, e.g. in `j.l.Class`
>> expressions like `baseName.replace('.', '/') + '/' + name` are not compiled
>> into
On Sun, 4 Jul 2021 21:35:31 GMT, Сергей Цыпанов
wrote:
>> As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double`
>> and `Float` in their implementations of `Object.toString()` delegate to own
>> utility `toString(primitive)` methods.
>>
>> Unlike those, `Boolean`, `Byte`,
63 matches
Mail list logo
