On Wed, 25 Aug 2021 22:05:24 GMT, Vladimir Ivanov wrote:
> Get rid of WeakReference-based logic in
> DirectMethodHandle::checkInitialized() and reimplement it with
> `Unsafe::ensureClassInitialized()`/`shouldBeInitialized()`.
>
> The key observation is that `Unsafe::ensureClassInitialized()`
On Mon, 16 Aug 2021 21:00:00 GMT, Brian Burkhalter wrote:
> Please consider this change which would modify a conditional `a + b > c`
> where the left side variables are `int`s and the right side is
> `(long)Integer.MAX_VALUE + 1`. The change is to cast the left side variables
> to `long`s.
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
This pull request has now been integrated.
Changeset: d732c309
Author:Andrey Turbanov
Committer: Sergey Bylokhov
URL:
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
> This pull request adds a micro benchmark for Vector API.
> The Black Scholes algorithm is implemented with and without Vector API.
> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
> vectors.
Sandhya Viswanathan has updated the pull request incrementally with one
On Wed, 25 Aug 2021 09:31:51 GMT, Vladimir Ivanov wrote:
> `MethodHandle.asTypeCache` keeps a strong reference to adapted `MethodHandle`
> and it can introduce a class loader leak through its `MethodType`.
>
> Proposed fix introduces a 2-level cache (1 element each) where 1st level can
> only
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
This pull request has now been integrated.
Changeset: fe7d7088
Author:Naoto Sato
On 26/08/2021 15:43, Alan Snyder wrote:
As I said, I think it's great that we agree an exception should be thrown when
an over-length path is used in an actual file operation.
However, would it not be better to have that in the specification, rather than
relying on the opinions of individual
On Wed, 25 Aug 2021 22:05:24 GMT, Vladimir Ivanov wrote:
> Get rid of WeakReference-based logic in
> DirectMethodHandle::checkInitialized() and reimplement it with
> `Unsafe::ensureClassInitialized()`/`shouldBeInitialized()`.
>
> The key observation is that `Unsafe::ensureClassInitialized()`
On Tue, 24 Aug 2021 20:49:52 GMT, Sandhya Viswanathan
wrote:
>> This pull request adds a micro benchmark for Vector API.
>> The Black Scholes algorithm is implemented with and without Vector API.
>> We see about ~6x gain with Vector API for this micro benchmark using 256 bit
>> vectors.
>
>
As I said, I think it's great that we agree an exception should be thrown when
an over-length path is used in an actual file operation.
However, would it not be better to have that in the specification, rather than
relying on the opinions of individual engineers expressed in a thread on a
Hello Roger,
Sorry, I just read the top part of your reply the last time and didn't
realize there were inline comments. I just noticed them. Replying inline.
On 24/08/21 8:14 pm, Roger Riggs wrote:
Hi Jaikiran,
Thanks for taking this on and getting it started.
One use case of canonical
Hello Magnus,
On 25/08/21 5:33 pm, Magnus Ihse Bursie wrote:
...
One thing I do remember is the JDK build (through the make files)
would have certain Java code it would call to do some build steps. Is
there a easy way to find all such build related Java files within the
JDK? I would like to
On 25/08/2021 15:57, Jaikiran Pai wrote:
:
Introducing an overloaded "store" which takes the timestamp or
implicitly using the SOURCE_DATE_EPOCH environment variable would mean
that the Properties.store(...) APIs will continue to always write out
a Date representation into the outputstream.
On 25/08/2021 23:12, Alan Snyder wrote:
Lacking any new data, I guess it is fair to assume that there is no
specification for the behavior of methods that use file paths that are too
long, and presumably no tests, either.
So the next question is whether there should be such a specification.
On Wed, 25 Aug 2021 07:40:56 GMT, Nick Gasson wrote:
> I've run the benchmark on several different machines and didn't see any
> performance regressions, and the speed-up for longer strings looks quite
> good. I also ran jtreg tier1-3 with no new failures so I think this is ok.
>
> If you fix
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
LGTM
-
Marked as reviewed by scolebourne (Author).
PR:
On Thu, 26 Aug 2021 02:48:38 GMT, David Holmes wrote:
> I'm unclear exactly what that statement is meant to indicate.
`DirectMethodHandle::checkInitialized()` is dual-purpose: it implements class
initialization barrier and reports whether the class is fully initialized, so
the barrier can be
On Wed, 4 Aug 2021 07:25:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8269373 bug fixes?
>>
>> These tests call java.lang.ProcessBuilder in direct, so not used jtreg
>> command option. To run non-localized tests, -Duser.language=en and
>> -Duser.country=US
On Mon, 23 Aug 2021 11:33:35 GMT, Aleksey Shipilev wrote:
> See the RFE for discussion.
>
> Current PR improves the test time like this:
>
>
> $ make run-test TEST=java/lang/invoke/LFCaching/
>
> # Before
> real 3m51.608s
> user 5m21.612s
> sys 0m5.391s
>
> # After
> real 1m13.606s
>
On Wed, 25 Aug 2021 16:31:50 GMT, Aleksey Shipilev wrote:
>> See the RFE for discussion.
>>
>> Current PR improves the test time like this:
>>
>>
>> $ make run-test TEST=java/lang/invoke/LFCaching/
>>
>> # Before
>> real 3m51.608s
>> user 5m21.612s
>> sys 0m5.391s
>>
>> # After
>> real
On Wed, 25 Aug 2021 21:45:57 GMT, Roger Riggs wrote:
>> The intermittent test in java/lang/ProcessBuilder/Basic.java has identified
>> unexpected messages from a child Java VM
>> as the cause of the test failure. Attempts to control the output of the
>> child VM have failed, the VM is
22 matches
Mail list logo
