Could you review this fix?
Problem:
Custom JRE generated by jlink cannot find non-ASCII named modules included
inside the JRE.
Cause and fix:
If module or package name was composed by ASCII then non-ASCII characters,
ImageStringsReader:stringFromByteBufferMatches() miscalculated the length of
On Thu, 2 Dec 2021 15:35:40 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
> The time to get JDK 19 underway draws nigh, please review this usual set of
> start-of-release updates, including CSRs for the javac and javax.lang.model
> updates:
>
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
>
> JDK-8277514: Add source 19
On Wed, 27 Oct 2021 09:57:43 GMT, swati sharma wrote:
> 8276048: Error in javadoc regarding Long method public static Long
> valueOf(String s)
> Fix: Changing integer to {@code Long}
This pull request has been closed without being integrated.
-
PR:
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> When doing an unsigned upcast, we perform a signed cast followed by a bitwise
> and operation to clip the extended signed bit. The sign clip mask is
> currently calculated incorrectly, the correct mask should have the number of
>
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> When doing an unsigned upcast, we perform a signed cast followed by a bitwise
> and operation to clip the extended signed bit. The sign clip mask is
> currently calculated incorrectly, the correct mask should have the number of
>
On Fri, 3 Dec 2021 00:27:13 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the JMH micro to take RNG parameters for elegant implementation
>
>
On Fri, 3 Dec 2021 02:11:24 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minor changes to the benchmark
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
minor changes to the benchmark
-
Changes:
- all:
On Thu, 2 Dec 2021 19:04:11 GMT, Roger Riggs wrote:
> fyi, with this change the JCK did not flag a failure.
Thank you Roger for running those tests.
-
PR: https://git.openjdk.java.net/jdk/pull/6488
On Fri, 3 Dec 2021 00:17:04 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update the JMH micro to take RNG
On Thu, 2 Dec 2021 23:02:57 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add seeds for the random generators to eliminate run-to-run variance
>
>
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
Update the JMH micro to take RNG parameters for elegant implementation
-
Changes:
-
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> When doing an unsigned upcast, we perform a signed cast followed by a bitwise
> and operation to clip the extended signed bit. The sign clip mask is
> currently calculated incorrectly, the correct mask should have the number of
>
On Thu, 2 Dec 2021 23:02:57 GMT, Paul Sandoz wrote:
>> Vamsi Parasa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add seeds for the random generators to eliminate run-to-run variance
>
>
On Thu, 2 Dec 2021 20:43:56 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add seeds for the random
This patch implements vector unsigned upcast intrinsics for x86. I also fixed a
bug in the current implementation where the zero extension masks are computed
incorrectly and add relevant tests.
Thank you very much.
-
Commit messages:
- revert intrinsics
- Merge branch 'master'
On Thu, 2 Dec 2021 22:04:36 GMT, Mai Đặng Quân Anh
wrote:
>> I am inclined to separated out. Fix the bug, add the tests, and integrate
>> for 18. Then enhance with the intrinsics for 19.
>>
>> If you agree to that I will create two bugs.
>
> @PaulSandoz Yes, I think that should be the case,
On Thu, 2 Dec 2021 20:43:56 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add seeds for the random
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> This patch implements vector unsigned upcast intrinsics for x86. I also fixed
> a bug in the current implementation where the zero extension masks are
> computed incorrectly and add relevant tests.
>
> Thank you very much.
I am
On Wed, 1 Dec 2021 12:03:15 GMT, Mai Đặng Quân Anh
wrote:
> This patch implements vector unsigned upcast intrinsics for x86. I also fixed
> a bug in the current implementation where the zero extension masks are
> computed incorrectly and add relevant tests.
>
> Thank you very much.
On Thu, 2 Dec 2021 19:55:40 GMT, Paul Sandoz wrote:
>> This patch implements vector unsigned upcast intrinsics for x86. I also
>> fixed a bug in the current implementation where the zero extension masks are
>> computed incorrectly and add relevant tests.
>>
>> Thank you very much.
>
> I am
On Thu, 2 Dec 2021 21:07:30 GMT, Andrew Leonard wrote:
> PR https://github.com/openjdk/jdk/pull/6647 resolved the GENDATA_CACERTS_SRC
> fir --with-cacerts-src after the recipe, which meant the dependencies were
> wrong.
> This PR moves it before the recipe.
>
> Signed-off-by: Andrew Leonard
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source
This pull request has now been integrated.
Changeset: b8ac0d20
Author:Tim Prinzing
Committer: Lance Andersen
URL:
> JDK-8276681: Additional malformed Javadoc inline tags in JDK source
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional
On Wed, 1 Dec 2021 14:45:23 GMT, Roman Kennke wrote:
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
>
On Sat, 20 Nov 2021 04:09:51 GMT, Tim Prinzing wrote:
> JDK-8276681: Malformed Javadoc inline tags in JDK source
> jdk/internal/net/http/ResponseSubscribers.java
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6486
On Thu, 2 Dec 2021 19:49:12 GMT, Roger Riggs wrote:
> Looks good.
Thank you!
I believe it makes sense to also use the ClassCache here, just as I did in
#6375. I'll change this PR accordingly tomorrow.
-
PR: https://git.openjdk.java.net/jdk/pull/6637
On Thu, 2 Dec 2021 20:43:56 GMT, Vamsi Parasa wrote:
>> This change optimizes random number generators using
>> Math.unsignedMultiplyHigh()
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add seeds for the random
On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing wrote:
> JDK-8276674 : Malformed Javadoc inline tags in JDK source
This pull request has now been integrated.
Changeset: 652b5f85
Author:Tim Prinzing
Committer: Brent Christian
URL:
On Thu, 2 Dec 2021 02:36:47 GMT, Tim Prinzing wrote:
>> JDK-8276674 : Malformed Javadoc inline tags in JDK source
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into
> This change optimizes random number generators using
> Math.unsignedMultiplyHigh()
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
add seeds for the random generators to eliminate run-to-run variance
-
Changes:
-
On Mon, 8 Nov 2021 14:25:10 GMT, Сергей Цыпанов wrote:
> This is a follow-up for https://github.com/openjdk/jdk/pull/4507, looks like
> there are some cases that were not covered.
>
> Also this is related to https://github.com/openjdk/jdk/pull/3615
This pull request has now been integrated.
On Wed, 10 Nov 2021 17:44:04 GMT, Eamonn McManus wrote:
> Use string concatenation instead of `String.format`.
Looks ok on the face of it. I would be useful to see the performance of the
improvement.
-
PR: https://git.openjdk.java.net/jdk/pull/6337
On Thu, 2 Dec 2021 19:12:37 GMT, Andrew Leonard wrote:
>> Oh, I didn't expand the diff far enough to actually see the context
>> correctly when I reviewed this as I would never have imagined the
>> conditional to be placed after the rule. While this will work as so far as
>> using the correct
On Wed, 1 Dec 2021 14:45:23 GMT, Roman Kennke wrote:
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
>
On Wed, 10 Nov 2021 11:59:16 GMT, Hendrik Schreiber
wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference
On Wed, 10 Nov 2021 11:59:16 GMT, Hendrik Schreiber
wrote:
>> Trivial improvement.
>>
>> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`.
>> Repeat (again) in the code example that the `State` `Runnable `should be
>> implemented as static class and not reference
On Fri, 15 Oct 2021 18:51:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
This pull request has now been integrated.
Changeset: 30087cc1
Author:Andrey Turbanov
Committer: Roger Riggs
URL:
On Thu, 2 Dec 2021 18:46:09 GMT, Erik Joelsson wrote:
>> this was my understanding:
>> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>>
>> This occurs after make has finished reading all the makefiles and the target
>> is determined to be out of date; so, the
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.java.net/browse/JDK-8003417?
>
> The issue notes that this is applicable for `WeakHashMap` which have `null`
> keys. However,
On Thu, 2 Dec 2021 16:14:18 GMT, Roger Riggs wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement ClassCache: reclaim entries under memory pressure
>
> ObjectStreamClass may have an unnecesary import of
On Thu, 2 Dec 2021 18:03:50 GMT, Andrew Leonard wrote:
>> my assumption was the recipe gets resolved later
>
> this was my understanding:
> https://www.gnu.org/software/make/manual/html_node/Variables-in-Recipes.html
>
> This occurs after make has finished reading all the makefiles and the
On Thu, 2 Dec 2021 02:23:59 GMT, Joe Darcy wrote:
> Change the test in question to generate its data programmatically to avoid
> updates with each JDK release. (Assuming this gets pushed before the start of
> JDK 19, I'll revert the customary changes to the test in set of start-of-19
>
Change the test in question to generate its data programmatically to avoid
updates with each JDK release. (Assuming this gets pushed before the start of
JDK 19, I'll revert the customary changes to the test in set of start-of-19
updates.)
Running the test, it does probe the same set of values:
> The time to get JDK 19 underway draws nigh, please review this usual set of
> start-of-release updates, including CSRs for the javac and javax.lang.model
> updates:
>
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
>
> JDK-8277514: Add source 19
On Thu, 2 Dec 2021 02:23:59 GMT, Joe Darcy wrote:
> Change the test in question to generate its data programmatically to avoid
> updates with each JDK release. (Assuming this gets pushed before the start of
> JDK 19, I'll revert the customary changes to the test in set of start-of-19
>
On Thu, 2 Dec 2021 17:48:04 GMT, Andrew Leonard wrote:
>> you make a valid point, but i've tested this numerous times, but let me
>> check again
>
> my assumption was the recipe gets resolved later
this was my understanding:
On Thu, 2 Dec 2021 17:46:35 GMT, Andrew Leonard wrote:
>> I would have expected to see something like:
>>
>> ifneq ($(CACERTS_SRC), )
>> GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>> else
>> GENDATA_CACERTS_SRC := $(TOPDIR)/make/data/cacerts/
>> endif
>>
>> at line 63.
>
> you make a valid
On Thu, 2 Dec 2021 17:35:36 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/Gendata.gmk line 76:
>>
>>> 74: ifneq ($(CACERTS_SRC), )
>>> 75: GENDATA_CACERTS_SRC := $(CACERTS_SRC)
>>> 76: endif
>>
>> Does this even work?! You are reassigning the variable after it has been
>> used.
On Thu, 2 Dec 2021 17:33:49 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
This pull request has now been integrated.
Changeset: ad1ff27b
Author:
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
Looks good, Lance. I'd add `noreg-self` label to the JIRA issue.
On Mon, 22 Nov 2021 19:57:25 GMT, Roger Riggs wrote:
> The effects of an invalid `jdk.serialFilter` property are not completely
> documented. If the value of the system property jdk.serialFilter is invalid,
> deserialization should not be possible and it should be clear in the
>
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get reclaimed, unless the GC determines that memory
> pressure is
On Wed, 1 Dec 2021 18:33:44 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch to address a failure at DST->STD offset transition.
> The fix mirrors what was done for JDK-8190748
>
>
> Best,
> Lance
Marked as reviewed by msheppar (Reviewer).
-
PR:
On Thu, 2 Dec 2021 14:30:07 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Mon, 22 Nov 2021 19:57:25 GMT, Roger Riggs wrote:
> The effects of an invalid `jdk.serialFilter` property are not completely
> documented. If the value of the system property jdk.serialFilter is invalid,
> deserialization should not be possible and it should be clear in the
>
On Wed, 1 Dec 2021 18:30:06 GMT, Andrew Leonard wrote:
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
>
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request with
On Thu, 2 Dec 2021 14:29:00 GMT, Sean Mullan wrote:
> I don’t have any major concerns with this change, as long as the default
> cacerts are still the ones that are in the JDK. As an aside, using Mozilla's
> root certificates might be fine for TLS certificates, but if you need to
> support
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Wed, 1 Dec 2021 21:09:14 GMT, Roger Riggs wrote:
> Without the use of SoftReference, memory pressure won't release any of the
> cached info. That seems to swing the other way from overly aggressively
> freeing memory with the WeakReference (and needing to recompute) as the
> change
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get reclaimed, unless the GC determines that memory
> pressure is
On Wed, 1 Dec 2021 21:35:01 GMT, Andy Herrick wrote:
> - We need to unsign all executables and libraries in the app-image before
> signing. (not just those in the runtime).
> - Clean up excessive output by executing the individual file sign and
> unsigning commands in quiet mode.
> - Add
On Thu, 2 Dec 2021 12:13:03 GMT, Andrew Leonard wrote:
>> Addition of a configure option --with-cacerts-src='user cacerts folder' to
>> allow developers to specify their own cacerts PEM folder for generation of
>> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>>
>>
On Thu, 11 Nov 2021 13:59:51 GMT, Jim Laskey wrote:
> The modified ziggurat algorithm is not correctly implemented in
> `java.base/jdk/internal/util/random/RandomSupport.java`.
>
> Create a histogram of a million samples using 2000 uniform bins with the
> following range:
> Exponential
On Thu, 2 Dec 2021 12:15:51 GMT, David Holmes wrote:
> I've solicited feedback from core-libs folk as this affects them the most. At
> present we, Oracle, run the jdk_svc tests as part of hotspot testing, but
> this change will suddenly cause jdk testing to include them. That is probably
>
On Thu, 2 Dec 2021 12:26:33 GMT, Maurizio Cimadamore
wrote:
> This patch adds missing `@throws` tags to the javadoc of `MemorySegment::set`
> and `MemorySegment::setAtIndex`.
> These methods can fail with `UnsupportedOperationException` if the segment is
> read-only.
LGTM
-
This patch adds missing `@throws` tags to the javadoc of `MemorySegment::set`
and `MemorySegment::setAtIndex`.
These methods can fail with `UnsupportedOperationException` if the segment is
read-only.
-
Commit messages:
- Add missing @throws tags
Changes:
On 2/12/2021 6:25 pm, Aleksey Shipilev wrote:
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote:
All right then. Thanks for followups!
Hi Aleksey,
I've solicited feedback from core-libs folk as this affects them the
most. At present we, Oracle, run the jdk_svc tests as part of
> Addition of a configure option --with-cacerts-src='user cacerts folder' to
> allow developers to specify their own cacerts PEM folder for generation of
> the cacerts store using the deterministic openjdk GenerateCacerts tool.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the
On Wed, 1 Dec 2021 18:47:41 GMT, Erik Joelsson wrote:
>> Andrew Leonard has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Thu, 2 Dec 2021 00:09:15 GMT, John Neffenger wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/jdk.jlink/share/classes/jdk/tools/jmod/JmodOutputStream.java
>>
>> Co-authored-by: Magnus Ihse
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request with
> Following integration of the second incubator of the foreign function and
> memory API [1], we detected few divergences between the contents of the jdk
> repo and the panama repo:
>
> * the name of some of the `FunctionDescriptor` wither methods is different
> (e.g.
On Mon, 29 Nov 2021 11:22:45 GMT, Maurizio Cimadamore
wrote:
> Following integration of the second incubator of the foreign function and
> memory API [1], we detected few divergences between the contents of the jdk
> repo and the panama repo:
>
> * the name of some of the
On Thu, 2 Dec 2021 08:21:30 GMT, Aleksey Shipilev wrote:
> All right then. Thanks for followups!
>
> @egahlin, @mgronlun: this affects JFR tests a bit, subsumes `jfr_tier_3` into
> `tier3`, basically. Are you good with this?
Seems reasonable.
I'm reluctant to become (R)eviewer on this, since
On Thu, 2 Dec 2021 00:09:31 GMT, Sergey Bylokhov wrote:
> I have a question related to the custom cacerts which can be added to the
> OpenJDK bundle. How do you pass the tests like
> test/jdk/sun/security/lib/cacerts/VerifyCACerts.java using that custom jdk
> bundle? Probably we can add an
On Wed, 1 Dec 2021 13:49:42 GMT, Maurizio Cimadamore
wrote:
> There are some truncated statements in
> MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in
> the `@throws` for `IndexOutOfBoundsException`.
This pull request has now been integrated.
Changeset: 16cfbc4f
On Thu, 2 Dec 2021 01:53:47 GMT, John Neffenger wrote:
>>> I'm testing it now. So far, it's working great!
>>>
>>> I found one boundary problem. The magic instant of `1980-01-01T00:00:00Z`
>>> triggers an extended header with the wrong time:
>>>
>>> ```
>>> file last modified on (DOS
On Tue, 30 Nov 2021 18:48:15 GMT, Aleksey Shipilev wrote:
> OpenJDK tiered tests definitions have the catch-all `tier4` that runs all
> tests not defined in the lower tiers. `hotspot:tier4` has lots of them,
> mostly long-running vmTestbase tests, which take many hours even on a very
>
83 matches
Mail list logo
