> **Background:**
>
> In the Java Language, Enums can be tested for equality, so the constants in
> an Enum type must be unique. Javac compiles an enum declaration like this:
>
>
> public enum Day { SUNDAY, MONDAY ... }
>
>
> to
>
>
> public class Day extends java.lang.Enum {
>
On Tue, 7 Dec 2021 13:27:44 GMT, Alan Bateman wrote:
>> @jddarcy hi Joe, what's the next step with the CSR now?
>> https://bugs.openjdk.java.net/browse/JDK-8277755
>> thanks
>
>> @jddarcy hi Joe, what's the next step with the CSR now?
>> https://bugs.openjdk.java.net/browse/JDK-8277755
>>
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
> java.io.ObjectStreamClass.Caches#localDescs. Then we can
On Fri, 10 Dec 2021 17:20:40 GMT, Kevin Rushforth wrote:
>> @LanceAndersen let me know if mach5 looks good please, then I think we're
>> good to go..
>
> @andrew-m-leonard if this enhancement is now intended to go into JDK 19, then
> you can simply integrate it into jdk mainline when it is
On Fri, 10 Dec 2021 19:16:49 GMT, John Neffenger wrote:
>>> Thanks, CSR now Finalized
>>
>> Just a minor note: the CSR uses the adjective "extended" in three places for
>> the DOS date and time field, but that field is actually a part of the
>> original ZIP specification and not in an
On Tue, 7 Dec 2021 19:25:05 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
On Fri, 10 Dec 2021 08:16:46 GMT, Christian Stein wrote:
>> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
>> class `PathFileObject` in module `jdk.compiler` were always composed by base
>> path names. Even for versioned entries of a multi-release JAR file.
>>
>>
On Tue, 7 Dec 2021 19:06:17 GMT, John Neffenger wrote:
>> Thanks, CSR now Finalized
>
>> Thanks, CSR now Finalized
>
> Just a minor note: the CSR uses the adjective "extended" in three places for
> the DOS date and time field, but that field is actually a part of the
> original ZIP
On Fri, 10 Dec 2021 16:31:45 GMT, Roman Kennke wrote:
>> As a follow-up to #6375, this change refactors
>> java.io.ObjectInputStream.Caches#subclassAudits and
>> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead
>> of SoftReference, similar to what we did in #6375 for
On Fri, 10 Dec 2021 17:51:31 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 18 -> JDK 19
This pull request has now been integrated.
Changeset: 61736f81
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.java.net/jdk/commit/61736f81fb4a20375c83d59e2b37a00aafb11107
Stats: 1142
On Fri, 10 Dec 2021 16:31:45 GMT, Roman Kennke wrote:
>> As a follow-up to #6375, this change refactors
>> java.io.ObjectInputStream.Caches#subclassAudits and
>> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead
>> of SoftReference, similar to what we did in #6375 for
Forwardport JDK 18 -> JDK 19
-
Commit messages:
- Merge
- 8277621: ARM32: multiple fastdebug failures with "bad AD file" after
JDK-8276162
- 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails
after the manpage was updated
- 8273179: Update nroff pages in
On Tue, 7 Dec 2021 19:06:17 GMT, John Neffenger wrote:
>> Thanks, CSR now Finalized
>
>> Thanks, CSR now Finalized
>
> Just a minor note: the CSR uses the adjective "extended" in three places for
> the DOS date and time field, but that field is actually a part of the
> original ZIP
On Fri, 10 Dec 2021 17:20:40 GMT, Kevin Rushforth wrote:
>> @LanceAndersen let me know if mach5 looks good please, then I think we're
>> good to go..
>
> @andrew-m-leonard if this enhancement is now intended to go into JDK 19, then
> you can simply integrate it into jdk mainline when it is
On Fri, 10 Dec 2021 17:01:41 GMT, Andrew Leonard wrote:
>> Looks like the CSR has been approved. I have a mach5 run that should
>> hopefully finish sooner rather than later and if that remains happy, I will
>> approve the PR
>
> @LanceAndersen let me know if mach5 looks good please, then I
On Tue, 7 Dec 2021 19:25:05 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
> java.io.ObjectStreamClass.Caches#localDescs. Then we can
On Wed, 1 Dec 2021 14:45:23 GMT, Roman Kennke wrote:
> As a follow-up to #6375, this change refactors
> java.io.ObjectInputStream.Caches#subclassAudits and
> java.io.ObjectOutputStream.Caches#subclassAudits to use ClassValue instead of
> SoftReference, similar to what we did in #6375 for
>
On Fri, 12 Nov 2021 21:43:42 GMT, Roman Kennke wrote:
> The caches in ObjectStreamClass basically map WeakReference to
> SoftReference, where the ObjectStreamClass also references
> the same Class. That means that the cache entry, and thus the class and its
> class-loader, will not get
Please review this change to obsolete deprecated CDS options UseSharedSpaces,
RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The change
was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5
tiers 3-5 on Linux x64 and Windows x64.
The use of
On Tue, 7 Dec 2021 10:42:50 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Fri, 10 Dec 2021 14:44:07 GMT, Kevin Rushforth wrote:
> This is a P4 bug. If the priority is correct, it does not meet the criteria
> to get it into JDK 18 during RDP1, as indicated in [JEP
> 3](https://openjdk.java.net/jeps/3).
>
> If this is objectively a P3 bug, and really does need to
On Tue, 7 Dec 2021 10:42:50 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Tue, 7 Dec 2021 10:42:50 GMT, Roman Kennke wrote:
>> The caches in ObjectStreamClass basically map WeakReference to
>> SoftReference, where the ObjectStreamClass also
>> references the same Class. That means that the cache entry, and thus the
>> class and its class-loader, will not get
On Fri, 10 Dec 2021 11:51:53 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
On Fri, 10 Dec 2021 10:54:06 GMT, Andrew Leonard wrote:
>> Add a new --source-date (epoch seconds) option to jar and jmod
>> to allow specification of time to use for created/updated jar/jmod entries.
>> This then allows the ability to make the content deterministic.
>>
>> Signed-off-by:
On Tue, 7 Dec 2021 19:25:05 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
On Thu, 9 Dec 2021 18:15:42 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
> Add a new --source-date (epoch seconds) option to jar and jmod to
> allow specification of time to use for created/updated jar/jmod entries. This
> then allows the ability to make the content deterministic.
>
> Signed-off-by: Andrew Leonard
Andrew Leonard has updated the pull request
On Thu, 9 Dec 2021 18:31:57 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
On Thu, 9 Dec 2021 18:40:01 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
On Thu, 9 Dec 2021 18:14:39 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276766: Enable jar and jmod to produce deterministic timestamped content
>>
>> Signed-off-by: Andrew Leonard
On Thu, 9 Dec 2021 22:11:57 GMT, Andrew Leonard wrote:
>> test/jdk/tools/jar/ReproducibleJar.java line 87:
>>
>>> 85: "2098-02-18T00:00:00-08:00",
>>> 86: "2099-12-31T23:59:59+00:00"};
>>> 87:
>>
>> I would suggest converting to
On Fri, 10 Dec 2021 07:00:10 GMT, Chris Plummer wrote:
> The test searches for "JShellToolProvider" in the main thread's stack trace,
> which is pulled from an SA heap dump. Typically the main thread is blocked in
> Object.wait(), so SA can determine its stack trace. However, the wait has a
>
On Fri, 10 Dec 2021 08:16:46 GMT, Christian Stein wrote:
>> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
>> class `PathFileObject` in module `jdk.compiler` were always composed by base
>> path names. Even for versioned entries of a multi-release JAR file.
>>
>>
On Thu, 9 Dec 2021 18:37:11 GMT, Alan Bateman wrote:
>> Christian Stein has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Clean up reproducer test case
>> - Keep helper in ZipFileSystem simple
>
>
> Prior to this PR, `toUri()` of class `ZipPath` in module `jdk.zipfs` and
> class `PathFileObject` in module `jdk.compiler` were always composed by base
> path names. Even for versioned entries of a multi-release JAR file.
>
> Now, a `URI` for an entry is composed of its real path names using
40 matches
Mail list logo
