On Tue, 12 Apr 2022 04:41:06 GMT, liach wrote:
> Hmm, isn't this misuse detected by `--release 8` in javac flags?
Ah, yes, when compiling with `--release 8`, it will prompt `the symbol cannot
be found`.
But here's the thing: I'm making some Java 11+ projects compatible with Java 8.
Since
On Tue, 12 Apr 2022 03:21:00 GMT, Glavo wrote:
> `java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no
> corresponding `@since` in the javadoc. The absence of `@since` makes it
> impossible for IDEs to check for misuse of it, it may be misused by users
> targeting Java 8 and
`java.time.LocalDate.EPOCH` was introduced in Java 9, but there is no
corresponding `@since` in the javadoc. The absence of `@since` makes it
impossible for IDEs to check for misuse of it, it may be misused by users
targeting Java 8 and crash at runtime.
-
Commit messages:
-
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Mon, 11 Apr 2022 10:13:40 GMT, Claes Redestad wrote:
> checkExactAccessMode -> checkAccessModeThenIsDirect
Don't you still want "Exact" in there? That "access" check seems odd anyway as
it only checks for one form of mismatch - should it not also check for `!exact
&&
On Mon, 11 Apr 2022 22:40:31 GMT, liach wrote:
>> Isn't it the case that the length of the global `skipBuffer` is
>> non-decreasing? Thus skipping 6 bytes after skipping 10 will not result in a
>> new buffer allocation.
>>
>> Even so, it does appear that prior buffer allocations could be
On Mon, 11 Apr 2022 12:04:41 GMT, Maurizio Cimadamore
wrote:
>> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141:
>>
>>> 139:
>>> 140: /*
>>> 141: * This function performs a thread-local handshake against all threads
>>> running at the time
>>
>> Nit: thread-local??
>
> I was
On Mon, 11 Apr 2022 22:31:01 GMT, Brian Burkhalter wrote:
> Even so, it does appear that prior buffer allocations could be "lost" due to
> concurrent use of skip resulting in a "minor" memory leak in the heap.
The minor leak, though maybe somewhat wasteful, is the necessary cost for
thread
On Sat, 9 Oct 2021 19:02:17 GMT, XenoAmess wrote:
>>> in extream situation, when doing this.skipBuffer = skipBuffer in Thread B,
>>> it might make this.skipBuffer to a byte[6] in thread A, and thus cause a
>>> IndexOutofBoundException in Thread A.
>>
>> No, it won't. The later `skipBuffer`
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that adds dedicated filler objects to
>> the VM?
>>
>> Currently, when formatting areas of dead objects all gcs use instances of
>> j.l.Object and int-arrays.
>>
>> This has the
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote:
> 8284637: Improve String.join performance
I think you can use or extend the existing
`org.openjdk.bench.java.util.StringJoinerBench` JMH for this.
Refer to [doc/testing.md](../tree/master/doc/testing.md) for setup help, but
you should be
On Mon, 11 Apr 2022 20:15:08 GMT, XenoAmess wrote:
> Is there jmh test data to quantify the improvement?
@RogerRiggs added jmh now.
Is there any test suite to run it but not run other jmh tests? Or I must invoke
the jmh jar using commandline myself to achieve it?
-
PR:
> 8284637: Improve String.join performance
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
add jmh
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8169/files
- new:
On Mon, 11 Apr 2022 05:31:49 GMT, Koichi Sakata wrote:
> # Summary
> Running jdeprscan with --help option causes an exception on any OSs when the
> locale is ja or zh_CN.
>
> # How to reproduce this issue
>
> $ jdeprscan -J-Duser.language=ja --help
> Exception in thread "main"
On Mon, 11 Apr 2022 19:22:21 GMT, Roger Riggs wrote:
> Is there jmh test data to quantify the improvement?
Not yet as I don't really know how to run a jmh for a package static function,
who calls some other class private functions...
Should I put the test upon StringJoiner insterad, as it
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote:
> 8284637: Improve String.join performance
src/java.base/share/classes/java/lang/String.java line 3290:
> 3288: value,
> 3289: off << coder,
> 3290:
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote:
> 8284637: Improve String.join performance
Is there jmh test data to quantify the improvement?
Is there jmh test data to quantify the improvement?
-
PR: https://git.openjdk.java.net/jdk/pull/8169
On Mon, 11 Apr 2022 10:13:40 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Mon, 11 Apr 2022 11:57:04 GMT, ExE Boss wrote:
> The issue is now
> [JDK‑8284637](https://bugs.openjdk.java.net/browse/JDK-8284637).
Yes. Just got the time to update it.
-
PR: https://git.openjdk.java.net/jdk/pull/8169
On Sat, 9 Oct 2021 18:10:34 GMT, liach wrote:
> > in extream situation, when doing this.skipBuffer = skipBuffer in Thread B,
> > it might make this.skipBuffer to a byte[6] in thread A, and thus cause a
> > IndexOutofBoundException in Thread A.
>
> No, it won't. The later `skipBuffer`
On Sat, 9 Oct 2021 17:08:50 GMT, XenoAmess wrote:
> in extream situation, when doing this.skipBuffer = skipBuffer in Thread B, it
> might make this.skipBuffer to a byte[6] in thread A, and thus cause a
> IndexOutofBoundException in Thread A.
No, it won't. The later `skipBuffer` references are
On Sat, 9 Oct 2021 17:01:16 GMT, XenoAmess wrote:
>> You should really post your changes to jdk-dev at openjdk.java.net before
>> submitting these so you can know if a change is potentially good or bad.
>> Since jdk pull requests require issue numbers, you can ask people on the
>> list if
On Sat, 9 Oct 2021 15:49:01 GMT, liach wrote:
> You should really post your changes to jdk-dev at openjdk.java.net before
> submitting these so you can know if a change is potentially good or bad.
> Since jdk pull requests require issue numbers, you can ask people on the list
> if this is a
On Fri, 8 Oct 2021 21:19:36 GMT, XenoAmess wrote:
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)
You should really post your changes to jdk-dev at openjdk.java.net before
submitting these so you can know if a change is potentially good
@jmehrens what about this then?
I think it safe now(actually this mechanism is learned from Reader)
-
Commit messages:
- store skip buffers in InputStream Object
Changes: https://git.openjdk.java.net/jdk/pull/5872/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5872=00
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote:
> 8284637: Improve String.join performance
The issue is now [JDK‑8284637](https://bugs.openjdk.java.net/browse/JDK-8284637
"[JDK‑8284637] Improve String.join performance").
-
PR: https://git.openjdk.java.net/jdk/pull/8169
8284637: Improve String.join performance
-
Commit messages:
- refine performance of String#join
Changes: https://git.openjdk.java.net/jdk/pull/8169/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8169=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8284637
Stats:
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote:
> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
> JDK version to target.
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Mon, 11 Apr 2022 12:32:26 GMT, Jim Laskey wrote:
>> `default float nextFloat(float origin, float bound); ` and `default double
>> nextDouble(double origin, double bound); ` are documented incorrectly. The
>> default method checks (origin < bound) and (bound - origin) < +infinity.
>>
>>
On Mon, 11 Apr 2022 12:32:26 GMT, Jim Laskey wrote:
>> `default float nextFloat(float origin, float bound); ` and `default double
>> nextDouble(double origin, double bound); ` are documented incorrectly. The
>> default method checks (origin < bound) and (bound - origin) < +infinity.
>>
>>
This is a (preliminary) patch for javac implementation for the third preview of
pattern matching for switch (type patterns in switches).
Draft JLS:
http://cr.openjdk.java.net/~gbierman/PatternSwitchPlusRecordPatterns/PatternSwitchPlusRecordPatterns-20220407/specs/patterns-switch-jls.html
The
On Mon, 11 Apr 2022 10:03:58 GMT, Claes Redestad wrote:
>>> How would the performance change if the `isDirect` and
>>> `checkExactAccessMode` merger was reverted?
>>
>> Add around 15-20ns/op for these micros.
>
> Restructuring so that we only check `direct` once sounds reasonable at face
>
On Mon, 11 Apr 2022 10:43:30 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
> Add support to compress bits and expand bits of `int` and `long` values, see
> Hacker's Delight (2nd edition), section 7.4.
>
> Compressing or expanding bits of an `int` or `long` value can be composed to
> enable general permutations, and the "sheep and goats" operation (SAG) see
> Hacker's
> Hi all,
>
> can I have reviews for this change that adds dedicated filler objects to
> the VM?
>
> Currently, when formatting areas of dead objects all gcs use instances of
> j.l.Object and int-arrays.
>
> This has the drawback of not being easily able to discern whether a given
> object
On Fri, 8 Apr 2022 16:37:07 GMT, Daniel Fuchs wrote:
> Please find enclosed a patch for
> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>
> My analysis is that the test fails intermittently because the `FileChannel`
> created by the test is garbage collected too
> `default float nextFloat(float origin, float bound); ` and `default double
> nextDouble(double origin, double bound); ` are documented incorrectly. The
> default method checks (origin < bound) and (bound - origin) < +infinity.
>
> The exception conditions are incorrect:
> "if {@code origin}
On Mon, 11 Apr 2022 10:33:54 GMT, David Holmes wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix TestLinkToNativeRBP
>
> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141:
>
>> 139:
>> 140: /*
>>
On Fri, 8 Apr 2022 16:45:54 GMT, Ioi Lam wrote:
>> Thomas Schatzl has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - iklam review
>> - Test case
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1727:
>
>> 1725:
> Hi all,
>
> can I have reviews for this change that adds dedicated filler objects to
> the VM?
>
> Currently, when formatting areas of dead objects all gcs use instances of
> j.l.Object and int-arrays.
>
> This has the drawback of not being easily able to discern whether a given
> object
On Fri, 8 Apr 2022 13:21:06 GMT, Jaikiran Pai wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added API-refinement to GZIPInputStream::read()/ZipInputStream::read() and
>> an Implementation note to
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave
On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Fri, 8 Apr 2022 13:11:23 GMT, Jaikiran Pai wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added API-refinement to GZIPInputStream::read()/ZipInputStream::read() and
>> an Implementation note to
> A few additional enhancements aiming to improve VH performance in the
> interpreter:
>
> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
> 40->48) but removes an object and an indirection on any instance actually
> used - and might avoid allocating the
On Mon, 11 Apr 2022 09:53:31 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/VarHandle.java line 2075:
>>
>>> 2073:
>>> 2074: @DontInline
>>> 2075: final void
>>> throwWrongMethodTypeException(VarHandle.AccessDescriptor ad) {
>>
>> This can actually be
On Mon, 11 Apr 2022 09:57:42 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/VarHandles.java line 719:
>>
>>> 717: //
>>> MethodHandle.linkToStatic();
>>> 718: //} else {
>>> 719: //MethodHandle mh =
On Mon, 11 Apr 2022 09:34:17 GMT, ExE Boss wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplified as suggested by @ExE-Boss
>
> src/java.base/share/classes/java/lang/invoke/VarHandles.java line 719:
>
>>
On Mon, 11 Apr 2022 09:26:12 GMT, ExE Boss wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplified as suggested by @ExE-Boss
>
> src/java.base/share/classes/java/lang/invoke/VarHandle.java line 2075:
>
>>
On Fri, 8 Apr 2022 12:20:32 GMT, Claes Redestad wrote:
>> A few additional enhancements aiming to improve VH performance in the
>> interpreter:
>>
>> - Flatten `TypeAndInvokers`: adds a pointer to `VarHandle` (a small increase
>> 40->48) but removes an object and an indirection on any
On Sat, 2 Apr 2022 16:05:06 GMT, Andrey Turbanov wrote:
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
This pull request
On Thu, 31 Mar 2022 03:53:15 GMT, Xiaohong Gong wrote:
>> Yeah, maybe I misunderstood what you mean. So maybe the masked store
>> `(store(src, m))` could be implemented with:
>>
>> 1) v1 = load
>> 2) v2 = blend(load, src, m)
>> 3) store(v2)
>>
>> Let's record this a JBS and fix it with a
On Mon, 11 Apr 2022 00:48:34 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
On Mon, 11 Apr 2022 07:33:20 GMT, ExE Boss wrote:
> Maybe it should use a `MethodHandle` fetched using `IMPL_LOOKUP` instead, in
> order to avoid the runtime overhead of going through `CallerSensitive`
> methods (`Class.forName` and `Constructor.newInstance`).
>
> It should probably also be
On Mon, 11 Apr 2022 07:12:09 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/StructureViolationExceptions.java
>> line 81:
>>
>>> 79: Constructor ctor;
>>> 80: try {
>>> 81: Class exClass =
>>>
On Sun, 10 Apr 2022 22:14:41 GMT, Magnus Ihse Bursie wrote:
> Should this not be `jdk.internal.misc`? (Also, if this is the case, maybe
> there's a test missing that could have discovered this...)
The exception is in an incubator module, it's just that code in java.base can't
statically
On Sun, 10 Apr 2022 00:40:02 GMT, ExE Boss wrote:
> This is supposed to point to the `package‑summary.html`
Thanks, this link is indeed wrong. Will be fixed when we refresh.
-
PR: https://git.openjdk.java.net/jdk/pull/8166
On Fri, 8 Apr 2022 22:17:23 GMT, Srinivas Vamsi Parasa
wrote:
>> Optimizes the divideUnsigned() and remainderUnsigned() methods in
>> java.lang.Integer and java.lang.Long classes using x86 intrinsics. This
>> change shows 3x improvement for Integer methods and upto 25% improvement for
>>
61 matches
Mail list logo
