On Mon, 2 May 2022 13:13:02 GMT, Weijun Wang wrote:
>> `lines.remove()` and `lines.subList()` will throw the correct exception.
>> Since you asked, we can add it.
>
> Now that we call `subList` at the beginning, I think there's no need to
> explicitly perform a check.
Hello Weijun, the change
> This is an early review of changes to better model JVM access flags, that is
> "modifiers" like public, protected, etc. but explicitly at a VM level.
>
> Language level modifiers and JVM level access flags are closely related, but
> distinct. There are concepts that overlap in the two domains
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Mon, 2 May 2022 06:25:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285915?
>>
>> With this change, the environment details collected by the failure handler
>> will now include the contents of the
On Mon, 2 May 2022 20:30:53 GMT, Joe Darcy wrote:
>> @irisclark does raise an interesting point: If, say, MR 2 doesn’t require a
>> change to the RI then the MR 1 RI is also the MR 2 RI, but its
>> `java.specification.maintenance.version` property will report that it’s the
>> MR 1 RI.
>>
>>
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties,
On Sun, 1 May 2022 14:35:28 GMT, Rémi Forax wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/util/concurrent/FutureTask.java line 222:
>
>> 220:
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE home page
> for
Please review the addition of @-see links from classes that mention the IEEE
754 floating-point standard to an IEEE page about the standard. The URL in the
initial version of the PR is the top search result on the IEEE home page for
"754 standard".
Another candidate page to use is
On Sun, 1 May 2022 04:51:17 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
On Sun, 1 May 2022 04:47:09 GMT, Ichiroh Takiguchi
wrote:
>> test/jdk/java/lang/System/i18nEnvArg.java line 26:
>>
>>> 24: /*
>>> 25: * @test
>>> 26: * @bug 8285517
>>
>> If the test should work only on a particular env, should describe here and
>> add `@requires` tag.
>
> Add "@requires
On Fri, 29 Apr 2022 17:11:55 GMT, Mark Reinhold wrote:
>> src/java.base/share/classes/java/lang/System.java line 743:
>>
>>> 741: * have the value {@code "1"}; after a second maintenance
>>> 742: * release, this property will have the value {@code "2"},
>>> 743: *
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.getProperties, for an initial release of a specification.
>
> Please
On Fri, 29 Apr 2022 06:33:42 GMT, Serguei Spitsyn wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
>
On Fri, 29 Apr 2022 06:43:02 GMT, Serguei Spitsyn wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
>
On Fri, 29 Apr 2022 13:31:30 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Mon, 2 May 2022 16:19:07 GMT, Mandy Chung wrote:
>> `Class.getInterfaces(false)` does not clone underlying array and can be used
>> in cases when the returned array is only read from.
>
> For the `checkPackageAccess` case, I don't think it worths fixing; not only
> that security manager is
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote:
> Please review this request to remove the `synchronized` keyword from the
> `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`.
This pull request has now been integrated.
Changeset: 9d8c3bf9
Author:Brian Burkhalter
On Sat, 30 Apr 2022 00:14:29 GMT, Tyler Steele wrote:
> PollingWatchService.java contains the WatchService and WatchKey
> implementation for AIX and BSD. When a Path is
>
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Fri, 29 Apr 2022 06:09:35 GMT, Serguei Spitsyn wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
>
On Fri, 29 Apr 2022 05:48:19 GMT, Serguei Spitsyn wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
>
On Mon, 2 May 2022 15:00:07 GMT, Roger Riggs wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285517: System.getenv() returns unexpected value if environment variable
>> has non ASCII character
>
> Can you
On Sat, 5 Mar 2022 13:07:56 GMT, Сергей Цыпанов wrote:
> `Class.getInterfaces(false)` does not clone underlying array and can be used
> in cases when the returned array is only read from.
For the `checkPackageAccess` case, I don't think it worths fixing; not only
that security manager is
On Fri, 29 Apr 2022 06:31:22 GMT, Andrey Turbanov wrote:
> `Map.containsKey` call is sometimes unnecessary, when it's known that Map
> doesn't contain `null` values.
> Instead we can just use Map.get and compare result with `null`.
> I found one of such place, where Map.containsKey calls could
On Mon, 2 May 2022 06:24:21 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Sat, 5 Mar 2022 13:07:56 GMT, Сергей Цыпанов wrote:
> `Class.getInterfaces(false)` does not clone underlying array and can be used
> in cases when the returned array is only read from.
I think this ok in general, but for consistency and to better call out that
we're dealing with a trusted
On Sun, 1 May 2022 04:51:17 GMT, Ichiroh Takiguchi
wrote:
>> On JDK19 with Linux ja_JP.eucjp locale,
>> System.getenv() returns unexpected value if environment variable has
>> Japanese EUC characters.
>> It seems this issue happens because of JEP 400.
>> Arguments for ProcessBuilder have same
On Fri, 29 Apr 2022 13:31:30 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Mon, 2 May 2022 07:39:39 GMT, Shruthi wrote:
>> Shruthi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updating last modified tag and XRTreeFragSelectWrapper.java
>
> `/integrate`
@shruacha1234 Please don't integrate without
On Mon, 2 May 2022 12:32:25 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
> This is the jsr166 refresh for jdk19. See
> https://bugs.openjdk.java.net/browse/JDK-8285450 and
> https://bugs.openjdk.java.net/browse/JDK-8277090
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
Address review comments
On Fri, 29 Apr 2022 15:51:12 GMT, Weijun Wang wrote:
>> test/lib/jdk/test/lib/util/FileUtils.java line 389:
>>
>>> 387: * @throws IOException
>>> 388: */
>>> 389: public static void patch(Path path, int fromLine, int toLine,
>>> String from, String to) throws IOException {
>>
>>
On Mon, 2 May 2022 13:01:40 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: Tests updated
Marked as reviewed
>> May the Java Community Process reconsider the present floating point
>> operations [...]?
Over the past several weeks, this community has unanimously replied to your
concerns with a clear: "No thanks, for the next decades we aren't interested in
changing the current semantics of
On Mon, 2 May 2022 06:25:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285915?
>>
>> With this change, the environment details collected by the failure handler
>> will now include the contents of the
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8285452: Tests updated
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8360/files
-
On Mon, 2 May 2022 10:42:35 GMT, Rémi Forax wrote:
>> Most AutoCloseables do not mention this in class-level javadocs. Is there a
>> reason you think this one should?
>
> close() is now equivalent to the method shutdownAndAwaitTermination() shown
> in the javadoc so i believe , replacing it
On Wed, 13 Apr 2022 17:42:57 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)` to
> highlight that it might write more bytes than the returned number of
> inflated bytes into the buffer `b`.
>
> The superclass `java.io.InputStream` specifies that `read(byte[] b, int off,
> int len)` will leave
On Fri, 8 Apr 2022 08:13:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that adds dedicated filler objects to
> the VM?
>
> Currently, when formatting areas of dead objects all gcs use instances of
> j.l.Object and int-arrays.
>
> This has the drawback of
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that adds dedicated filler objects to
>> the VM?
>>
>> Currently, when formatting areas of dead objects all gcs use instances of
>> j.l.Object and int-arrays.
>>
>> This has the
On Fri, 29 Apr 2022 16:45:01 GMT, Ioi Lam wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix test
>
> The latest version looks good to me.
Thanks @iklam @walulyai for your reviews
-
PR:
On Mon, 11 Apr 2022 14:55:32 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that adds dedicated filler objects to
>> the VM?
>>
>> Currently, when formatting areas of dead objects all gcs use instances of
>> j.l.Object and int-arrays.
>>
>> This has the
On Mon, 2 May 2022 10:23:01 GMT, Doug Lea wrote:
>> src/java.base/share/classes/java/util/concurrent/ExecutorService.java line
>> 138:
>>
>>> 136: * @author Doug Lea
>>> 137: */
>>> 138: public interface ExecutorService extends Executor, AutoCloseable {
>>
>> The class documentation should
On Sun, 1 May 2022 14:37:43 GMT, Rémi Forax wrote:
>> This is the jsr166 refresh for jdk19. See
>> https://bugs.openjdk.java.net/browse/JDK-8285450 and
>> https://bugs.openjdk.java.net/browse/JDK-8277090
>
> src/java.base/share/classes/java/util/concurrent/ExecutorService.java line
> 138:
>
Hi Brian & Alan,
I just run also into this issue and saw that that Alan suggested the use
of OutputStream.nullOutputStream() that we implemented a while ago:
On Sat, 5 Mar 2022 13:07:56 GMT, Сергей Цыпанов wrote:
> `Class.getInterfaces(false)` does not clone underlying array and can be used
> in cases when the returned array is only read from.
Let's wait a bit
-
PR: https://git.openjdk.java.net/jdk/pull/7714
On Fri, 29 Apr 2022 13:31:30 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
> A new API to support replacing selective lines with desired content.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8285452: Tests updated
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8360/files
-
To core-libs-dev, and Glavo,
this inner nature of C++, simply means that the floating point equation can be
altered in the decimal
direction; the beginning of value degredation could be altered in the equation
to be entirely outside
number type's the range. C++'s "apparent floating point" and
On Fri, 29 Apr 2022 23:14:45 GMT, Mikhailo Seledtsov
wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/lib/jdk/test/lib/thread/VThreadRunner.java line 61:
>
On Fri, 29 Apr 2022 20:57:01 GMT, Erik Gahlin wrote:
>> test/jdk/jdk/jfr/api/consumer/TestManyRecordings.java line 57:
>>
>>> 55: int classLoaderCount = Integer.parseInt(args[0]);
>>> 56: int classCount = Integer.parseInt(args[1]);
>>> 57: for (int i = 0; i >
>> Did you
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the `/etc/hosts/` file, which can be useful
> in certain cases when
> This is the implementation of JEP 425: Virtual Threads (Preview).
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the HotSpot VM are disabled by default and
> require running with `--enable-preview` to enable.
>
>
58 matches
Mail list logo
