Re: RFR: JDK-8287838: Update Float and Double to use snippets

2022-06-05 Thread Alan Bateman
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote: > Various code blocks in Float and Double would be better as snippets. One other thing you could do is link Pattern.matches in the snippet to the matches method. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.ja

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v3]

2022-06-05 Thread Xiaohong Gong
On Thu, 12 May 2022 16:07:54 GMT, Paul Sandoz wrote: >> Xiaohong Gong has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rename "use_predicate" to "needs_predicate" > > Yes, the tests were run in debug mode. The reporting of the missing con

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v3]

2022-06-05 Thread Xiaohong Gong
On Thu, 2 Jun 2022 03:24:07 GMT, Xiaohong Gong wrote: >>> @XiaohongGong Could you please rebase the branch and resolve conflicts? >> >> Sure, I'm working on this now. The patch will be updated soon. Thanks. > >> > @XiaohongGong Could you please rebase the branch and resolve conflicts? >> >> Sur

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
> > ./build/*/images/jdk/bin/jpackage --app-image > ~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign > --mac-signing-key-user-name "Developer ID Application: Michael Hall > (5X6BXQB3Q7)" > Bundler Mac DMG Package skipped because of a configuration problem: When > using an external ap

Re: RFR: 8287766: Unnecessary Vector usage in LdapClient

2022-06-05 Thread Aleksei Efimov
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote: > In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed > one place, where Vector could be replaced with ArrayList. > Usage of thread-safe collection `Vector` is unnecessary. It's recommended to > use `ArrayList` if

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
> On Jun 5, 2022, at 8:56 AM, Michael Hall wrote: > > > Fwiw, I was going to take a look at this but my build failed. > > === Output from failing command(s) repeated here === > * For target support_native_java.desktop_liblcms_cmstypes.o: > /Users/mjh/Documents/GitHub/jdk/src/java.desktop/sha

RFR: JDK-8287838: Update Float and Double to use snippets

2022-06-05 Thread Joe Darcy
Various code blocks in Float and Double would be better as snippets. - Commit messages: - JDK-8287838: Update Float and Double to use snippets Changes: https://git.openjdk.java.net/jdk/pull/9034/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9034&range=00 Issue: http

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v3]

2022-06-05 Thread Chris Hennick
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes > that by tracking the multiple of exponentialX0 as a long. (This changes

Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
On Sun, 5 Jun 2022 14:00:09 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in > -Xcomp. This pull request has now been integrated. Changeset: 3df4b034 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/3

Re: Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
On Sun, 5 Jun 2022 14:05:42 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in >> -Xcomp. > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the fast review! Especially early on a Sunday!! - PR: https://git.openj

Re: Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Roger Riggs
On Sun, 5 Jun 2022 14:00:09 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in > -Xcomp. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9033

Integrated: 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp

2022-06-05 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp. - Commit messages: - 8287837: ProblemList java/lang/ref/OOMEInReferenceHandler.java in -Xcomp Changes: https://git.openjdk.java.net/jdk/pull/9033/files Webrev: https://webrevs.openjdk.java.net/?repo=

Re: RFR: 8286850: [macos] Add support for signing user provided app image [v2]

2022-06-05 Thread Michael Hall
Fwiw, I was going to take a look at this but my build failed. === Output from failing command(s) repeated here === * For target support_native_java.desktop_liblcms_cmstypes.o: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132: error: parameter 'SizeOfTag'