> On Jun 5, 2022, at 8:56 AM, Michael Hall <mik3h...@gmail.com> wrote:
>
>
> Fwiw, I was going to take a look at this but my build failed.
>
> === Output from failing command(s) repeated here ===
> * For target support_native_java.desktop_liblcms_cmstypes.o:
> /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132:
> error: parameter 'SizeOfTag' set but not used
> [-Werror,-Wunused-but-set-parameter]
> void *Type_ProfileSequenceId_Read(struct _cms_typehandler_struct* self,
> cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)
>
> ^
> /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125:
> error: parameter 'SizeOfTag' set but not used
> [-Werror,-Wunused-but-set-parameter]
> void *Type_Dictionary_Read(struct _cms_typehandler_struct* self,
> cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)
>
> ^
> 2 errors generated.
>
>
> OS/X 12.4
>
> 2.4 GHz Quad-Core Intel Core i5
>
> If I should post that somewhere else let me know.
>
Again fwiw, I commented out references to SizeOfTag in the two methods and got
a good build.
./build/*/images/jdk/bin/jpackage --app-image
~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign
--mac-signing-key-user-name "Developer ID Application: Michael Hall
(5X6BXQB3Q7)"
Bundler Mac DMG Package skipped because of a configuration problem: When using
an external app image you must specify the app name.
Advice to fix: Set the app name via the -name CLI flag, the
fx:application/@name ANT attribute, or via the 'appName' bundler argument.
./build/*/images/jdk/bin/jpackage --app-image
~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app --mac-sign
--mac-signing-key-user-name "Developer ID Application: Michael Hall
(5X6BXQB3Q7)" --name HalfPipe
Warning: Using unsigned app-image to build signed dmg.
*** The app-image was actually a signed one. I’m not sure that matters. Also
since this would normally be my intention should there be a warning? ***
codesign -v --verbose=4 ~/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app
/Users/mjh/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app: valid on disk
/Users/mjh/HalfPipe/halfpipe_jpkg/outputdir/HalfPipe.app: satisfies its
Designated Requirement
*** Seems successful ***
Thanks again.
