Re: RFR: 8245095: Implementation of JEP 408: Simple Web Server

2021-09-14 Thread Florent Guillaume
On Tue, 14 Sep 2021 15:56:53 GMT, Julia Boes wrote: >> I think you can ignore my comment above. I went and checked the >> `content-types.properties` in their current state for both unix and windows >> and they already have a separate `application/zip` which is mapped to >> `.zip`. So I think

Re: RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread Florent Guillaume
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose wrote: >> 8273616: Fix trivial doc typos in the java.base module > > src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java > line 399: > >> 397: * If {@code true} then this method is required to force >> changes

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-15 Thread Florent Guillaume
On Wed, 14 Apr 2021 22:23:57 GMT, Peter Levart wrote: >> src/java.base/share/classes/java/lang/String.java line 3230: >> >>> 3228: >>> 3229: /** >>> 3230: * Designated join routine. >> >> Did you mean "dedicated"? > > No, I meant designated. It is the routine that all other public

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-14 Thread Florent Guillaume
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote: > While JDK-8148937 improved StringJoiner class by replacing internal use of > getChars that copies out characters from String elements into a char[] array > with StringBuilder which is somehow more optimal, the improvement was > marginal

Re: RFR: 8037397: Lost nested character class after intersection &

2021-03-31 Thread Florent Guillaume
On Wed, 31 Mar 2021 20:38:33 GMT, Ian Graves wrote: > Bug fix with the intersection `&&` operator in regex patterns. In > JDK-8037397, some character classes on the right hand side of the operator > are dropped in cases where nested `[..]` classes are used with non "nested" > ones.

Re: RFR: 8261366: Add discussion of IEEE 754 to BigDecimal

2021-03-08 Thread Florent Guillaume
On Mon, 8 Mar 2021 07:23:25 GMT, Joe Darcy wrote: > Informative update to BigDecimal and related classes to latest IEEE 754 > terminology, including a discussion of the similarities and differences of > BigDecimal and IEEE 754 decimal arithmetic. > > Once the wording is finalized, I'll reflow

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

2021-01-26 Thread Florent Guillaume
On Mon, 25 Jan 2021 20:51:06 GMT, Mahendra Chhipa wrote: >> https://bugs.openjdk.java.net/browse/JDK-8183372 > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comments.

Re: RFR: 8246788: ZoneRules invariants can be broken

2021-01-22 Thread Florent Guillaume
On Fri, 22 Jan 2021 14:48:00 GMT, Daniel Fuchs wrote: >> Tighten up argument checking in constructor. > > src/java.base/share/classes/java/time/zone/ZoneRules.java line 263: > >> 261: // last rules >> 262: Object[] temp = lastRules.toArray(); >> 263:

Re: Review Request: JDK-8235521: Replacement API for Unsafe::ensureClassInitialized

2020-06-04 Thread Florent Guillaume
user can produce a less privileged lookup by > Lookup::dropLookupMode and pass it to the framework. > >> > >> `Class::ensureInitialized` was considered as an alternative. The > downside for this option is that it would be caller sensitive in order to > ensure the caller

Re: RFR JDK-8186751: Add ISO-8859-16 Charset support

2017-09-01 Thread Florent Guillaume
he old one is copied to webrev.00) > > > - I think, the comment should now be in plural: # IANA alias > *es *- Also I think, it would make sense to at least add "ISO8859-16" and > "ISO8859_16" as # Other aliases > - "ISO-8859-15" must not be listed as alias,

Re: Review Request JDK-8155977: Update ObjectInputStream::resolveClass and resolveProxyClass to work with platform class loader

2016-05-05 Thread Florent Guillaume
155977/webrev.01/ Hi, "a generated to implement" should probably be fixed. Regards Florent -- Florent Guillaume, Director of R, Nuxeo Open Source, Java EE based, Enterprise Content Management (ECM) http://www.nuxeo.com http://www.nuxeo.org +33 1 40 33 79 87

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-04 Thread Florent Guillaume
On Wed, May 4, 2016 at 3:29 PM, Jan Lahoda <jan.lah...@oracle.com> wrote: > On 3.5.2016 14:58, Florent Guillaume wrote: >> http://www.x.org/docs/xterm/ctlseqs.pdf is probably a more canonical >> reference. > > It seems that this version of the document unfortunately d

Re: RFR 8147984: WindowsTerminal should support function keys

2016-05-03 Thread Florent Guillaume
t;>> [1] http://invisible-island.net/xterm/ctlseqs/ctlseqs.html >>> >>> >>> On 1/22/16 3:41 AM, Jan Lahoda wrote: >>>> >>>> Hello, >>>> >>>> I'd like to enhance the WindowsTerminal in jdk.internal.le with >>>> function keys &g

Re: RFR (S) 8148936: Adapt UUID.toString() to Compact Strings

2016-02-04 Thread Florent Guillaume
t; > On 02/04/2016 03:10 PM, Ivan Gerasimov wrote: > > Looks even better, thanks! > > > > Sincerely yours, > > Ivan > > > > On 04.02.2016 14:54, Aleksey Shipilev wrote: > >> Sure, here's a new webrev: > >>http://cr.openjdk.java.net/~sha