Changeset: 2e8d51a5596b
Author:henryjen
Date: 2013-09-03 12:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e8d51a5596b
8017513: Support for closeable streams
8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires
spec clarification
8022572: Same
Changeset: 06b01083ebd7
Author:henryjen
Date: 2013-09-03 16:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/06b01083ebd7
8023997: j.l.String.join(java.lang.CharSequence, java.lang.Iterable) sample
doesn't compile and is incorrect
Reviewed-by: alanb
!
On 08/30/2013 12:53 AM, Alan Bateman wrote:
On 30/08/2013 07:44, Henry Jen wrote:
Hi,
Please kindly review a simple webrev that just fixes a sample in the
javadoc of String.join().
http://cr.openjdk.java.net/~henryjen/tl/8023997/0/webrev/
This looks okay to me.
Thanks, I pushed
Hi,
Please kindly review a simple webrev that just fixes a sample in the
javadoc of String.join().
http://cr.openjdk.java.net/~henryjen/tl/8023997/0/webrev/
Cheers,
Henry
Changeset: 7de7100c30ce
Author:henryjen
Date: 2013-08-28 10:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de7100c30ce
8014566: Remove @ignore tags from MethodReference66 and InInterface when
8013875 is fixed
Reviewed-by: briangoetz, jjg
!
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8017513/1/webrev/
Based on the feedback/discussion from last time, the EG decided to
weaken AutoCloseable contract(see RFR 8022176[1]), and have Stream
extend AutoCloseable.
A quick briefing of the webrev,
- Remove
On 08/24/2013 01:40 PM, Alan Bateman wrote:
On 24/08/2013 14:09, Doug Lea wrote:
resource specification, while accurate, looked confusing here.
But we could include both terms, which seems like an improvement.
See below.
This looks better to me, thanks.
Updated webrev as concluded on this
Changeset: ade440668f94
Author:henryjen
Date: 2013-08-26 22:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ade440668f94
8023275: Wrapping collections should override default methods
Reviewed-by: mduigou, psandoz
! src/share/classes/java/util/Collections.java
+
Changeset: be2d25a277a7
Author:henryjen
Date: 2013-08-21 20:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be2d25a277a7
8023528: Rename Comparator combinators to disambiguate overloading methods
Reviewed-by: mduigou, smarks
! src/share/classes/java/util/Comparator.java
!
Changeset: 35c1609d9488
Author:henryjen
Date: 2013-08-09 09:05 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35c1609d9488
8023681: Fix raw type warning caused by Sink
Reviewed-by: mduigou, briangoetz
! src/share/classes/java/util/stream/Collectors.java
!
method
names.
Note, corrected email thread[2] link:
http://mail.openjdk.java.net/pipermail/lambda-libs-spec-experts/2013-August/002206.html
s'marks
On 8/22/13 8:21 PM, Henry Jen wrote:
Hi,
Please review a relative simple webrev[1] that basically simply renaming
Comparator methods
Hi,
Please kindly review the fix for eliminate some warnings in
java.util.stream package.
Chained Sink is an internal implementation detail, add the type for
downstream is more precise but verbose.
Included is also a couple other warnings cleanup.
Hi,
Please review a relative simple webrev[1] that basically simply renaming
Comparator methods. The reason behind the renaming can be found at this
email thread[2]. The specdiff is also available here[3].
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/ccc/8023528/0/webrev/
[2]
Changeset: 60891d90327f
Author:henryjen
Date: 2013-08-20 14:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60891d90327f
8016846: Pattern.splitAsStream tests required
Reviewed-by: alanb, psandoz
Contributed-by: Ben Evans benjamin.john.ev...@gmail.com
+
On 08/20/2013 02:21 AM, Paul Sandoz wrote:
[resending unsigned, sorry if a dup arrives later on]
On Aug 19, 2013, at 9:18 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8023275/0/webrev/
The patch adds override
On 07/24/2013 09:14 AM, Alan Bateman wrote:
On 16/07/2013 12:05, Henry Jen wrote:
Hi,
Please review the webrev at,
http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
The test is mostly contributed by Ben Evans.
Cheers,
Henry
It looks okay to me, just a concern that the tests
an extra @build tag.
The new webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8016846/1/webrev
Cheers,
Henry
-- Jon
On 08/20/2013 12:48 PM, Henry Jen wrote:
On 07/24/2013 09:14 AM, Alan Bateman wrote:
On 16/07/2013 12:05, Henry Jen wrote:
Hi,
Please review the webrev at,
http
Uh, this one was wrote to be a regular jtreg test running with main, not a
testNG test.
Thanks for looking into this.
Also I am wondering if this one still add any value, it was added to test the
API when we had it like
S super T ComparatorS thenComparing(Comparator? super T cmp)
Cheers,
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8023275/0/webrev/
The patch adds override on default methods for a couple wrapping classed
and delegate those to underlying class.
There is a minor revise on synchronizedCollection javadoc to cover Stream.
A sanity check
On 08/19/2013 01:01 PM, Mike Duigou wrote:
- @SuppressWarnings(unchecked) would appear to be in some of the cases.
Added.
- Replace:
@summary Unit tests for wrapping classes should delegate to default methods
with
@summary Ensure Collections wrapping classes provide non-default
Changeset: 5649837a4cfa
Author:briangoetz
Date: 2013-08-12 12:06 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5649837a4cfa
8019401: Collectors.collectingAndThen
Reviewed-by: mduigou
Contributed-by: brian.go...@oracle.com
!
Looks good to me.
Cheers,
Henry
On Aug 13, 2013, at 6:46 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
This patch fixes a bug in the data provider of the SpliteratorCollisions.java
test, which was attempting to add an element to an unmodifable map.
Interestingly although this
Changeset: 7758bcf0ab6b
Author:henryjen
Date: 2013-08-12 12:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7758bcf0ab6b
8022749: Convert junit tests to testng in test/java/lang/invoke
Reviewed-by: mduigou, alanb
Contributed-by: Mani Sarkar sadhak...@gmail.com
!
Hi,
Please review the webrev[1] adds an API to help compose a Collector with
an additional finish function.
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/ccc/8019401/0/webrev/
Hi,
Please review a webrev contributed by Mani Sarkar that converts junit
tests in test/java/lang/invoke to testng.
http://cr.openjdk.java.net/~henryjen/tl/8022749/0/webrev/
Cheers,
Henry
Hi,
Please review a webrev[1] clean up on serial warning, as we don't intend
to serialize those tasks, we simply suppress those warnings.
It would be nice if there is a way to undo serializable.
[1] http://cr.openjdk.java.net/~henryjen/tl/8022446/0/webrev/
Cheers,
Henry
On 08/06/2013 03:01 PM, Tom Hawtin wrote:
Are you happy with the API docs in docs/api/serialized-form.html?
Those are all internal classes, thus is not showing up on that page at
all. I assume this is the concern?
Cheers,
Henry
Changeset: 939c3be6cc86
Author:briangoetz
Date: 2013-06-28 16:26 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/939c3be6cc86
8015318: Extend Collector with 'finish' operation
Reviewed-by: mduigou
Contributed-by: brian.go...@oracle.com
!
Changeset: e303c228bf31
Author:henryjen
Date: 2013-08-06 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e303c228bf31
8022446: Fix serial warnings in java.util.stream
Reviewed-by: darcy
! src/share/classes/java/util/stream/AbstractShortCircuitTask.java
!
Ping on this, the 8012238 fix is already in, thus this webrev is ready
to go, only if we can have a reviewer review it.
Cheers,
Henry
On 07/09/2013 02:38 PM, Henry Jen wrote:
Hi,
An update from earlier request based on some feedbacks.
The webrev is at
http://cr.openjdk.java.net
In StremSpliterator:366, I assume the NULL check should be before if.
There are a couple
if {
}
else if
and
try {
}
catch
Isn't the style recommended to be on the same line?
Cheers,
Henry
On Aug 1, 2013, at 8:32 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
This patch fixes
I see, thanks. Looks good to me.
Cheers,
Henry
On Aug 1, 2013, at 8:49 AM, Paul Sandoz paul.san...@oracle.com wrote:
On Aug 1, 2013, at 4:45 PM, Henry Jen henry@oracle.com wrote:
In StremSpliterator:366, I assume the NULL check should be before if.
It saves a redundant check
On Jul 30, 2013, at 10:00 AM, Stuart Marks stuart.ma...@oracle.com wrote:
Hi Henry,
A couple minor comments on this.
I don't think it's necessary to snapshot other.value into a local
otherBuilder variable. If other == this, when the value is mutated by
prepareBuilder(), otherBuilder
Updated webrev adapting feedback from Stuart.
I need a sponsor to push the fix. Thanks for reviewing.
Cheers,
Henry
On 07/30/2013 11:27 AM, Henry Jen wrote:
On Jul 30, 2013, at 10:00 AM, Stuart Marks stuart.ma...@oracle.com wrote:
Hi Henry,
A couple minor comments on this.
I don't
On 07/30/2013 01:58 PM, Henry Jen wrote:
Updated webrev adapting feedback from Stuart.
I need a sponsor to push the fix. Thanks for reviewing.
Sigh, again, the webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8020977/1/webrev/
Cheers,
Henry
My bad, you should be on the reviewer list. After all, this update is based on
your feedback.
Webrev updated with Reviewed-by.
Cheers,
Henry
On Jul 30, 2013, at 3:03 PM, Stuart Marks stuart.ma...@oracle.com wrote:
On 7/30/13 1:59 PM, Henry Jen wrote:
On 07/30/2013 01:58 PM, Henry Jen wrote
Hi,
Please review a simple fix for 8020977.
The fix grab the length before initiate copying operation, so that the
'delimiter' added for this won't be included in copy.
For rest cases, the timing window changed a little, but that's fine as
simultaneous changes is not determined.
Cheers,
Henry
Sorry, the webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8020977/0/webrev/
Cheers,
Henry
On 07/29/2013 07:30 PM, Henry Jen wrote:
Hi,
Please review a simple fix for 8020977.
The fix grab the length before initiate copying operation, so that the
'delimiter' added for this won't
Hi,
Please review the webrev at,
http://cr.openjdk.java.net/~henryjen/tl/8016846/0/webrev/
The test is mostly contributed by Ben Evans.
Cheers,
Henry
/covariance-and-contravariance-in-scala/
cheers,
jed.
On 14 July 2013 04:49, Henry Jen henry@oracle.com
mailto:henry@oracle.com wrote:
I think the type you talking about here is Optional? extends U
instead of ? extends OptionalU.
IIRC, Optional? extends U is not a subtype
of OptionalParent – and therefore requires a covariant
return.
cheers,
jed.
On 13 July 2013 04:15, Mike Duigou mike.dui...@oracle.com wrote:
The ? extends Optional is unnecessary in flatMap as Optional is final.
Otherwise this looks good.
Mike
On Jul 5 2013, at 14:37 , Henry
On 07/10/2013 03:17 PM, Zhong Yu wrote:
A few things that require clarification:
If we have
interface A extends B, C
interface B extends MayHoldCloseableResource
interface C extends AutoCloseable
is A considered definitely holding resource?
Not programatically. A is both,
On 07/11/2013 01:13 AM, Florian Weimer wrote:
On 07/10/2013 11:30 PM, Henry Jen wrote:
A new interface, java.util.MayHoldCloseableResource, indicates an
implementation may or may not hold a resource need to be closed.
Why doesn't close() throw Exception?
Because there is really much
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8017513/0/webrev/index.html
This webrev improve resource release experience on Streams by
eliminating CloseableStream, instead, fold close capability into Stream.
A new interface, java.util.MayHoldCloseableResource, indicates
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015320.0/webrev/
This allows turning an Iterable into a stream with spliterator() methods
if the implementation provides one(like many Collection implementations)
rather than be forced to use less-efficient iterator().
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8020062/0/webrev/index.html
This webrev does as the bug suggested, is a refactoring that moves
StreamBuilder interfaces implementations into relevant Stream interfaces.
The patch is created against the version after
On 07/04/2013 12:01 AM, Paul Sandoz wrote:
On Jul 4, 2013, at 12:51 AM, Henry Jen henry@oracle.com wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/
Note that the same change has already been fixed/pushed forrelevant
implementations
On 07/04/2013 12:46 AM, Paul Sandoz wrote:
On Jul 4, 2013, at 9:31 AM, Henry Jen henry@oracle.com wrote:
Hi,
I updated the test, and split the ConcatTest.java so we don't encounter
the ClassNotFoundException issue on test-ng.
Please review the webrev at
http://cr.openjdk.java.net
On 07/08/2013 11:54 AM, Remi Forax wrote:
On 07/08/2013 08:31 PM, Henry Jen wrote:
On 07/04/2013 12:01 AM, Paul Sandoz wrote:
On Jul 4, 2013, at 12:51 AM, Henry Jen henry@oracle.com wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/
Note
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8019551/0/webrev/
This webrev makes BaseStream interface public and has AbstractPipeline
implements BaseStream.
The discussion on make this public can be found at
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015317.0/webrev/
Which adds following method to Optional,
public static T OptionalT ofNullable(T value) {}
public OptionalT filter(Predicate? super T predicate) {}
publicU OptionalU map(Function? super T, ? extends U
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015318.0/webrev/
This webrev refactor java.util.Collector interface to allow an
intermediate type used for accumulation and then produce final result
type with a 'finished' function.
Collectors are updated to reflect the
Forgot to mention this patch depends on fix of bug 8012238[1], to enable
compile without fix, attached patch will help.
[1] http://bugs.sun.com/view_bug.do?bug_id=8012238
Cheers,
Henry
On 07/05/2013 05:11 PM, Henry Jen wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net
Hi,
I updated the test, and split the ConcatTest.java so we don't encounter
the ClassNotFoundException issue on test-ng.
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8015315.1/webrev/
Cheers,
Henry
Hi,
Please review a simple addition of StringJoiner.merge method. This is
useful to combine StringJoiners used in parallel doing joining works.
The webrev can be found at
http://cr.openjdk.java.net/~henryjen/ccc/8017231.0/webrev/
Also included is a little clean up for StringJoinerTest.
Cheers,
On Jul 3, 2013, at 9:09 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 03/07/2013 09:03, Henry Jen wrote:
Hi,
Please review a simple addition of StringJoiner.merge method. This is
useful to combine StringJoiners used in parallel doing joining works.
The webrev can be found at
http
On Jul 3, 2013, at 9:57 AM, Henry Jen henry@oracle.com wrote:
On Jul 3, 2013, at 9:09 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 03/07/2013 09:03, Henry Jen wrote:
Hi,
Please review a simple addition of StringJoiner.merge method. This is
useful to combine StringJoiners
Hi,
Adapted comments from Alan and Paul, thanks for reviewing.
http://cr.openjdk.java.net/~henryjen/ccc/8017231.1/webrev/
Cheers,
Henry
.
Cheers,
Henry
On Jul 3, 2013, at 1:36 PM, Alan Bateman alan.bate...@oracle.com wrote:
On 03/07/2013 20:46, Henry Jen wrote:
Hi,
Adapted comments from Alan and Paul, thanks for reviewing.
http://cr.openjdk.java.net/~henryjen/ccc/8017231.1/webrev/
This looks good to me.
(I see you took
On 07/01/2013 02:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
Hi Henry,
I find the the cast
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8017141.0/webrev/
Cheers,
Henry
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
On 06/20/2013 03:45 PM, Michael Hixson wrote:
+ return new NullComparator(nullFirst, real == null ? null :
real.thenComparing(other));
Should that be other instead of the second null, like this?
+ return new NullComparator(nullFirst, real == null ? other :
real.thenComparing(other));
A ping to wake up the thread, there is a minor update regard the use of
@apiNote since last email.
Thanks in advance for reviewing.
Cheers,
Henry
On 06/15/2013 04:28 PM, Henry Jen wrote:
Reflecting feedbacks received so far, please see
http://cr.openjdk.java.net/~henryjen/ccc/8009736.3
On 06/14/2013 10:10 AM, Jason Mehrens wrote:
Any chance the static method Comparator.reverseOrder() will be renamed
to something like reversedNaturalOrder? Now all of the calls to
Comparator.reverseOrder() take on new meaning.
I feel that it's inconvenient for early adapters, but this is
Reflecting feedbacks received so far, please see
http://cr.openjdk.java.net/~henryjen/ccc/8009736.3/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8009736.3/specdiff
Cheers,
Henry
On 06/11/2013 02:04 PM, Henry Jen wrote:
Hi,
Please review http://cr.openjdk.java.net/~henryjen/ccc
On Jun 12, 2013, at 7:18 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi Henry,
If you don't mind could you hold off on committing this one until the
following have gone through to tl:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8016251-spinedBuffer-splitr/webrev/
Hi,
Please review a simple fix for 8016448, a test case missed from a API
change commit.
http://cr.openjdk.java.net/~henryjen/tl/8016448.0/webrev/
Cheers,
Henry
.
Mike
On Jun 12 2013, at 13:48 , Henry Jen wrote:
Hi,
Please review a simple fix for 8016448, a test case missed from a API
change commit.
http://cr.openjdk.java.net/~henryjen/tl/8016448.0/webrev/
Cheers,
Henry
Hi,
Please review
http://cr.openjdk.java.net/~henryjen/tl/8015522.0/webrev/
This webrev is based on previous suggestion from Martin Buchholz while
keep the lazy-binding nature without seize the length at construction time.
The benchmark shows ~50% performance increase, mainly from reduce of
Hi,
Please review a fix for 8014855.
http://cr.openjdk.java.net/~henryjen/tl/8014855.0/webrev/
The fix ensure we only test symbolic link related scenario on systems
support it.
Cheers,
Henry
On May 24, 2013, at 7:02 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 24/05/2013 09:30, Henry Jen wrote:
Hi,
Please review a fix for 8014855.
http://cr.openjdk.java.net/~henryjen/tl/8014855.0/webrev/
The fix ensure we only test symbolic link related scenario on systems
support
On 05/09/2013 03:11 AM, Alan Bateman wrote:
On 09/05/2013 06:27, Henry Jen wrote:
On 05/08/2013 09:17 PM, Mike Duigou wrote:
Looks good to me.
Thanks, we have a minor update to exclude changes for DirectoryStream.
http://cr.openjdk.java.net/~henryjen/ccc/8006884.2/webrev/
A quick review
something we can reuse in other tests.
Mike
On May 6 2013, at 09:56 , Henry Jen wrote:
Hi,
Updated based on feedback,
http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/specdiff/
Changed from previous request,
1
Hi,
Updated based on feedback,
http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/specdiff/
Changed from previous request,
1. DirectoryStream.entries() is renamed to DirectoryStream.stream().
2. Clarify operating closed stream returned
Hi,
Take feedbacks from previous round, the javadoc is updated
http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/specdiff/
/**
* Returns a {@code Stream}, the elements of which are lines read from
* this {@code
Hi,
Please review a couple stream access API proposed for
java.nio.file.Files and java.nio.file.DirectoryStream,
http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/specdiff/
Cheers,
Henry
On May 2, 2013, at 8:22 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 02/05/2013 07:52, Henry Jen wrote:
Hi,
Please review a couple stream access API proposed for
java.nio.file.Files and java.nio.file.DirectoryStream,
http://cr.openjdk.java.net/~henryjen/ccc/8006884.0/webrev/
http
On May 2, 2013, at 8:52 AM, Henry Jen henry@oracle.com wrote:
On May 2, 2013, at 8:22 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 02/05/2013 07:52, Henry Jen wrote:
Hi,
Please review a couple stream access API proposed for
java.nio.file.Files
On 05/02/2013 05:08 AM, Alan Bateman wrote:
On 02/05/2013 07:49, Henry Jen wrote:
Hi,
Take feedbacks from previous round, the javadoc is updated
http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/webrev/
http://cr.openjdk.java.net/~henryjen/ccc/8003258.2/specdiff/
This looks good to me
On 04/30/2013 12:32 AM, Alan Bateman wrote:
On 30/04/2013 06:17, Henry Jen wrote:
Hi,
Adapt feedback from the first round, updated webrev and specdiff can be
found at:
Summary of change,
1. Javadoc change for ZipFile::stream
2. A inner class implements Enumeration and Iterator
.
Cheers,
Henry
On Apr 30, 2013, at 9:35 AM, Paul Sandoz paul.san...@oracle.com wrote:
On Apr 30, 2013, at 5:43 PM, Henry Jen henry@oracle.com wrote:
So if possible we should report ORDERED and state the association, if any,
of encounter order with the order declared in the central
:
On Apr 30, 2013, at 9:02 PM, Henry Jen henry@oracle.com wrote:
Point taken.
It seems to me we should at least keep the ORDERED characterristic for
the returned stream, but not necessarily need to specify what order it is,
which would be inline with entries().
Does that make sense
On 04/29/2013 02:29 AM, Paul Sandoz wrote:
On Apr 27, 2013, at 10:15 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 26/04/2013 22:59, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8003258.1/webrev/
It adds a method to BufferedReader
++;
return toCodePoint(c1, c2);
On Thu, Apr 25, 2013 at 1:25 PM, Henry Jen henry@oracle.com
mailto:henry@oracle.com wrote:
Hi,
Please review two default methods add to CharSequence returns IntStream
of char value or code point value.
http
On 04/26/2013 06:21 AM, Alan Bateman wrote:
On 25/04/2013 21:25, Henry Jen wrote:
Hi,
Please review two default methods add to CharSequence returns IntStream
of char value or code point value.
http://cr.openjdk.java.net/~henryjen/tl/8012665.0/webrev/
The synchronization test is relieved
On 04/27/2013 08:01 AM, Alan Bateman wrote:
On 27/04/2013 00:08, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
The API doc in specdiff format is at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/specdiff
Cheers,
Henry
Hi,
Adapt feedback from the first round, updated webrev and specdiff can be
found at:
http://cr.openjdk.java.net/~henryjen/ccc/8012645.1/webrev
http://cr.openjdk.java.net/~henryjen/ccc/8012645.1/specdiff
Summary of change,
1. Javadoc change for ZipFile::stream
2. A inner class implements
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8003258.1/webrev/
It adds a method to BufferedReader.
public StreamString lines() {}
A class java.io.UncheckedIOException is also added as a general approach
for wrapping up an IOException to be unchecked.
Cheers,
Henry
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
The API doc in specdiff format is at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/specdiff
Cheers,
Henry
On 04/24/2013 06:54 AM, Alan Bateman wrote:
On 24/04/2013 00:09, Henry Jen wrote:
Hi,
Please review static Stream factory methods and methods for Arrays.
Webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.0
Stream methods are covered in a test suite which will be put
Hi,
Please review two default methods add to CharSequence returns IntStream
of char value or code point value.
http://cr.openjdk.java.net/~henryjen/tl/8012665.0/webrev/
The synchronization test is relieved so lambda and other synthetic
method is not tested. If synchronization is needed for
On 04/25/2013 01:57 PM, Paul Benedict wrote:
Henry,
I believe the coding standards require curly braces for any if-statement
and for-loop.
Also the return statements exceed the 80 character limit. It would be nice
to have them formatted across several lines like the following because it's
Hi,
Please review static Stream factory methods and methods for Arrays.
Webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.0
Stream methods are covered in a test suite which will be put back soon
once all depends part is in place.
Arrays setAll and parallelSetAll methods has
On 04/12/2013 11:56 AM, Henry Jen wrote:
On 04/10/2013 11:09 AM, Alan Bateman wrote:
On 10/04/2013 19:00, Henry Jen wrote:
Hi,
The bug is reported on lambda repo, part of the fix involved code
already integrated into TL/master, thus need help on review and commit.
Webrev at: http
On 04/10/2013 11:09 AM, Alan Bateman wrote:
On 10/04/2013 19:00, Henry Jen wrote:
Hi,
The bug is reported on lambda repo, part of the fix involved code
already integrated into TL/master, thus need help on review and commit.
Webrev at: http://cr.openjdk.java.net/~henryjen/tl/8010279.0/webrev
Hi,
The bug is reported on lambda repo, part of the fix involved code
already integrated into TL/master, thus need help on review and commit.
Webrev at: http://cr.openjdk.java.net/~henryjen/tl/8010279.0/webrev/
Simple changes in the code, with a little restructure of jtreg test to
fit
and primitive type. For those, comparing/thenComparing is
a more convenient and comprehensive expression.
Thoughts?
Cheers,
Henry
On 03/06/2013 03:06 PM, Michael Hixson wrote:
On Wed, Mar 6, 2013 at 1:01 PM, Henry Jen henry@oracle.com wrote:
On 03/06/2013 02:31 AM, Michael Hixson wrote:
1
,
Henry
1)
public static T, U extends Comparable? super U ComparatorT
compareWith(Function? super T, ? extends U keyExtractor) {
2)
default ComparatorT thenCompareWith(Comparator? super T other)
Best Regards,
Ali Ebrahimi
On Wed, Mar 6, 2013 at 12:16 AM, Henry Jen henry
On 03/06/2013 02:31 AM, Michael Hixson wrote:
Hello,
I'm not one of the people that you're looking at to review this, but I
have to give this feedback anyway. I tried to give similar feedback
on another mailing list and got no response (maybe I chose the wrong
list). These changes have
201 - 300 of 315 matches
Mail list logo
