Re: Is returning a value != '0' or '1' as jboolean from a JNI function legal?

/c1/c1_Runtime1.cpp#l1380 On Mon, Aug 20, 2018 at 9:28 AM, Volker Simonis wrote: > On Mon, Aug 20, 2018 at 6:09 PM, Krystal Mok > wrote: > > Hi guys, > > > > Haha this is fun. I actually hit this issue the hard way and had to > tweak a > > bit of my code to accommo

Re: Is returning a value != '0' or '1' as jboolean from a JNI function legal?

Hi guys, Haha this is fun. I actually hit this issue the hard way and had to tweak a bit of my code to accommodate that: I had to return a jint from a function that I wanted to return a jbool at first: http://hg.openjdk.java.net/hsx/hsx25/hotspot/diff/8f37087fc13f/src/share/vm/c1/c1_Runtime1.cpp

Race condition when serializing SerializedRandomAccessList

Hi core-libs, I'd like to report a bug on race condition while serializing SerializedRandomAccessList / deserializing SerializedList. This seems to be a long standing bug, we've hit it on JDK8 and the same code is still there in JDK11's core-lib. In SerializedRandomAccessList.writeReplace(): [1]

Re: Oracle Java 8u161 regression in XML Schema Factory

t; Sean. > On 26/01/2018 00:23, Krystal Mok wrote: > > Hi guys, > > A coworker of mine had hit this issue last night on 8u161 and it worked > fine on 8u151: > > ERROR: /home/myuser/.cache/bazel/_bazel_myuser/some_hash_code/ > external/jackson_datatype_joda_shaded/BUILD:5:1: Bu

Re: Oracle Java 8u161 regression in XML Schema Factory

Hi guys, A coworker of mine had hit this issue last night on 8u161 and it worked fine on 8u151: ERROR: /home/myuser/.cache/bazel/_bazel_myuser/some_hash_code/external/jackson_datatype_joda_shaded/BUILD:5:1: Building external/jackson_datatype_joda_shaded/libjackson-datatype-joda-class.jar (35

Re: [PATCH] Inefficient ArrayList.subList().toArray()

Hi Sergey, Not a Reviewer but I like this patch a lot. Thanks for contributing it to OpenJDK! Best regards, Kris On Thu, Jan 25, 2018 at 2:02 PM, Сергей Цыпанов wrote: > Hi, > > I've run into poor performance of toArray() method called on result of > subList() taken

Re: RFR: 8166840: Synthetic bridge constructor in ArrayList$Itr blocks inlining

Hi Claes, For this particular case, this JDK-side change looks good to me. Let me post out the HotSpot version of the change and let you guys decide whether or not you guys want to take that version (which will take care of the ArrayList$1 case without the JDK-side change). Thanks, Kris On

Re: RFR(s): 4285505: deprecate java.lang.Compiler

Hi OpenJDK developers, Replying on behalf of Azul Systems: java.lang.Compiler is an integral part of the current Java SE spec, and is currently being used by multiple independent Java SE implementations of that spec in a spec-conforming way (Azul Zing, Azul Vega, and IBM J9 being concrete

Re: RFR(s): 4285505: deprecate java.lang.Compiler

Hi Tim, Thanks for your reply. It's good to know at least the known use cases from IBM have indeed been discussed. On Thu, Sep 8, 2016 at 9:01 AM, Tim Ellison <t.p.elli...@gmail.com> wrote: > On 07/09/16 23:45, Krystal Mok wrote: > > I see that on the JBS page, your most rece

Re: RFR(s): 4285505: deprecate java.lang.Compiler

, > as Rémi noted, since people will no longer confuse it with an API for > invoking javac. > > s'marks > > [1] http://openjdk.java.net/jeps/165 > > On 9/7/16 3:45 PM, Krystal Mok wrote: > > Hi Stuart, > > I see that on the JBS page, your most recent comment says

Re: RFR(s): 4285505: deprecate java.lang.Compiler

Hi Stuart, I see that on the JBS page, your most recent comment says it's been decided that for JDK9 it's okay to deprecate and forRemoval=true, while also mentioning the uses of this class in IBM's implementation. Does that mean IBM has agreed on the deprecation of this class? I thought J9 had

Re: A bit of sugar for j.u.c.locks with try-with-resources?

support the try (locker(lock)) { ... } usage. The new TWR syntax was just extended to allow effectively final variables in the TWR header... Best regards, Kris On Sat, Sep 3, 2016 at 12:17 AM, David Holmes <david.hol...@oracle.com> wrote: > Hi Kris, > > On 3/09/2016 12:41 PM, Kr

Re: A bit of sugar for j.u.c.locks with try-with-resources?

Hi Vitaly, Thanks for your comments! On Fri, Sep 2, 2016 at 7:55 PM, Vitaly Davidovich <vita...@gmail.com> wrote: > Hi Kris, > > > On Friday, September 2, 2016, Krystal Mok <rednaxel...@gmail.com> wrote: > >> Hi core-libs developers, >> >> I mostly

A bit of sugar for j.u.c.locks with try-with-resources?

Hi core-libs developers, I mostly live down in the VM world, but recently I've been playing with j.u.c.locks a bit, and saw that there's an opportunity to retrofit the API with the try-with-resources syntax. I wonder if anybody has brought this topic up before; apologies if there had been. >From

Re: How to change locale in a Windows terminal?

Hi Max, Does setting -Duser.country=CN work for you? (I don't remember what the correct name for China should be, but setting that to US forces java to print the help message in English) - Kris On Tue, Aug 9, 2016 at 6:25 PM, Weijun Wang wrote: > My Windows 10 is

StackOverflowError on HashMap.hashCode() due to self reference

hashCode(). On Fri, Jul 17, 2015 at 2:45 PM, Krystal Mok rednaxel...@gmail.com wrote: Hi everyone, I'm sure somebody has seen this stack overflow before. My question is: is it expected (which should be documented to warn people not to do this), or is it considered a bug (which should

StackOverflowError on HashMap.hashCode() due to self reference

Hi everyone, I'm sure somebody has seen this stack overflow before. My question is: is it expected (which should be documented to warn people not to do this), or is it considered a bug (which should be fixed)? Example: https://gist.github.com/rednaxelafx/930f8979473185cfc0a0 import java.util.*;

Re: StackOverflowError on HashMap.hashCode() due to self reference

for a map to contain itself as a key. While it is permissible for a map to contain itself as a value, extreme caution is advised: the **equals and hashCode methods are no longer well defined on such a map.* (emphasis added) On Fri, Jul 17, 2015 at 12:11 PM Krystal Mok rednaxel...@gmail.com

Re: AbstractStringBuilder::append less inlined?

Hi Bernd, I agree with Vitaly. Tiered compilation may well be the reason you're seeing different logging -- in other words, your test is probably too short so that when tiered compilation is turned on, you're only seeing C1's compilation logs, and C2 compilation hasn't happened yet. Try turning

Re: How to close a Process and having shutdown hooks called ?

Hi Nicolas, Looks like a well discussed question. On Posix systems, SIGTERM should work for you. That's the default signal sent by the 'kill' command on Linux. e.g. please take a look here: http://stackoverflow.com/questions/2541597/how-to-gracefully-handle-the-sigkill-signal-in-java - Kris On

Re: Getting ciObject from oop/jobject

Hi Nick, This topic is related to HotSpot Server Compiler instead of the Java core library, so I'm cc'ing this email to hotspot-compiler-dev and dropping core-libs-dev. As you already know, HotSpot compilers are shielded from VM runtime implementation details via the Compiler Interface (CI).

Re: Request for Review : CR#6924259: Remove String.count/String.offset

Hi Nazario, That's a typical substring leak case. Matcher.group(n) eventually calls String.substring() to return the result. Before removing the count and offset fields in String, that'll return a String sharing the value char array, which may cause memory leaks if you hold on to a small

Re: about SuppressWarnings

Hi, If you're using javac to compile your Java source code, than you can try running javac -X to see the list of -Xlint options. That'll give you a hint of what warnings can be suppressed. As from the JavaDoc [1], the warning names are vendor specific. So if you're not using javac then youll

Re: StackTraceElement question

On Mon, Oct 8, 2012 at 7:27 AM, David Holmes david.hol...@oracle.comwrote: On Sat, Oct 6, 2012 at 3:04 AM, Christos Zoulaschris...@zoulas.com wrote: Hi, I don't know if this belongs to this list, but if it does not, please point me to where it does. I think that it would be nice if

Re: StackTraceElement question

On Mon, Oct 8, 2012 at 10:25 PM, Christos Zoulas chris...@zoulas.comwrote: On Oct 8, 11:07pm, david.hol...@oracle.com (David Holmes) wrote: -- Subject: Re: StackTraceElement question | There is also the problem of having a class hierarchy like: | | class A extends class I | class B

Re: StackTraceElement question

Hi, I believe this discussion belongs to core-libs-dev list better. cc'd. - Kris On Sat, Oct 6, 2012 at 3:04 AM, Christos Zoulas chris...@zoulas.com wrote: Hi, I don't know if this belongs to this list, but if it does not, please point me to where it does. I think that it would be nice if

Re: typo in comments of JVM_SupportsCX8 in jvm.h

On Fri, Jun 8, 2012 at 4:39 AM, chris hegarty chris.hega...@oracle.comwrote: Looks fine Kris (given the same change is being made to hotspot/src/share/vm/prims/**jvm.h) Yes. jvm.h in both the hotspot and jdk workspaces had incorrect comments on JVM_SupportsCX8 before this change, but they

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

Hi Mike, On Fri, May 25, 2012 at 10:12 AM, Mike Duigou mike.dui...@oracle.comwrote: On May 24 2012, at 16:32 , Vitaly Davidovich wrote: That's a bit odd as I thought the Klass object in the VM stored something like 7 supers, which includes interfaces (if I'm not mistaken). I know that

Re: Need reviewer: JDK 8 CR for Support Integer overflow

Hi Florian, On Fri, Feb 3, 2012 at 4:11 PM, Florian Weimer fwei...@bfk.de wrote: Will Hotspot be able to optimize away the string construction on the exception path in multiplyExact() if the exception is caught locally? At least -XX:+OptimizeStringConcat should remove the need to construct a

Re: Need reviewer: JDK 8 CR for Support Integer overflow

, at 12:38 AM, Krystal Mok wrote: Hi Florian, On Fri, Feb 3, 2012 at 4:11 PM, Florian Weimer fwei...@bfk.de wrote: Will Hotspot be able to optimize away the string construction on the exception path in multiplyExact() if the exception is caught locally? At least -XX:+OptimizeStringConcat

Re: typo in sun.misc.VM's comment

, Krystal Mok wrote: Hi all, Just found a little typo in sun.misc.VM: diff -r 00e2c88e2234 src/share/classes/sun/misc/VM.**java --- a/src/share/classes/sun/misc/**VM.java Thu Nov 17 10:46:02 2011 -0800 +++ b/src/share/classes/sun/misc/**VM.java Tue Jan 10 13:42:52 2012 +0800 @@ -167,7 +167,7

typo in sun.misc.VM's comment

Hi all, Just found a little typo in sun.misc.VM: diff -r 00e2c88e2234 src/share/classes/sun/misc/VM.java --- a/src/share/classes/sun/misc/VM.java Thu Nov 17 10:46:02 2011 -0800 +++ b/src/share/classes/sun/misc/VM.java Tue Jan 10 13:42:52 2012 +0800 @@ -167,7 +167,7 @@ // // The initial