Thank you for the review, Lance.
On 8/12/19 2:37 PM, Lance Andersen wrote:
Looks good Naoto.
One question I had which is not relevant to your fix, but should the
tests as we modify them include the JTReg tags such as @bug, @summary….
etc… just for consistency….
I put @bug tags to each of t
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8211990
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8211990/webrev.00/
The DateTimeException was thrown due to unconditional conversion beyond
the valid range of the int
Thanks, Roger.
I will replace the string length check as you suggested before push.
Naoto
On 8/7/19 2:14 PM, Roger Riggs wrote:
+1,
Bundle.java:226: there is a slight preference for String.isEmpty()
over String.length() == 0
Thanks, Roger
On 8/7/19 4:26 PM, Lance Andersen wrote:
awesome
Thanks for the review, Lance.
Yes, CSR is needed and it is already approved:
https://bugs.openjdk.java.net/browse/JDK-8218770
Naoto
On 8/7/19 1:20 PM, Lance Andersen wrote:
Hi again Naoto,
I meant to ask is there a CSR due to the change in the javadoc for
NumberFormat? If not, there probab
Ping.
Naoto
On 7/31/19 5:57 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8215181
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8215181/webrev.00/
This is to enable "accounting" style c
Hi Patrick,
Looks fine to me. Thanks for fixing the doc.
Naoto
On 8/6/19 9:20 AM, Patrick Concannon wrote:
Hi,
Would it be possible to have my fix for JDK-8228971 reviewed?
The is a trivial doc-only fix which removes redundant hyphens for
parameter descriptions for the Locale API doc. The i
+1
Naoto
On 8/6/19 8:13 AM, Seán Coffey wrote:
Looks good Ramanand.
regards,
Sean.
On 06/08/2019 06:57, Ramanand Patil wrote:
Hi all,
Please review the patch for jdk13u backport of tzdata2019b integration
into jdk:
Webrev: http://cr.openjdk.java.net/~rpatil/8228469/13u/webrev.00/
Bug: http
Hi Ramanand,
Looks good to me. Glad that the number of files to review has decreased
a lot :-)
Naoto
On 8/5/19 1:27 AM, Ramanand Patil wrote:
Hi all,
Please review the patch for tzdata2019b integration into jdk project(jdk-14).
Webrev: http://cr.openjdk.java.net/~rpatil/8228469/14/webrev.00/
Hi Ivan,
The change looks good to me.
Naoto
On 7/31/19 9:21 PM, Ivan Gerasimov wrote:
Hello!
Pattern.compile fails with IOOB when normalizing a pattern that contains
a surrogate pair.
Would you please help review a trivial 1-line fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-82283
Looks good to me, Thejasvi.
Naoto
On 8/1/19 6:42 AM, Thejasvi Voniadka wrote:
Hi,
Request you to please review this change.
JBS:https://bugs.openjdk.java.net/browse/JDK-8158880
(test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with
zh_CN locale)
Description:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8215181
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8215181/webrev.00/
This is to enable "accounting" style currency formatting (negative
values in parentheses) with CLDR.
Hi Thejasvi,
M/L does not designate textual nor numeric. Thus I don't think that the
suggested documentation fix is correct. Furthermore, although the
exception in JDK8 looks like a bug, the test result with JDK9 looks
correct to me. The month displayed as "04" is the result of
ZonedDateTime.
Looks good to me.
Naoto
On 7/30/19 6:55 AM, li.ji...@oracle.com wrote:
Hi,
Please help to review the update of L10n resource files in JDK13 msg
drop 20.
Bug: https://bugs.openjdk.java.net/browse/JDK-8228778
Webrev: http://cr.openjdk.java.net/~ljiang/8228778/webrev/read/
Thanks,
Leo
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8228465
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8228465/webrev.00/
Similar issue was reported with JDK-8039301, in which
Calendar.getDisplayName() method was modifie
Hi Joe,
Yes, I only removed not in-use files, i.e., 2 & 4. I sent the previous
email just after confirming that all tests (open/closed) passed on a
platform :-)
Naoto
On 7/25/19 2:24 PM, Joe Wang wrote:
Hi Naoto,
The legacy trap :-)
Relevant files:
1. make/data/tzdata/jdk11_backward
2. te
Hi Leo,
Looks good to me. I rather prefer noreg-l10n other than noreg-doc for
the Jira issue label.
Naoto
On 7/25/19 9:27 AM, li.ji...@oracle.com wrote:
Hi,
Please review this trivial change to correct the copyright year in
several java properties file. I updated the copyright year in Engl
Hi Roger,
On 7/25/19 7:47 AM, Roger Riggs wrote:
Hi Naoto,
TestZoneInfo310.java:
With the composition of the tzdir path up and over to the make directory
for the tzdir
it might be useful to do an explicit check that the directory exists.
That way if the directory structure on the build side c
Hi Joe,
Thank you for the review.
On 7/24/19 2:57 PM, Joe Wang wrote:
Hi Naoto,
The method findNegativeSavings method in TzdbZoneRulesProvider.java
states that it "Find the minimum negative savings". While the result is
correct since the rules all have the same value for SAVE, I wonder if
t
Hi Roger,
On 7/24/19 1:09 PM, naoto.s...@oracle.com wrote:
Thanks for the review, Roger.
On 7/24/19 12:47 PM, Roger Riggs wrote:
Hi Naoto,
Adjusting the data during import looks fine.
Typo:
TzdbZoneRulesProvider.java:504 "ususally" -> "usually"
Will fix it.
Removing the source duplica
Thanks for the review, Roger.
On 7/24/19 12:47 PM, Roger Riggs wrote:
Hi Naoto,
Adjusting the data during import looks fine.
Typo:
TzdbZoneRulesProvider.java:504 "ususally" -> "usually"
Will fix it.
Removing the source duplication is good.
Is there a way to remove the duplication of th
Looks good.
Naoto
On 7/24/19 12:52 AM, Baesken, Matthias wrote:
Hello, seems we need another "CFRelease(cflocale)"in an early return
case (see the default: ...) , new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8228501.1/
Best regards, Matthias
-Original Message
Hi,
Please review the fix to the following enhancement:
https://bugs.openjdk.java.net/browse/JDK-8212970
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8212970/webrev.09/
This change aims to support the "vanguard" IANA time zone data format,
which uses the negative
Thanks, Matthias. Changes look good to me.
I think it is hard to provide a regression test for this change, then
please add noreg-hard label to the issue.
Naoto
On 7/23/19 4:23 AM, Baesken, Matthias wrote:
Hello, please review the following fix that adds CFRelease to 2
CFLocaleCopyCurr
+1
Naoto
On 7/22/19 12:55 PM, Mandy Chung wrote:
Hi Leo,
Thanks for adding the copyright and license header. The patch looks
okay assuming you will separate the legal notices from the existing
comment block in JFC properties files.
Mandy
On 7/22/19 9:23 AM, li.ji...@oracle.com wrote:
Hi
Hi Matthias,
Thanks for catching them. Yes, I believe they should be released
appropriately.
Naoto
On 7/22/19 4:01 AM, Baesken, Matthias wrote:
Hello , maybe someone with more OSX dev knowledge could comment on this .
If I understand it correctly , the OSX Core Foundation Ownership P
Hi,
Please review this doc only fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8228450
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8228450/webrev.00/
This is simply to supply triple back ticks (```) in the .md files so
that the text will not
Looks good to me.
Naoto
On 7/15/19 7:19 AM, Severin Gehwolf wrote:
Hi,
Could I please get a review of this 11u backport? The JDK 14 patch
doesn't apply as is due to JDK-8221432 (CLDR data update) not being
present. I've fixed LocaleDataTest.java's @bug line manually. Otherwise
the patch is the
Looks good to me.
Naoto
On 7/9/19 11:53 PM, Ying Zhou wrote:
Hello,
Please review this patch for updating below tests by adding -ea/esa to
launcher parameters.
- /test/jdk/java/util/Calendar/SupplementalJapaneseEraTestRun.java
- /test/jdk/java/util/TimeZone/TimeZoneDatePermissionCheckRun.ja
-
From: Naoto Sato
Sent: Monday, July 8, 2019 11:19 PM
To: Ramanand Patil ; Andrew John Hughes
; core-libs-dev@openjdk.java.net; i18n-
d...@openjdk.java.net
Subject: Re: RFR: 8224560: (tz) Upgrade time-zone data to
tzdata2019a and 8225580: tzdata2018i integration causes test failures on jdk-
13
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8227127
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8227127/webrev.00/
This is a regression caused by the fix to 8039301, where era display
names are correctly retrieved
Hi Ramanand,
As to the change in ZoneInfoFile.java, I would put that special handling
of Gaza/Hebron in line 577, as well as merging the comment in 575,576,
so that it won't duplicate the code.
Otherwise looks good.
Naoto
On 7/8/19 3:35 AM, Ramanand Patil wrote:
Hi Andrew,
Thank you for yo
the locale addition. I have incorporated your
comments to TestLocalizedOffsetPrinterParser.java.
-Original Message-
From: Naoto Sato
Sent: Tuesday, July 02, 2019 9:33 PM
To: Thejasvi Voniadka ;
core-libs-dev@openjdk.java.net; i18n-...@openjdk.java.net
Subject: Re: RFR: 8154520
ew tests from TCK area. I have also updated the current TCK
test to explicitly pass Locale.US while calling format.
-----Original Message-
From: Naoto Sato
Sent: Monday, July 01, 2019 9:02 PM
To: Thejasvi Voniadka ;
core-libs-dev@openjdk.java.net; i18n-...@openjdk.java.net
Su
Hi Thejasvi,
Thanks for fixing this.
Since those new test cases depend on the CLDR localization, which might
change in other implementations, those test cases should be in
jdk/java/time/test directory, as "tck" tests should only test the spec.
Please create a new test case for this in the "te
Thanks for the review, Christoph.
I'll wait for a whole day so that everyone sees the fix. Planning to
push it tomorrow.
Naoto
On 6/27/19 2:05 PM, Langer, Christoph wrote:
The change looks good to me. But I would say the assertion in
CalendarDataUtility in line 266 is pointless now, isn't i
On 6/27/19 1:52 PM, Langer, Christoph wrote:
Hi Naoto,
thanks for providing a fix so quickly.
The change looks good to me. But I would say the assertion in
CalendarDataUtility in line 266 is pointless now, isn't it?
Yes, but would not hurt leaving it. It would catch error if yet another
cas
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8226876
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8226876/webrev.00/
This is an issue discovered on fixing a test case refactoring. [1] The
fix is to simply provide the
Hi Christoph,
Thanks for discovering the issue and resolving it. Your change looks
good to me. We will work on the actual issue you raised shortly.
Naoto
On 6/27/19 1:51 AM, Langer, Christoph wrote:
Hi,
Please, first of all, review a little test fix. Java level assertions
should be enabled
Looks good, Claes.
Naoto
On 6/26/19 6:22 AM, Claes Redestad wrote:
Hi,
please review this fix to make sure that this test is properly
skipped/ignored in all configurations (the @ignore needs to be listed
before @run). It is intermittently failing on some hardware
configurations in our internal
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8220229
The proposed changeset and CSR are located at:
https://cr.openjdk.java.net/~naoto/8220229/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8226308
This is to simply clarify the cases for z
Looks good, Roger. I think the bug needs "noreg-self" label.
Naoto
On 6/5/19 12:18 PM, Roger Riggs wrote:
Please review a test change to recognize an additional message that
indicates asynchronous close
in the process build testing.
The same fix was applied to address a similar intermittent t
Hi Claes,
Looks good to me. Thanks for catching this on so quickly!
Naoto
On 5/31/19 5:13 PM, Claes Redestad wrote:
Hi,
recent Unicode 12.1 updates caused a noticeable regression to Mac OS X
build times.
Quoting Naoto:
"The regression was caused by the call to Grapheme.nextBoundary() in
NFCC
Thanks, Roger.
On 5/30/19 6:55 AM, Roger Riggs wrote:
Hi Naoto,
This looks ok.
Typically, it is not necessary to check the exception message text.
I just wanted to make sure that the thrown DateTimeParseException is
none other than the exception that is expected. There seems no other way
to
Hi Joe,
Right, I will file a corresponding CSR.
Naoto
On 5/29/19 3:51 PM, Joseph D. Darcy wrote:
Hi Naoto,
Should this bug get a CSR for the behavioral change?
Cheers,
-Joe
On 5/29/2019 2:12 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix for the following issue:
https://bugs
Thanks, Lance.
Sure, will update the test case with @summary.
Naoto
On 5/29/19 2:21 PM, Lance Andersen wrote:
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are
consistent with other tests.
No need to spin a webrev again though
Best
Lance
On May 29, 2
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
Checking the range of HourOfAmPm with the range of AmPmOfDay is
apparently incorrect. Fixing it will
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
Naoto
On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the
Adding build-dev, as the change adds a small build tool to parse emoji-data.
Naoto
On 5/22/19 3:26 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8221431
The proposed CSR and changeset are located at:
https://b
Hi,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8221431
The proposed CSR and changeset are located at:
https://bugs.openjdk.java.net/browse/JDK-8222771
https://cr.openjdk.java.net/~naoto/8221431/webrev.03/
This enhancement incorporates support fo
Thanks, Brent. Modified the webrev accordingly:
http://cr.openjdk.java.net/~naoto/8224105/webrev.01/
Naoto
On 5/21/19 11:03 AM, Brent Christian wrote:
Hi, Naoto. I have a couple comments.
src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java
String.isEmpty()
Ping?
Naoto
On 5/17/19 3:43 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8224105
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8224105/webrev.00/
CLDR does not provide entire localized
Looks good.
Naoto
On 5/18/19 6:23 AM, li.ji...@oracle.com wrote:
Hi Naoto,
Please review the updated webrev:
http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/
In this update, renamed the data provider names and test case name to
improve the readability.
Thanks,
Leo
On 5/18/19 12:39 AM
Hi,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8224105
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8224105/webrev.00/
CLDR does not provide entire localized Japanese era names in locales
mentioned in the bug report. The
Hi Leo,
Overall looks good. One comment to the test case is that I would avoid
using the name "JavaTimeSupplementary" or "JTS", as they are the
implementation detail. Actually, a DateTimeFormatException may not
necessarily be caused by a missing JavaTimeSupplementary resource in the
runtime.
Thanks, Deepak. Looks good.
Naoto
On 5/15/19 6:13 AM, Deepak Kejriwal wrote:
Thanks Naoto for review, please find below updated version of webrev:-
http://cr.openjdk.java.net/~dkejriwal/8206879/webrev.02/
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Tuesday, May 14
rsion of webrev:-
http://cr.openjdk.java.net/~dkejriwal/8206879/webrev.01/
Regards,
Deepak
-Original Message-
From: Ramanand Patil
Sent: Monday, May 13, 2019 12:40 PM
To: Naoto Sato ; Deepak Kejriwal
; i18n-...@openjdk.java.net;
core-libs-dev@openjdk.java.net
Subject: RE: [13] RFR: JDK-82
Hi Deepak, here are my comments.
- FormatData_es_PE.java: Modify the copyright year to 2019.
- Changes in "LocaleData" may be placed at the bottom of the file,
explicitly indicating it is changed with 8206879. Please follow the
similar changes' format.
- Bug8206879.java does not have proper
Looks good. Please add "noreg-self" label to the issue.
Naoto
On 5/8/19 10:01 PM, Ying Zhou wrote:
Hello,
Please help to review this patch for migrating RuleBasedCollatorTest
from Tong to Jtreg.
Bug: https://bugs.openjdk.java.net/browse/JDK-8222969
webrev: http://cr.openjdk.java.net/~yzhou
Hi Steven,
Thanks for your comments. My comments are embedded below.
On 5/7/19 1:32 PM, Steven R. Loomis wrote:
Hi Naoto,
The comment in
http://cr.openjdk.java.net/~naoto/8221432/webrev.02/make/jdk/src/classes/build/tools/cldrconverter/Bundle.java.udiff.html
"fix up 'Reiwa' era, which can
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8221432
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8221432/webrev.02/
The webrev is big, but the large amount of the changes is simply
replacing the CLDR data files from
Thanks, Roger. Webrev is modified accordingly:
http://cr.openjdk.java.net/~naoto/8220037/webrev.01/
Naoto
On 5/6/19 11:59 AM, Roger Riggs wrote:
Hi Naoto,
CLDRConverter:
358-271: Is a lambda viable here? Not significantly different, just a
more contemporary style.
(o1, o2) -> {...}.
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8220037
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8220037/webrev.00/
The inconsistency comes from the different enumeration order of CLDR
source files on each platform. Fix i
Hello,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8222980
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8222980/webrev.00/
It is simply replacing the subtag registry file with the most up-to-date
one, along with test c
Hello,
Please review this trivial change to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8222668
Here is the one line change to add the @since tag:
--- old/src/java.base/share/classes/java/time/chrono/JapaneseEra.java
2019-04-17 13:38:30.0 -0700
+++ new/src/java.base/
wrote:
Hi Naoto,
thanks for reviewing!
On 2019-04-02 17:36, Naoto Sato wrote:
Hi Claes,
Thank you for looking into this. I remember we discussed this before.
One comment I have is that, currently the archive map seems to have
two level structure, i.e, lang, then country. There is another basic
Hi Claes,
Thank you for looking into this. I remember we discussed this before.
One comment I have is that, currently the archive map seems to have two
level structure, i.e, lang, then country. There is another basic element
that consists of a locale, that is script. At the moment, there is no
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8174268
The CSR and the proposed changeset are located at:
https://bugs.openjdk.java.net/browse/JDK-8193826
http://cr.openjdk.java.net/~naoto/8174268/webrev.02/
This is the other part of change of th
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8205432
The CSR and the proposed changeset are located at:
https://bugs.openjdk.java.net/browse/JDK-8218207
http://cr.openjdk.java.net/~naoto/8205432/webrev.03/
The fix is simply to replace all the o
On 3/28/19 4:54 PM, David Holmes wrote:
On 29/03/2019 1:59 am, Naoto Sato wrote:
Hi,
I don't think there is any *official* rule for the regression tests to
succeed in any locale, but if the test case is locale sensitive such
as in this case, I'd suggest it should correctly specify
Hi,
I don't think there is any *official* rule for the regression tests to
succeed in any locale, but if the test case is locale sensitive such as
in this case, I'd suggest it should correctly specify the locale
beforehand, or quit gracefully in general.
For this specific case, I'd suggest n
/8042131_8210633/webrev.01/
Regards,
Deepak
-Original Message-
From: Ramanand Patil
Sent: Monday, March 25, 2019 3:54 PM
To: Langer, Christoph ; Deepak Kejriwal
Cc: Naoto Sato ; core-libs-dev
; jdk8u-...@openjdk.java.net
Subject: RE: RFR: JDK8U Backport of JDK-8042131 and JDK-8210633
Hi
Hi Deepak,
Please modify the copyright year accordingly. Otherwise it looks good to me.
Naoto
On 3/22/19 8:51 AM, Deepak Kejriwal wrote:
Hi All,
Please review the back port of fix for JDK-8042131 and JDK-8210633 to 8u-dev:-
JBS report: https://bugs.openjdk.java.net/browse/JDK-80421
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8220224
Here is the CSR and proposed changeset:
https://bugs.openjdk.java.net/browse/JDK-8220728
http://cr.openjdk.java.net/~naoto/8220224/webrev.01/
DecimalFormatSymbols assumes minus/percent/permil
Looks good to me. I can sponsor your fix.
Naoto
On 3/11/19 1:57 AM, Toshio 5 Nakamura wrote:
Hi Naoto-san,
Thank you for reviewing the fix.
Could you re-review the updated webrev?
http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/
Thanks,
Toshio Nakamura
naoto.s...@oracle.com wrote on
Looks good to me, thanks. I can sponsor your fix.
Naoto
On 3/10/19 8:35 PM, Ichiroh Takiguchi wrote:
Hello Naoto.
I appreciate your suggestion.
I modified IBMBugs.java testcase.
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8220281
Change: https://cr.openj
Hi Takiguchi-san,
Looks good to me. I'd replace Locale.ENGLISH with Locale.ROOT for
toLowerCase() method.
On 3/7/19 4:57 PM, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8220281
Change: https://cr.openjdk.java.net/~itakiguchi/82
Hi Nakamura-san,
Thanks for fixing this. Since it is using a heuristic way to detect
"unknown", I'd use String.endsWith() instead of String.contains() both
in HostLocaleProviderAdapterImpl.java and LocaleProviders.java, which
would be more accurate.
Naoto
On 3/7/19 10:25 PM, Toshio 5 Nakamu
Looks good.
Naoto
On 3/7/19 3:51 AM, Nishit Jain wrote:
Thanks Naoto,
Updated: http://cr.openjdk.java.net/~nishjain/8217254_8217721/webrev.01/
Regards,
Nishit Jain
On 06-03-2019 23:24, naoto.s...@oracle.com wrote:
Hi Nishit,
Just one comment on j.t.CompactNumberFormat.java. At line 425, Nul
Hi Nishit,
Just one comment on j.t.CompactNumberFormat.java. At line 425, Null
check can be done at the top of the method, as a parameter check, so
that all the unnecessary "if-elseif" can be avoided. Others look good.
Naoto
On 3/6/19 3:56 AM, Nishit Jain wrote:
Hi,
Please review the fix
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8218948
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8218948/webrev.00/
This is a follow on fix to 8217366. There are several root causes
included in this bug, when the ru
specific to 8u and not related to new
era, I have raised a new issue JDK-8220020 for it.
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Friday, March 1, 2019 11:07 PM
To: Deepak Kejriwal ; core-libs-dev
; jdk8u-...@openjdk.java.net
Subject: Re: RFR: JDK8U Backport of 8217609
Hi Deepak,
A few comments on the JapaneseEraNameTest:
- Please indent code blocks accordingly, i.e., names object declaration
(line 47-51), for loop in the main() (line 56,59,60).
- If you are commenting out the case for LONG, please address the reason
with the comment (the following explana
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8219890
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8219890/webrev.00/
After the fix for 8217609, some locales return empty string for the
display name for the new era. P
Hi Nishit,
Looks good to me.
One minor typo: Bundle.java:line 699 "SimpledateFormat" ->
"SimpleDateFormat". No further review is needed for this.
Naoto
On 2/22/19 5:18 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8209175
Bug: https://bugs.openjdk.java.net/browse/JDK-8209175
We
it Jain
On 19-02-2019 22:51, Naoto Sato wrote:
Hi Nishit,
The reason is that "US" is the only required locale in the JDK (cf.
Locale.getAvailableLocales(). In fact, initially I supplied "001"
with it, as it means the "world" in CLDR, but it broke some existing
te
://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8u/webrev.02/
Thanks for review.
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Wednesday, February 20, 2019 11:07 PM
To: Deepak Kejriwal ; Sean Coffey
; core-libs-dev
; jdk8u-...@openjdk.java.net
Subject: Re: RFR: JDK8U
check now:-
http://cr.openjdk.java.net/~rpatil/JapaneseEra_changes_11u/webrev.02/
Regards,
Deepak
*From:*Seán Coffey
*Sent:* Thursday, February 21, 2019 2:11 PM
*To:* Deepak Kejriwal ; Naoto Sato
; core-libs-dev
; jdk-updates-...@openjdk.java.net
*Subject:* Re: RFR: JDK11U JDK-8206120, JDK
Thanks, Nishit.
I'd still like to ask for a review from a Reviewer.
Naoto
On 2/20/19 12:33 AM, Nishit Jain wrote:
Hi Naoto,
Thanks for the explanation. Change looks fine to me.
Regards,
Nishit Jain
On 19-02-2019 22:51, Naoto Sato wrote:
Hi Nishit,
The reason is that "US&qu
ind below updated version of webrev :-
http://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8u/webrev.01/
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Tuesday, February 19, 2019 10:40 PM
To: Deepak Kejriwal ; core-libs-dev
; jdk8u-...@openjdk.java.net
Subject:
ind below updated version of webrev :-
http://cr.openjdk.java.net/~rpatil/JapaneseEra_changes_11u/webrev.01/
Regards,
Deepak
-Original Message-
From: Naoto Sato
Sent: Tuesday, February 19, 2019 10:23 PM
To: Deepak Kejriwal ; core-libs-dev
; jdk-updates-...@openjdk.java.net
Subject: Re:
+1
Naoto
On 2/19/19 7:10 AM, Roger Riggs wrote:
Looks fine, Reviewed.
On 02/19/2019 04:05 AM, Nishit Jain wrote:
Hi Arno,
Although I don't know if turning off or no swap is expected for a test
environment, but tried reproducing the issue locally on a 8Gb Ubuntu
linux VM with swap turned
t region set to "US" if there is no region specified in
the locale? is this the default behavior of "first day of week" and
"minimal days in first week" when a region is missing or the default
behavior is that it returns "1"? Can't we just return "1
Hi Deepak,
Almost all the comments for the 11u changes [1] applies here, except the
"newCodePoint" comment. For this one, I'd suggest renaming
"newCodePoints" to "UNASSIGNED_CODEPOINTS_IN_6_2"
Naoto
[1]
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-February/058610.html
On 2/1
Hi Deepak,
Here are my comments to the webrev (other than what Sean pointed out):
TestIsJavaIdentifierMethods.java
- @summary: "testIsJavaLetter" -> "isJavaLetter",
"testIsJavaLetterOrDigit" -> "isJavaLetterOrDigit".
- Line 34: "newCodePoint" does not represent the era character, as "new"
i
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8218960
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8218960/webrev.00/
The CONFIG message was generated because CLDRCalendarDataProviderImpl
was returning null for locale
Thanks, Magnus. The change looks good to me too.
Naoto
On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote:
On 2019-02-01 14:43, naoto.s...@oracle.com wrote:
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same
as before this fix, correct?
Yes. I have verified this usi
+1
Naoto
On 2/4/19 10:18 AM, Roger Riggs wrote:
Hi Nishit,
Looks fine.
Thanks for fixing the test and improving the implementation.
The test could save one 2G allocation by using ByteBuffer.wrap(inputBytes)
instead of ByteBuffer.allocate(size).
Thanks, Roger
On 02/04/2019 10:31 AM, Nishi
Hello,
Please review this one line fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8218386
The proposed change is here:
---
diff -r 213a2377b792 src/java.base/share/classes/java/lang/Character.java
--- a/src/java.base/share/classes/java/lang/Character.java
+++ b/src/java.b
Hi Magnus,
I am assuming that the generated resource bundles are exactly the same
as before this fix, correct?
Naoto
On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
The CLDR data is, since Jigsaw, used in two different modules --
java.base and jdk.localedata. Unfortunately, the split between th
Hi Chris,
Thank you for the comments. I updated the CSR and the webrev:
https://bugs.openjdk.java.net/browse/JDK-8217938
https://cr.openjdk.java.net/~naoto/8216546/webrev.01/
Naoto
On 1/31/19 1:15 AM, Chris Hegarty wrote:
Naoto,
On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote:
...
h
1101 - 1200 of 1664 matches
Mail list logo
