Thank you, Alan
Regards,
Chris
> On 10 Sep 2018, at 5:42 PM, Alan Bateman wrote:
>
>
>
> On 10/09/2018 10:13, Chris Yin wrote:
>> Thank you, Alan
>>
>> Sure, I modified a little to remove “.” and use Path.of as you suggested to
>> improve file handling, minor revision as below, thanks
>>
>
On 10/09/2018 10:13, Chris Yin wrote:
Thank you, Alan
Sure, I modified a little to remove “.” and use Path.of as you suggested to
improve file handling, minor revision as below, thanks
http://cr.openjdk.java.net/~xyin/8209773/webrev.01/
The update looks okay to me.
-Alan
Thank you, Alan
Sure, I modified a little to remove “.” and use Path.of as you suggested to
improve file handling, minor revision as below, thanks
http://cr.openjdk.java.net/~xyin/8209773/webrev.01/
Regards,
Chris
> On 10 Sep 2018, at 3:20 PM, Alan Bateman wrote:
>
> On 30/08/2018 10:06, vyo
On 30/08/2018 10:06, vyom tewari wrote:
Hi Chris,
The refactored java class (RunBasic.java) looks good to me.
Looks okay to me too but the file handling could be improved, e.g. no
need to resolve path against ".", should specify the elements to Path.of
so that they use the right separator for
Thank you, Vyom
Regards,
Chris
> On 30 Aug 2018, at 5:06 PM, vyom tewari wrote:
>
> Hi Chris,
>
> The refactored java class (RunBasic.java) looks good to me.
>
> Thanks,
>
> Vyom
>
>
> On Tuesday 28 August 2018 11:20 AM, Chris Yin wrote:
>> Please have a review for below change to refacto
Hi Chris,
The refactored java class (RunBasic.java) looks good to me.
Thanks,
Vyom
On Tuesday 28 August 2018 11:20 AM, Chris Yin wrote:
Please have a review for below change to refactor shell test
javax/naming/module/basic.sh to plain java, no test logic change, old shell
script is remove
Please have a review for below change to refactor shell test
javax/naming/module/basic.sh to plain java, no test logic change, old shell
script is removed at same time, thanks
bug: https://bugs.openjdk.java.net/browse/JDK-8209773
webrev: http://cr.openjdk.java.net/~xyin/8209773/webrev.00/
Regar
