Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hello, On 10/12/2016 8:50 AM, Roger Riggs wrote: Hi Chris, On 10/10/2016 9:43 AM, Chris Hegarty wrote: Roger, [snip] Right, I was a little uneasy with this too, to being with, but it has grown on me ( since it appears stable and reliable in all my builds and tests ). Also the surface

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Chris, On 10/10/2016 9:43 AM, Chris Hegarty wrote: Roger, I addressed all, or most, of your comments in the following webrev. 1) Refactored out the use of sun.nio.ch in the test library, so that a reduced number of tests need their @modules tag updated. ( @modules support with test

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Roger, I addressed all, or most, of your comments in the following webrev. 1) Refactored out the use of sun.nio.ch in the test library, so that a reduced number of tests need their @modules tag updated. ( @modules support with test library usage it a pain ) 2) Use Boolean.getBoolean

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Chris, Some comments, BTW, there is a newer version of Webrev that provides convenient next and prev links... * sun/rmi/server/Activation.java: 1973 - I'd stick to the normal set of values for a boolean system property: use java.lang.Boolean.getProperty("sun.rmi"). * With so many

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Here is an updated version of this ( ready for review ): http://cr.openjdk.java.net/~chegar/8085192_webrev.02/ Changes from previous: 1) Updated Activation/rmid to NOT redirect stderr, if an implementation specific system property is used ( we can discuss the name ) 2) For now, I

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Joe, Roger, Modified based on your latest comments, please check the new webrev: http://cr.openjdk.java.net/~mli/8085192/webrev.02/ At the same time, I think Chris's idea is great. Thank you -Hamlin On 2016/9/30 7:14, Joseph D. Darcy wrote: If Hamlin's approach is taken in the end, I

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

If Hamlin's approach is taken in the end, I think having a smaller retry count (5 or 10 rather than 20) would be more appropriate to avoid making the worst-case running time longer than necessary. Cheers, -Joe On 9/29/2016 6:55 AM, Roger Riggs wrote: Hi Hamlin, One more suggested

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hello, Without commenting on the particulars, I'm happy to see work being done to address this issue in running the RMI tests. A fix here should greatly increase the reliability of the JDK test suite! Thanks, -Joe On 9/29/2016 12:09 PM, Chris Hegarty wrote: On 29 Sep 2016, at 16:25, Chris

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

On 29 Sep 2016, at 16:25, Chris Hegarty wrote: > > I have asked Hamlin to hold off on this for a day or so. I have an > alternative proposal that eliminates the free port anti-pattern. It is possible to use the inheritedChannel mechanism to have the rmid process

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

I have asked Hamlin to hold off on this for a day or so. I have an alternative proposal that eliminates the free port anti-pattern. -Chris. > On 29 Sep 2016, at 14:55, Roger Riggs wrote: > > Hi Hamlin, > > One more suggested improvement. Instead of two copy/paste

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Hamlin, One more suggested improvement. Instead of two copy/paste copies of the launch with options code, it would cleaner to create a separate RMID.launch(String[] options) method that would be passed the extra arguments. Use it in forceLogSnapshot.java and ShutdownGracefully.java. The

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Brent, Thank you for reviewing. Please check the new webrev: http://cr.openjdk.java.net/~mli/8085192/webrev.01/, and comments inline below. On 2016/9/28 2:07, Brent Christian wrote: Thanks for making some improvements to these intermittent RMI tests. I agree with Roger that I don't

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Roger, Thank you for reviewing. Please check the new webrev: http://cr.openjdk.java.net/~mli/8085192/webrev.01/, and comments inline below. On 2016/9/27 23:14, Roger Riggs wrote: Hi Hamlin, Marking each test that uses RMID.launch with the bugid does not seem to be meaningful since the

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Thanks for making some improvements to these intermittent RMI tests. I agree with Roger that I don't think we want to add the id to the @bug of every test. Also, it looks like there's an indentation change in JavaVM.java: 53 public static final long POLLTIME_MS = 100L; (I believe

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Hi Hamlin, Marking each test that uses RMID.launch with the bugid does not seem to be meaningful since the bug is in the support infrastructure of the test and not specific to the test itself. It would be overkill to try to confirm the bug was fixed by running all those tests. Putting the

[9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Please review the fix for JDK-8085192. The fix checks whether it fails to launch rmid due to "Port already in use" error, it will launch rmid again and again(20 times at most) until no such issue. bug: https://bugs.openjdk.java.net/browse/JDK-8085192 webrev: