Re: Fix for 5015163, and my first webrev

Am 14.10.2009 23:19, Andrew John Hughes schrieb: 2009/10/14 Ulf Zibis : Am 14.10.2009 17:01, Rémi Forax schrieb: Le 14/10/2009 16:47, Ulf Zibis a écrit : Rémi, can you tell me how you got the cr.openjdk.java.net account ? Is there any registration link? Thanks, Ulf

Re: Fix for 5015163, and my first webrev

2009/10/14 Ulf Zibis : > Am 14.10.2009 17:01, Rémi Forax schrieb: >> >> Le 14/10/2009 16:47, Ulf Zibis a écrit : >>> >>> Rémi, >>> >>> can you tell me how you got the cr.openjdk.java.net account ? >>> Is there any registration link? >>> >>> Thanks, >>> >>> Ulf >> >> I've got it because I've the rig

Re: Fix for 5015163, and my first webrev

Am 14.10.2009 17:01, Rémi Forax schrieb: Le 14/10/2009 16:47, Ulf Zibis a écrit : Rémi, can you tell me how you got the cr.openjdk.java.net account ? Is there any registration link? Thanks, Ulf I've got it because I've the right to push codes on mlvm repository (the DaVinci machine reposito

Re: Fix for 5015163, and my first webrev

Le 14/10/2009 16:47, Ulf Zibis a écrit : Rémi, can you tell me how you got the cr.openjdk.java.net account ? Is there any registration link? Thanks, Ulf I've got it because I've the right to push codes on mlvm repository (the DaVinci machine repository). I can use the same openjdk account to

Re: Fix for 5015163, and my first webrev

Rémi, can you tell me how you got the cr.openjdk.java.net account ? Is there any registration link? Thanks, Ulf Am 06.02.2009 21:59, Rémi Forax schrieb: Hi all, bug 5015163 is a RFE that advocate to add a method join (like in Python) to String/StringBuilder/StringBuffer. Here is the corresp

Re: Fix for 5015163, and my first webrev

Kevin Bourrillion wrote: Bumping this thread. From the peanut gallery, I believe that Rémi's change is extremely worthy. I have more nitpicking I'd like to do on it, but am holding off until we learn whether Sun would accept it in any shape. At this point, it's still very mysterious to me h

Re: Fix for 5015163, and my first webrev

Bumping this thread. From the peanut gallery, I believe that Rémi's change is extremely worthy. I have more nitpicking I'd like to do on it, but am holding off until we learn whether Sun would accept it in any shape. At this point, it's still very mysterious to me how this will work (small, simp

Re: Fix for 5015163, and my first webrev

Kevin Bourrillion a écrit : Hello, A few thoughts. First, this functionality is badly needed. Absolutely everyone rewrites this, in hundreds of different ways. At Google we're no exception, we have our own hand-rolled Join.java class full of static methods, and it has thousands of callers in

Re: Fix for 5015163, and my first webrev

Hello, A few thoughts. First, this functionality is badly needed. Absolutely everyone rewrites this, in hundreds of different ways. At Google we're no exception, we have our own hand-rolled Join.java class full of static methods, and it has thousands of callers in our private codebase. Your se

Re: Fix for 5015163, and my first webrev

Rémi Forax wrote: Xueming Shen a écrit : public String join(Object first, Object... elements) { if (elements.length==0) return String.valueOf(first); return new StringBuilder().join(this, first, elements).toString(); } It does not look right to simply return String.valueOf(first

Re: Fix for 5015163, and my first webrev

Xueming Shen a écrit : public String join(Object first, Object... elements) { if (elements.length==0) return String.valueOf(first); return new StringBuilder().join(this, first, elements).toString(); } It does not look right to simply return String.valueOf(first); when elements s

Re: Fix for 5015163, and my first webrev

public String join(Object first, Object... elements) { if (elements.length==0) return String.valueOf(first); return new StringBuilder().join(this, first, elements).toString(); } It does not look right to simply return String.valueOf(first); when elements size is 0, where is "this

Fix for 5015163, and my first webrev

Hi all, bug 5015163 is a RFE that advocate to add a method join (like in Python) to String/StringBuilder/StringBuffer. Here is the corresponding webrev (using the new infrastucture :) http://cr.openjdk.java.net/~forax/5015163/webrev.00/ The patch is against tl repository. Who want to review it ?