RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName; " even if "entities" property is

2016-12-18 Thread Frank Yuan
Thank you all! I have pushed the change with the license header update. Frank -Original Message- From: Joe Wang [mailto:huizhe.w...@oracle.com] Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an

Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName;" even if "entities" property is

2016-12-15 Thread Joe Wang
tml.properties, I am not sure for the license of this file. To Joe Could you confirm Christoph's comment for output_html.properties? Thanks Frank -Original Message- From: Langer, Christoph [mailto:christoph.lan...@sap.com] Subject: RE: RFR (JAXP) JDK-8087303 LSSerializer pretty p

RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName;" even if "entities" property is

2016-12-15 Thread Langer, Christoph
_html.properties? > > > Thanks > Frank > > > -Original Message- > > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > > Subject: RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work > anymore and JDK-8114834 LSSerializerImpl always

RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName; " even if "entities" property is

2016-12-15 Thread Frank Yuan
t for output_html.properties? Thanks Frank > -Original Message- > From: Langer, Christoph [mailto:christoph.lan...@sap.com] > Subject: RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work > anymore and JDK-8114834 LSSerializerImpl always serializes an > entity reference

RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName; " even if "entities" property is

2016-12-15 Thread Frank Yuan
JAXP) JDK-8087303 LSSerializer pretty print does not work > anymore and JDK-8114834 LSSerializerImpl always serializes an > entity reference node to" &entityName;" even if "entities" property is false > > Hi Frank, > > Thanks for the diligent work! I think we

RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName;" even if "entities" property is

2016-12-14 Thread Langer, Christoph
---Original Message- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf > Of Joe Wang > Sent: Mittwoch, 14. Dezember 2016 04:09 > To: Frank Yuan > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print d

Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore and JDK-8114834 LSSerializerImpl always serializes an entity reference node to" &entityName;" even if "entities" property is

2016-12-13 Thread Joe Wang
Hi Frank, Thanks for the diligent work! I think we've made a great improvement over the PrettyPrint (tremendous ;-) ) Could you look into extracting the XML literal strings in the test into plain files (similar to the other 'gold' files)? What I'm hoping to see is that they'd look easily pre

RE: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore

2016-09-12 Thread Frank Yuan
Hi Aleksey Thank you very much for your review an comments! > -Original Message- > From: Aleksey Shipilev [mailto:sh...@redhat.com] > Sent: Monday, September 12, 2016 6:45 PM > To: Frank Yuan; 'core-libs-dev' > Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer p

Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore

2016-09-12 Thread Joe Wang
Hi Frank, I was thinking we could just fix the current issue. Then in order to be consistent among different processors, we made wider changes. As you said, we're not backward-compatible anymore. That, and plus xml:space, it looks like a CCC can not be avoided. If that's what we have to do,

Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work anymore

2016-09-12 Thread Aleksey Shipilev
On 09/12/2016 12:54 PM, Frank Yuan wrote: > Would you like to review http://cr.openjdk.java.net/~fyuan/8087303/webrev.01/? Not an expert in the XML parsing area, so only a cursory code review: ToStream.java: *) Bad camel casing: 113 protected boolean m_ispreserveSpace = false; *) sho