Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-27 Thread Martijn Verburg
Hi Thomas, Will do and appreciate the support! Cheers, Martijn On Wed, 27 Mar 2019 at 11:13, Thomas Stüfe wrote: > > > On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg > wrote: > >> Hi Thomas, >> >> Release only (we've only created debug builds for x64), >> > > Okay. A number of those

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-27 Thread Thomas Stüfe
On Wed, Mar 27, 2019 at 11:08 AM Martijn Verburg wrote: > Hi Thomas, > > Release only (we've only created debug builds for x64), > Okay. A number of those errors were debug only. > we do use the treat errors as warnings flag. > Other way around, I hope ;) > > You can look at all of our

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-27 Thread Martijn Verburg
Hi Thomas, Release only (we've only created debug builds for x64), we do use the treat errors as warnings flag. You can look at all of our build configurations and build histories at ci.adoptopenjdk.net - and I've copied in Ali Ince who's working for jClarity on Windows 32/64 builds amongst

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-26 Thread Thomas Stüfe
On Mon, Mar 25, 2019 at 10:49 PM Martijn Verburg wrote: > Hi all, > > Snipping much, but commenting on one statement inline below. > > On Mon, 25 Mar 2019 at 01:58, David Holmes > wrote: > >> Hi Thomas, >> >> A few queries, comments and concerns ... >> >> On 25/03/2019 6:58 am, Thomas Stüfe

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Martijn Verburg
Hi all, Snipping much, but commenting on one statement inline below. On Mon, 25 Mar 2019 at 01:58, David Holmes wrote: > Hi Thomas, > > A few queries, comments and concerns ... > > On 25/03/2019 6:58 am, Thomas Stüfe wrote: > > Hi all, > > > > After a long time I tried to build a Windows 32bit

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-25 Thread Kim Barrett
> On Mar 24, 2019, at 4:58 PM, Thomas Stüfe wrote: > > Hi all, > > After a long time I tried to build a Windows 32bit VM (VS2017) and failed; > multiple errors and warnings. Lets reverse the bitrot: > > cr: >

Re: RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-24 Thread David Holmes
Hi Thomas, A few queries, comments and concerns ... On 25/03/2019 6:58 am, Thomas Stüfe wrote: Hi all, After a long time I tried to build a Windows 32bit VM (VS2017) and failed; I'm somewhat surprised as I thought someone was actively doing Windows 32-bit builds out there, plus there are

RFR(xs): 8221375: Windows 32bit build (VS2017) broken

2019-03-24 Thread Thomas Stüfe
Hi all, After a long time I tried to build a Windows 32bit VM (VS2017) and failed; multiple errors and warnings. Lets reverse the bitrot: cr: http://cr.openjdk.java.net/~stuefe/webrevs/8221375--windows-32bit-build-(vs2017)-broken-in-many-places/webrev.00/webrev/ Issue: