Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-05-23 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi Lin, > > On Mar 24, 2021, at 2:51 AM,

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-15 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Lin Zang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update copyright >> - reuse arguments constructor for non-argument one. > > Hi Lin, > > On Mar 24, 2021, at 2:51 AM,

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-11 Thread Lance Andersen
Hi Lin On Apr 10, 2021, at 11:16 PM, Lin Zang mailto:lz...@openjdk.java.net>> wrote: Dear @AlanBateman and @LanceAndersen, Thanks a lot for your review and comments! We should look to see if it makes sense to use some of the more recent java features such as Record. If we are adding a

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-10 Thread Lin Zang
On Thu, 8 Apr 2021 08:54:06 GMT, Alan Bateman wrote: >> Dear All, >> May I ask your help to review this change? Thanks! >> >> BRs, >> Lin > >> Dear All, >> May I ask your help to review this change? Thanks! > > @LanceAndersen Do you have cycles to help Lin? This proposal will require >

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-08 Thread Lance Andersen
Hi Lin, First thank you for your efforts on this feature. As Alan suggested on March 26, we should take a step back and flush out the overall changes to the API before moving forward with additional PR reviews. We should look to see if it makes sense to use some of the more recent java

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-08 Thread Alan Bateman
On Thu, 8 Apr 2021 08:29:36 GMT, Lin Zang wrote: > Dear All, > May I ask your help to review this change? Thanks! @LanceAndersen Do you have cycles to help Lin? This proposal will require discussion, they may be case for the header to be a record for example. My personal view is that the PR

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-08 Thread Lin Zang
On Fri, 2 Apr 2021 08:53:20 GMT, Lin Zang wrote: >> Hi Lin, >> >> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote: >> >> >> >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I ask your help to also review the CSR? >> >> I believe we need to

Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v3]

2021-04-02 Thread Lin Zang
On Wed, 24 Mar 2021 10:25:44 GMT, Lance Andersen wrote: >> Hi Lance, >> Thanks a lot for your review. I will update the PR ASAP. >> May I ask your help to also review the CSR? Thanks! >> >> BRs, >> Lin > > Hi Lin, > > On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote: > >