On Fri, 5 Feb 2021 03:00:05 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments and copyright.
>
> src/hotspot/share/classfile/javaClasses.cpp line 4415:
>
>> 4413:
>> 4414: //
On Fri, 5 Feb 2021 02:28:31 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 503:
>>
>>> 501: } else {
>>> 502: log_debug(protectiondomain)("granted");
>>> 503: }
>>
>> Did you intend leaving this in?
>
> Yes, why not? It's very useful in
On Fri, 5 Feb 2021 02:25:15 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/dictionary.cpp line 145:
>>
>>> 143: #ifdef ASSERT
>>> 144: if (protection_domain == instance_klass()->protection_domain()) {
>>> 145: MutexLocker ml(ProtectionDomainSet_lock,
>>>
On Fri, 5 Feb 2021 02:37:54 GMT, Coleen Phillimore wrote:
>> This change does not call up to Java for checkPackageAccess if the security
>> manager is NULL, but still saves the protection domain in the pd_set for
>> that dictionary entry. If the option -Djava.security.manager=disallow is
>>
> This change does not call up to Java for checkPackageAccess if the security
> manager is NULL, but still saves the protection domain in the pd_set for that
> dictionary entry. If the option -Djava.security.manager=disallow is set,
> that means that there will never be a security manager and
