Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Jaroslav Bachorik
On Wed, 21 Apr 2021 13:21:32 GMT, Jaroslav Bachorik wrote: >> How does it look in proc? > > This was based on > https://github.com/openjdk/jdk/blob/da860290c2657c0fb1de8c77c8dffdb35f1cf938/src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java#L149 > > However, that metric is

Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Jaroslav Bachorik
On Wed, 21 Apr 2021 11:50:25 GMT, Erik Gahlin wrote: >> I guess we could fit those events under `Operating System/Memory` and >> `Operating System/Processor` categories. >> What about I/O? Currently, there is only `Operating System/Network` >> category. The options are: >> * Add `Operating

Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Jaroslav Bachorik
On Wed, 14 Apr 2021 10:26:44 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 11 commits: >> >> - Roll back conditional registration of container events >> - Remove container events

Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Jaroslav Bachorik
On Wed, 21 Apr 2021 11:55:48 GMT, Erik Gahlin wrote: >> I don't see this event field being set anywhere? Which Metrics API call is >> this using? > > How does it look in proc? This was based on

Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Erik Gahlin
On Wed, 14 Apr 2021 14:32:32 GMT, Severin Gehwolf wrote: >> This is taken as reported by cgroups - I didn't want to change the semantics >> so it does not confuse people familiar with cgroups. > > I don't see this event field being set anywhere? Which Metrics API call is > this using? How

Re: RFR: 8203359: Container level resources events [v8]

2021-04-21 Thread Erik Gahlin
On Wed, 14 Apr 2021 12:14:33 GMT, Jaroslav Bachorik wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerCPUThrottlingEvent.java >> line 44: >> >>> 42: @Category({"Operating System", "Container", "Processor"}) >>> 43: @Description("Container CPU throttling related information.") >>>

Re: RFR: 8203359: Container level resources events [v8]

2021-04-14 Thread Severin Gehwolf
On Wed, 14 Apr 2021 12:03:12 GMT, Jaroslav Bachorik wrote: >> src/jdk.jfr/share/classes/jdk/jfr/events/ContainerMemoryUsageEvent.java line >> 46: >> >>> 44: public final class ContainerMemoryUsageEvent extends AbstractJDKEvent { >>> 45: @Label("Memory Pressure") >>> 46:

Re: RFR: 8203359: Container level resources events [v8]

2021-04-14 Thread Jaroslav Bachorik
On Wed, 14 Apr 2021 10:25:09 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >>

Re: RFR: 8203359: Container level resources events [v8]

2021-04-14 Thread Jaroslav Bachorik
On Wed, 14 Apr 2021 11:17:14 GMT, Erik Gahlin wrote: >> Jaroslav Bachorik has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >>

Re: RFR: 8203359: Container level resources events [v8]

2021-04-14 Thread Erik Gahlin
On Wed, 14 Apr 2021 08:31:55 GMT, Jaroslav Bachorik wrote: >> With this change it becomes possible to surface various cgroup level metrics >> (available via `jdk.internal.platform.Metrics`) as JFR events. >> >> Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is >>

Re: RFR: 8203359: Container level resources events [v8]

2021-04-14 Thread Jaroslav Bachorik
> With this change it becomes possible to surface various cgroup level metrics > (available via `jdk.internal.platform.Metrics`) as JFR events. > > Only a subset of the metrics exposed by `jdk.internal.platform.Metrics` is > turned into JFR events to start with. > * CPU related metrics > *