Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-04 Thread Paul Sandoz
On Wed, 4 May 2022 12:30:53 GMT, Doug Lea wrote: > This is the revised jsr166 refresh for jdk19. See > https://bugs.openjdk.java.net/browse/JDK-8285450 and > https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR > removes the unrelated commits from original version. Marked

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-04 Thread Alan Bateman
On Wed, 4 May 2022 12:30:53 GMT, Doug Lea wrote: > This is the revised jsr166 refresh for jdk19. See > https://bugs.openjdk.java.net/browse/JDK-8285450 and > https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR > removes the unrelated commits from original version. Marked

RFR: 8277090 : jsr166 refresh for jdk19 v2

2022-05-04 Thread Doug Lea
This is the revised jsr166 refresh for jdk19. See https://bugs.openjdk.java.net/browse/JDK-8285450 and https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR removes the unrelated commits from original version. - Commit messages: - Redoing JDK-8277090 to avoid s

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v3]

2022-05-04 Thread Doug Lea
On Tue, 3 May 2022 23:10:44 GMT, Doug Lea wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > Doug Lea has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Doug Lea
On Tue, 3 May 2022 20:04:48 GMT, Paul Sandoz wrote: >> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line >> 2153: >> >>> 2151: >>> 2152: @Override >>> 2153: public Throwable exceptionNow() { >> >> The unwrapping of CompletionExceptions should be documented >

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v3]

2022-05-03 Thread Doug Lea
> This is the jsr166 refresh for jdk19. See > https://bugs.openjdk.java.net/browse/JDK-8285450 and > https://bugs.openjdk.java.net/browse/JDK-8277090 Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix internal doc typos; thanks to Mart

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Doug Lea
On Tue, 3 May 2022 20:00:52 GMT, Paul Sandoz wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java > line 76: > >> 74:

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-03 Thread Jason Mehrens
Hi Alan, >Is this a Future implementation that doesn't implement the spec >correctly? The get method shouldn't throw CancellationException if done >and not-cancelled. What you say makes sense. I should have checked this before I brought it up but CancellationException is an IllegalStateExceptio

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Paul Sandoz
On Tue, 3 May 2022 15:32:27 GMT, Martin Buchholz wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line > 2153: > >> 2

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Paul Sandoz
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > Doug Lea has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-03 Thread Alan Bateman
On 03/05/2022 17:14, Jason Mehrens wrote: Hi Doug, In Future::exceptionNow() and Future::state() I would think we would want to catch CancellationException since the implementation of the Future is not known. Even though we pre-screen the state I would imagine there could be an implementatio

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-03 Thread Jason Mehrens
. Jason From: core-libs-dev on behalf of Doug Lea Sent: Sunday, May 1, 2022 7:29 AM To: [email protected] Subject: RFR: 8277090 : jsr166 refresh for jdk19 This is the jsr166 refresh for jdk19. See https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Martin Buchholz
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > Doug Lea has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Alan Bateman
On Mon, 2 May 2022 13:33:33 GMT, Doug Lea wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > Doug Lea has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-03 Thread Rémi Forax
On Mon, 2 May 2022 23:54:33 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/FutureTask.java line 222: >> >>> 220: throw new IllegalStateException("Task has not >>> completed"); >>> 221: } >>> 222: } >> >> I think the code will be more readab

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-02 Thread Doug Lea
On Sun, 1 May 2022 14:35:28 GMT, Rémi Forax wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/FutureTask.java line 222: > >> 220:

Re: RFR: 8277090 : jsr166 refresh for jdk19 [v2]

2022-05-02 Thread Doug Lea
> This is the jsr166 refresh for jdk19. See > https://bugs.openjdk.java.net/browse/JDK-8285450 and > https://bugs.openjdk.java.net/browse/JDK-8277090 Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Address review comments -

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-02 Thread Doug Lea
On Mon, 2 May 2022 10:42:35 GMT, Rémi Forax wrote: >> Most AutoCloseables do not mention this in class-level javadocs. Is there a >> reason you think this one should? > > close() is now equivalent to the method shutdownAndAwaitTermination() shown > in the javadoc so i believe , replacing it wit

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-02 Thread Rémi Forax
On Mon, 2 May 2022 10:23:01 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ExecutorService.java line >> 138: >> >>> 136: * @author Doug Lea >>> 137: */ >>> 138: public interface ExecutorService extends Executor, AutoCloseable { >> >> The class documentation should b

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-02 Thread Doug Lea
On Sun, 1 May 2022 14:37:43 GMT, Rémi Forax wrote: >> This is the jsr166 refresh for jdk19. See >> https://bugs.openjdk.java.net/browse/JDK-8285450 and >> https://bugs.openjdk.java.net/browse/JDK-8277090 > > src/java.base/share/classes/java/util/concurrent/ExecutorService.java line > 138: > >

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-01 Thread Rémi Forax
On Sun, 1 May 2022 10:53:55 GMT, Doug Lea wrote: > This is the jsr166 refresh for jdk19. See > https://bugs.openjdk.java.net/browse/JDK-8285450 and > https://bugs.openjdk.java.net/browse/JDK-8277090 src/java.base/share/classes/java/util/concurrent/ExecutorService.java line 138: > 136: * @aut

Re: RFR: 8277090 : jsr166 refresh for jdk19

2022-05-01 Thread Doug Lea
On 5/1/22 08:29, Doug Lea wrote: This is the jsr166 refresh for jdk19. Seehttps://bugs.openjdk.java.net/browse/JDK-8285450 andhttps://bugs.openjdk.java.net/browse/JDK-8277090 Hopefully a harmless glitch: An initially bad merge with (https://github.com/openjdk/jdk/commit/bba456a8dbf9027e4b01

RFR: 8277090 : jsr166 refresh for jdk19

2022-05-01 Thread Doug Lea
This is the jsr166 refresh for jdk19. See https://bugs.openjdk.java.net/browse/JDK-8285450 and https://bugs.openjdk.java.net/browse/JDK-8277090 - Commit messages: - whitespace - sync with loom - 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only