Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-19 Thread Michael Hall
> On May 19, 2022, at 7:14 PM, Michael Hall wrote: > > > >> >> Alexander >> >>> >>> I think it will be a problem to implement this for native launchers. >> > > Basically you are telling the developer in > https://bugs.openjdk.java.net/browse/JDK-8286122 >

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-19 Thread Michael Hall
> > Alexander > >> >> I think it will be a problem to implement this for native launchers. > Basically you are telling the developer in https://bugs.openjdk.java.net/browse/JDK-8286122 that it isn’t currently possible for their

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-19 Thread Michael Hall
> On May 19, 2022, at 5:38 PM, Alexander Matveev > wrote: > > Hi Michael, Alexander > > I think it will be a problem to implement this for native launchers. Each of the native commands is it’s own app launcher? I didn’t know this. I don’t think it was ever really indicated in the

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-19 Thread Alexander Matveev
Hi Michael, I think it will be a problem to implement this for native launchers. - If we extract native launchers inside installed app bundle it will invalidate signature and most likely will require privileged permissions to write inside app bundle. - If we extract to some known and accessible

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-18 Thread Michael Hall
> On May 11, 2022, at 4:39 PM, Alexander Matveev > wrote: > > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. I was just thinking about this.

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-17 Thread Kevin Rushforth
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-17 Thread Michael Hall
> On May 17, 2022, at 12:15 AM, Alexander Matveev > wrote: > > Hi Michael, > > I filed following enhancement for signing user provided app image and yes it > will be two step process. Invoke jpackage to generate image, then user can > modified it and then invoke jpackage again to sign it.

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-16 Thread Alexander Matveev
Hi Michael, I filed following enhancement for signing user provided app image and yes it will be two step process. Invoke jpackage to generate image, then user can modified it and then invoke jpackage again to sign it. https://bugs.openjdk.java.net/browse/JDK-8286850 For JDK-8286122, I will

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-16 Thread Michael Hall
> On May 16, 2022, at 7:09 PM, Alexander Matveev > wrote: > > Hi Michael, > >> I’m not real familiar with the build process. But would it be possible for the user to build their own jdk that substitutes something else for the colliding identifier that gets embedded?

Re: [External] : Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-16 Thread Alexander Matveev
Hi Michael, > >>> >>> I’m not real familiar with the build process. But would it be possible for >>> the user to build their own jdk that substitutes something else for the >>> colliding identifier that gets embedded? >> Yes, it should be possible and in theory such JDK with native commands

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote: > However, I don't know how the app is supposed to be started without a > launcher... jpackage supplies an alternative launcher that doesn't have plist. - PR: https://git.openjdk.java.net/jdk/pull/8666

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Michael Hall
> On May 12, 2022, at 3:13 PM, Magnus Ihse Bursie wrote: > > On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev > wrote: > >>> - It is not possible to support native JDK commands such as "java" inside >>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >>>

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Magnus Ihse Bursie
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-12 Thread Alexey Semenyuk
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev wrote: >> - It is not possible to support native JDK commands such as "java" inside >> Mac App Store bundles due to embedded info.plist. Workarounds suggested in >> JDK-8286122 does not seems to be visible. >> - With proposed fix we will

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Scott Palmer
> On May 12, 2022, at 8:10 AM, Michael Hall wrote: > >  > >> >> My primary suggestion would to be to use an UUID for the unique ID. They are >> of fixed length, are for all intents and purposes unique and you can conjure >> them up from your hat. (An alternative is that the user needs to

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread erik . joelsson
On 2022-05-12 04:58, Magnus Ihse Bursie wrote: On 2022-05-12 13:17, Michael Hall wrote: A solution like including a bundle identifier something like net.java.openjdk.MYAPP.java would be possible at packaging time but not at build time. To fix this at build time you would need to generate a

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Michael Hall
> > My primary suggestion would to be to use an UUID for the unique ID. They are > of fixed length, are for all intents and purposes unique and you can conjure > them up from your hat. (An alternative is that the user needs to specify a > unique ID, but that is probably a less ideal

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Magnus Ihse Bursie
On 2022-05-12 13:17, Michael Hall wrote: I had read this but possibly didn’t grok the issue myself. If I understand correctly now the conflict isn’t within the application but across applications to some other application that has already been added to the Mac App Store that included the

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Michael Hall
> On May 12, 2022, at 4:42 AM, Magnus Ihse Bursie > wrote: > >> Some further spelunking reveals the issue. Consider this: >> >> % otool -s __TEXT __info_plist -v >> APP_NAME.app/Contents/runtime/Contents/Home/bin/java >> … >> >> CFBundleIdentifier >> net.java.openjdk.java >> … >>

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-12 Thread Magnus Ihse Bursie
(cc:ing build-dev.) On 2022-05-12 00:17, Michael Hall wrote: Is this restricted somehow to Mac App Store applications? Is a warning issued as stripping native commands may break application functionality? Is it not possible for the user to provide their own Info.plist with a different

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Michael Hall
Alexander > On May 11, 2022, at 11:38 PM, Alexander Matveev > wrote: > > Hi Michael, > >> On May 11, 2022, at 3:17 PM, Michael Hall wrote: >> >> Is this restricted somehow to Mac App Store applications? > Yes, helper tools (in our case JDK native commands) in Mac App Store > applications

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexander Matveev
Hi Michael, > On May 11, 2022, at 3:17 PM, Michael Hall wrote: > > Is this restricted somehow to Mac App Store applications? Yes, helper tools (in our case JDK native commands) in Mac App Store applications cannot use same bundle ID as another application. Since we have bundle ID embedded in

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-11 Thread Alexander Matveev
On Wed, 11 May 2022 21:58:46 GMT, Alexey Semenyuk wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8286122: [macos]: App bundle cannot upload to Mac App Store due to >> info.plist embedded in java exe [v2] >

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe [v2]

2022-05-11 Thread Alexander Matveev
> - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will enforce "--strip-native-commands" option for > jlink, so native JDK

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Michael Hall
> On May 11, 2022, at 5:17 PM, Michael Hall wrote: > > I’m not real familiar with the build process. But would it be possible for > the user to build their own jdk that substitutes something else for the > colliding identifier that gets embedded? Or just change it in the current build so

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Michael Hall
Is this restricted somehow to Mac App Store applications? Is a warning issued as stripping native commands may break application functionality? Is it not possible for the user to provide their own Info.plist with a different bundle identifier that doesn’t collide? I’m not real familiar with

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

Re: RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexey Semenyuk
On Wed, 11 May 2022 21:31:44 GMT, Alexander Matveev wrote: > - It is not possible to support native JDK commands such as "java" inside Mac > App Store bundles due to embedded info.plist. Workarounds suggested in > JDK-8286122 does not seems to be visible. > - With proposed fix we will

RFR: 8286122: [macos]: App bundle cannot upload to Mac App Store due to info.plist embedded in java exe

2022-05-11 Thread Alexander Matveev
- It is not possible to support native JDK commands such as "java" inside Mac App Store bundles due to embedded info.plist. Workarounds suggested in JDK-8286122 does not seems to be visible. - With proposed fix we will enforce "--strip-native-commands" option for jlink, so native JDK commands