Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/13/18 4:23 AM, Adam Farley8 wrote: Update: The revised webrev can be found here: http://cr.openjdk.java.net/~afarley/8215217/webrev/ I've now pushed this changeset. As a closing observation, I'll note that the original patch did find several vulgarities in OpenJDK. However, all of

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Thanks Lance, I had already volunteered to sponsor this. On 12/13/18 5:42 AM, Lance Andersen wrote: Looks fine. I can sponsor once approved if needed On Dec 13, 2018, at 7:27 AM, Aleksey Shipilev > wrote: On 12/13/18 1:23 PM, Adam Farley8 wrote: Update: The

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Adam Farley8/UK/IBM wrote on 13/12/2018 11:49:12: From: Adam Farley8/UK/IBM To: Stuart Marks Cc: core-libs-dev@openjdk.java.net, mark.reinh...@oracle.com Date: 13/12/2018 11:49 Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words Hi Stuart, A good compromise. Well referenced

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Looks fine. I can sponsor once approved if needed > On Dec 13, 2018, at 7:27 AM, Aleksey Shipilev wrote: > > On 12/13/18 1:23 PM, Adam Farley8 wrote: >> Update: The revised webrev can be found here: >> http://cr.openjdk.java.net/~afarley/8215217/webrev/ >> >> It can also be found in the zip

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/13/18 1:23 PM, Adam Farley8 wrote: > Update: The revised webrev can be found here: > http://cr.openjdk.java.net/~afarley/8215217/webrev/ > > It can also be found in the zip attached to the bug. Looks good to me. Thanks, -Aleksey

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Marks > Cc: core-libs-dev@openjdk.java.net, mark.reinh...@oracle.com > Date: 13/12/2018 11:49 > Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words > > Hi Stuart, > > A good compromise. Well referenced. > > Yes, could you sponsor this change? > >

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

For a moment I had to check if this was 1st of April, but yikes! :) Thanks for cleaning it up. Cheers, Mario Il giorno mar 11 dic 2018 alle ore 16:33 Alan Bateman ha scritto: > > On 11/12/2018 15:03, Adam Farley8 wrote: > > Hey All, > > > > I've spotted 12 instances of swear words in OpenJDK

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Hi Stuart, A good compromise. Well referenced. Yes, could you sponsor this change? Thanks, - Adam Stuart Marks wrote on 12/12/2018 00:38:32: ... > > > # HG changeset patch > # User afarley > # Date 1544574289 28800 > # Tue Dec 11 16:24:49 2018 -0800 > # Node ID

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

2018/12/11 16:38:32 -0800, stuart.ma...@oracle.com: > Adam, > > Starting from your patch, I've removed changes relating to "crap" and "damn" > and > the changes to upstream jszip.js. This leaves the patches appended below. The > SoftChannel.java change is most likely a typo that should be

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/18 9:52 PM, mark.reinh...@oracle.com wrote: > I can certainly see removing the f-word, and other words of a sexual > nature. Those are clearly inappropriate. Fair enough, but we shouldn't touch imported sources, as Joe Darcy pointed out. Let the rudeness be fixed at source. > Removing

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 11/12/2018 21:52, mark.reinh...@oracle.com wrote: > I can certainly see removing the f-word, and other words of a sexual > nature. Those are clearly inappropriate. > > Removing lesser words, and continuing to police their use henceforth, > strikes me as overkill. > > What do other Committers

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

- Mail original - > De: "Andrew Haley" > À: "Adam Farley8" , "core-libs-dev" > > Envoyé: Mercredi 12 Décembre 2018 10:50:52 > Objet: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words > On 12/11/18 3:03 PM, Adam Farley8

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/18 3:03 PM, Adam Farley8 wrote: > I've spotted 12 instances of swear words in OpenJDK source comments, and > it seems appropriate to remove them. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 > > I've created a webrev and attached to the bug. > > Also, I've mentioned in

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/18 1:52 PM, mark.reinh...@oracle.com wrote: 2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com: I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 (webrev:

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/2018 1:52 PM, mark.reinh...@oracle.com wrote: 2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com: I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 (webrev:

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/12/2018 7:52 am, mark.reinh...@oracle.com wrote: 2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com: I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 (webrev:

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/2018 01:52 PM, mark.reinh...@oracle.com wrote: 2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com: I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 (webrev:

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com: > I've spotted 12 instances of swear words in OpenJDK source comments, and > it seems appropriate to remove them. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 (webrev: http://cr.openjdk.java.net/~afarley/8215217/webrev/) > I've

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 12/11/18 10:44 PM, David Holmes wrote: > No issue with fixing F-bomb (though one comes from upstream sources I think) > and the Pitch typo, > but seriously "damn" is not a swear word. Exactly my comment as well. Thanks, -Aleksey

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

ss surprise. "Well, I'll be damned! What brings you here?" Origin On 12/12/2018 2:45 am, Adam Farley8 wrote: Sure thing: http://cr.openjdk.java.net/~afarley/8215217/webrev/ Best Regards Adam Farley IBM Runtimes Volker Simonis wrote on 11/12/2018 15:46:44: From: Volker Simonis

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

ey/8215217/webrev/ > > > > Best Regards > > > > Adam Farley > > IBM Runtimes > > > > > > Volker Simonis wrote on 11/12/2018 15:46:44: > > > >> From: Volker Simonis > >> To: adam.far...@uk.ibm.com > >> Cc: Java Core

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Sure thing: http://cr.openjdk.java.net/~afarley/8215217/webrev/ Best Regards Adam Farley IBM Runtimes Volker Simonis wrote on 11/12/2018 15:46:44: From: Volker Simonis To: adam.far...@uk.ibm.com Cc: Java Core Libs Date: 11/12/2018 15:47 Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

215217: OpenJDK Source Has Too Many Swear Words > > Hi Adam, > > in order to prevent me from using swear words, could you please upload > your webrev to cr.openjdk.java.net :) > > As you may have realized webrevs are a collection of HTML files and it > makes no big sense to

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Hi, And the patch by itself is sufficient, inline or attached to the issue or the email. No need to carry around the whole webrev. And it is very handy to have an quick link to cr.openjdk.java.net $.02, Roger On 12/11/2018 10:46 AM, Volker Simonis wrote: Hi Adam, in order to prevent me

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

! // these icons are pretty crappy to use in Mac OS X since // they really are interactive but we have to return a static // icon for now. -> ! // these icons are difficult to use in Mac OS X since // they really are interactive

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Sweet! Learning English with the OpenJDK community. You sir, probably, have a degree in public relations and/or marketing. This was *the best* way to draw attention to those swear words. Had these words stayed unexposed, no one would have been bothered by them. I guess... On a serious note, I

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Hi Adam, in order to prevent me from using swear words, could you please upload your webrev to cr.openjdk.java.net :) As you may have realized webrevs are a collection of HTML files and it makes no big sense to provide them as a zip file. Thank you and best regards, Volker On Tue, Dec 11, 2018

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Alan Bateman wrote on 11/12/2018 15:32:31: > From: Alan Bateman > To: Adam Farley8 , core-libs-dev d...@openjdk.java.net> > Date: 11/12/2018 15:33 > Subject: Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words > > On 11/12/2018 15:03, Adam Farley8 wrote: >

Re: RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

On 11/12/2018 15:03, Adam Farley8 wrote: Hey All, I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 I've created a webrev and attached to the bug. Also, I've mentioned in the bug

RFR: JDK-8215217: OpenJDK Source Has Too Many Swear Words

Hey All, I've spotted 12 instances of swear words in OpenJDK source comments, and it seems appropriate to remove them. Bug: https://bugs.openjdk.java.net/browse/JDK-8215217 I've created a webrev and attached to the bug. Also, I've mentioned in the bug that there are additional swears in more