Hi Andy,
http://cr.openjdk.java.net/~herrick/8230519/webrev.02/test/jdk/tools/jpackage/share/ErrorTest.java.frames.html
Line 90: Add space before ARG2.
Looks good.
Thanks,
Alexander
On 9/9/2019 3:25 PM, Andy Herrick wrote:
Please review the updated jpackage fix for bug [1] at [3].
Please review the updated jpackage fix for bug [1] at [3].
Functional change: If the default package type is called for, but for
some reason the default package type is not supported on this machine,
it will be an error (we will not try to build any other package type)
Typo fixed in
On 9/9/2019 1:25 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/8230519/webrev.01/test/jdk/tools/jpackage/share/RuntimeTest.java.sdiff.html:
---
37 "--package-type", "app-image",
38 "--package-type", "app-image",
---
Duplication by accident?
yes - will fix.
On 9/9/2019 1:28 PM, Andy Herrick wrote:
On 9/9/19 1:14 PM, Kevin Rushforth wrote:
Looks good with one question:
In Arguments.java:
+ if (bundler.isDefault()) {
+ return bundler;
+ } else {
+
http://cr.openjdk.java.net/~herrick/8230519/webrev.01/test/jdk/tools/jpackage/share/RuntimeTest.java.sdiff.html:
---
37 "--package-type", "app-image",
38 "--package-type", "app-image",
---
Duplication by accident?
On 9/9/19 1:14 PM, Kevin Rushforth wrote:
Looks good with one question:
In Arguments.java:
+ if (bundler.isDefault()) {
+ return bundler;
+ } else {
+ savedBundler = bundler;
+ }
When
Looks good with one question:
In Arguments.java:
+ if (bundler.isDefault()) {
+ return bundler;
+ } else {
+ savedBundler = bundler;
+ }
When would there be a valid case where you loop
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
Adds "app-image" as a valid value for "--package-type" options, meaning
build an application image instead of a package.
Changes the
