Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-10 Thread Andy Herrick
On Wed, 10 Mar 2021 12:37:32 GMT, Kevin Rushforth wrote: >> Implementation of Mac App Support including three new mac specific CLI >> options. > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties > line 247: > >> 245: \ --mac-app-store\n\ >> 246: \

Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-10 Thread Andy Herrick
On Wed, 10 Mar 2021 12:37:03 GMT, Kevin Rushforth wrote: >> Implementation of Mac App Support including three new mac specific CLI >> options. > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties > line 188: > >> 186: \ over-ridden by adding

Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-10 Thread Kevin Rushforth
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Looks good with a couple questions. Is `JavaApp.icns` intended to be an empty file (I see that the file it was renamed from was empty, so probably OK)? The

Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-10 Thread Alexander Zuev
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2716

Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-08 Thread Alexander Matveev
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2716

Re: RFR: JDK-8248904: Add support to jpackage for the Mac App Store

2021-03-08 Thread Alexey Semenyuk
On Wed, 24 Feb 2021 21:59:22 GMT, Andy Herrick wrote: > Implementation of Mac App Support including three new mac specific CLI > options. Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/2716