On Tue, 25 Jan 2022 15:30:46 GMT, Mark Sheppard wrote:
>> yes a redeclaration of timeout with a type long across the component
>> would be a consistent approach, also
>
> so just to clarify, we're not taking the approach to homogenise the timeout
> declarations, throughout the component, to
On Fri, 21 Jan 2022 17:07:37 GMT, Mark Sheppard wrote:
>> Good point. I think its better to deal with the casts at the edges since the
>> timeout handling will use long by default.
>
> yes a redeclaration of timeout with a type long across the component would
> be a consistent approach, also
On Fri, 21 Jan 2022 13:02:36 GMT, Rob McKenna wrote:
>> Well I guess the request was "why not use long everywhere to avoid casting
>> to int" ;-)
>> But I'm happy with either too - as long as the place where you have a long
>> (e.g obtained by substracting two nano times) and call a method that
On Wed, 19 Jan 2022 15:53:57 GMT, Daniel Fuchs wrote:
>> IIRC this was a request from an earlier review. (long being the standard
>> throughout other new public apis) I'm happy with either, but int does avoid
>> the trouble of casting.
>
> Well I guess the request was "why not use long everywhe
On Wed, 19 Jan 2022 15:13:57 GMT, Rob McKenna wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java
>> line 54:
>>
>>> 52: * @param timeout the connection timeout
>>> 53: */
>>> 54: public abstract PooledConnection
>>> createPooledConnection(
On Thu, 13 Jan 2022 01:02:38 GMT, Mark Sheppard wrote:
>> Rob McKenna has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow the test to pass on MacOSX
>
> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java
On Thu, 13 Jan 2022 10:09:45 GMT, Daniel Fuchs wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/LdapClientFactory.java line
>> 70:
>>
>>> 68: public PooledConnection createPooledConnection(PoolCallback pcb,
>>> long timeout)
>>> 69: throws NamingException {
>>> 70:
On Thu, 13 Jan 2022 01:07:52 GMT, Mark Sheppard wrote:
>> Rob McKenna has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow the test to pass on MacOSX
>
> src/java.naming/share/classes/com/sun/jndi/ldap/LdapClientFactory.java line
> 70:
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding th
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding th
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding th
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding th
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding th
> This fix attemps to resolve an issue where threads can stack up on each other
> while waiting to get a connection from the ldap pool to an unreachable
> server. It does this by having each thread start a countdown prior to holding
> the pools' lock. (which has been changed to a ReentrantLock)
14 matches
Mail list logo
