nal Message-
> From: mark.reinh...@oracle.com
> Sent: Donnerstag, 3. Oktober 2019 00:41
> To: Lindenmaier, Goetz
> Cc: hotspot-runtime-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> NullPointerException de
2019/10/2 5:45:10 -0700, goetz.lindenma...@sap.com:
> thanks for looking at my change! Can I add you as reviewer?
Sure.
>> This is very nice work! I especially appreciate the thorough tests.
>
> Thanks! But adapting the many tests to changed messages is
> quite cumbersome :) Thanks for
Hi Mark,
thanks for looking at my change! Can I add you as reviewer?
This webrev incorporates your patch as well as two fixes of
issues that sneaked in implementing some recent reviews:
bytecodeUtils.cpp:449 1 --> 1ULL
bytecodeUtils.cpp:460 move assertion to where len is known.
2019/9/24 1:13:14 -0700, goetz.lindenma...@sap.com:
> http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/
This is very nice work! I especially appreciate the thorough tests.
Looking at the tests, and the details of the JEP, I noticed that the
generated messages all end in a period
8:31
> To: Schmelter, Ralf ; Hotspot dev runtime runtime-...@openjdk.java.net>; Java Core Libs d...@openjdk.java.net>
> Subject: RE: RFR (L, final): 8218626: Add detailed message to
> NullPointerException describing what is null.
>
> Hi Ralf,
>
> > The test should not omit
Hi Goetz,
thanks for the additional test. Looks good.
Best regards,
Ralf
-Original Message-
From: Lindenmaier, Goetz
Sent: Montag, 30. September 2019 18:31
To: Schmelter, Ralf ; Hotspot dev runtime
; Java Core Libs
Subject: RE: RFR (L, final): 8218626: Add detailed message
Hi Ralf,
> The test should not omit these two bytecodes because the current
> implementation is the same. This can change and it is not much additional code
> to add the two cases.
I implemented test cases for the missing invokes:
v runtime
><mailto:hotspot-
> runtime-...@openjdk.java.net> ; Java Core Libsd...@openjdk.java.net <mailto:d...@openjdk.java.net> >
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> NullPointer
/
Is it ok to add you as reviewer (for the java.base part)?
Best regards,
Goetz.
-Original Message-
From: Roger Riggs
Sent: Montag, 23. September 2019 17:30
To: Lindenmaier, Goetz ; Hotspot dev runtime
; Java Core Libs
Subject: Re: RFR (L, final): 8218626: Add detailed message
Hi Goetz,
just one thing:
>> In NullPointerExceptionTest.java:
> >
> > It seems you don't have tests for invokeinterface or invokespecial calls to
> > cause
> > an NPE (e.g. by calling a null interface variable or a private non-static
> > method
> > of a null objects).
> That is because the
; From: Roger Riggs
> Sent: Montag, 23. September 2019 17:30
> To: Lindenmaier, Goetz ; Hotspot dev runtime
> ; Java Core Libs d...@openjdk.java.net>
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> NullPointerException describing what is null.
>
> Hi Goe
gt; Cc: hotspot-runtime-dev ; core-libs-
> dev
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> NullPointerException describing what is null.
>
> - Mail original -
> > De: "Goetz Lindenmaier"
> > À: "Remi Forax"
> >
- Mail original -
> De: "Goetz Lindenmaier"
> À: "Remi Forax"
> Cc: "hotspot-runtime-dev" ,
> "core-libs-dev"
> Envoyé: Lundi 23 Septembre 2019 12:03:30
> Objet: RE: RFR (L, final): 8218626: Add detailed message to
> NullPo
Hi Goetz,
A bit of wordsmithing on the javadoc of NullPointerException.getMessage
and separating out the implementation specific description to an @implNote
75:
/**
* Returns the detail message string of this throwable.
*
* If a non-null message was supplied in a constructor
8218626: Add detailed message to
> NullPointerException describing what is null.
>
> - Mail original -
> > De: "Goetz Lindenmaier"
> > À: "Remi Forax"
> > Cc: "hotspot-runtime-dev" , "core-
> libs-dev"
> > Envoyé:
Hi Ralf,
thanks for looking at this code and this thorough review!
New webrevs:
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/18/
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/18-incremental/
Find my comments inline:
> In javaClasses.cpp:
>
> > #define
Hi Goetz,
here are my review remarks:
In javaClasses.cpp:
> #define CLASS_FIELDS_DO(macro) \
> macro(classRedefinedCount_offset, k, "classRedefinedCount", int_signature,
> false); \
> macro(_class_loader_offset, k, "classLoader",
> classloader_signature, false); \
- Mail original -
> De: "Goetz Lindenmaier"
> À: "Remi Forax"
> Cc: "hotspot-runtime-dev" ,
> "core-libs-dev"
> Envoyé: Mercredi 18 Septembre 2019 09:37:36
> Objet: RE: RFR (L, final): 8218626: Add detailed message to
>
reused for another value. It just
adds to the obfuscation! But there might be code
that is just optimized and not meant to be obfuscated.
Best regards,
Goetz.
>
> Rémi
>
> ----- Mail original -
> > De: "Goetz Lindenmaier"
> > À: "hotspot-runtime
quot; during the static
analysis, so "this" will become "local0" once a store_0 is seen.
Rémi
- Mail original -
> De: "Goetz Lindenmaier"
> À: "hotspot-runtime-dev" ,
> "core-libs-dev"
> Envoyé: Mardi 17 Septembre 2019 16:18:0
age-
> > From: Thomas Stüfe
> > Sent: Dienstag, 17. September 2019 09:06
> > To: Lindenmaier, Goetz
> > Cc: Hotspot dev runtime ; Java
> Core
> > Libs
> > Subject: Re: RFR (L, final): 8218626: Add detailed message to
> > NullPointerException descri
@core-libs experts, I would appreciate comments on the changes
to NullPointerException.java, especially wrt. the Javadoc comment.
The change there is S.
Best regards,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Dienstag, 10. September 2019 11:48
> To: 'Hotspot dev
/
http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/17/
Best regards,
Goetz.
> -Original Message-
> From: Thomas Stüfe
> Sent: Dienstag, 17. September 2019 09:06
> To: Lindenmaier, Goetz
> Cc: Hotspot dev runtime ; Java Core
> Libs
> Subject: Re: RFR (L,
Additionally, since 8224193, stringStream does not use RA anymore, so you
do not need ResourceMarks for the backing buffer. 8224193 has been
backported to 11, btw.
On Mon, Sep 16, 2019 at 2:53 PM Thomas Stüfe
wrote:
> Hi Goetz,
>
> not a full review, just a small suggestion. In jvm.cpp you
Hi Goetz,
not a full review, just a small suggestion. In jvm.cpp you could just
access ss->base() instead of ss->as_string() since the internal buffer is
already NULL terminated and result_string does not outlive the stringStream
object. Also it misses including ostream.hpp.
Cheers, Thomas
On
Hi,
the subject should mention 8218628. (Not 8218626).
Sorry for this!
Best regards,
Goetz.
From: Lindenmaier, Goetz
Sent: Dienstag, 10. September 2019 11:48
To: 'Hotspot dev runtime' ; Java Core
Libs
Subject: RFR (L, final): 8218626: Add detailed message to NullPointerException
describing
26 matches
Mail list logo
