Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-09 Thread Roland Westrelin
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ The hotspot changes look good to me. Roland.

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Mandy Chung
> On Dec 2, 2015, at 2:36 PM, Paul Sandoz wrote: > > >> On 2 Dec 2015, at 22:24, Mandy Chung wrote: >> >> >>> On Nov 26, 2015, at 1:55 AM, Paul Sandoz wrote: >>> >>> Hi, >>> >>> This is a request for an optimistic review to fork the sun.misc.Unsafe and >>> jdk.internal.misc.Unsafe native

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Paul Sandoz
Hi Stefan, > On 2 Dec 2015, at 17:20, Stefan Särne wrote: > > > Hi Paul, > > The reason we stick on standard jtreg tests is because it is simpler. > For us, a java test is not a unit test, it is an application. :) > I tend to think of that as an artificial distinction since such java test

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Paul Sandoz
> On 2 Dec 2015, at 22:24, Mandy Chung wrote: > > >> On Nov 26, 2015, at 1:55 AM, Paul Sandoz wrote: >> >> Hi, >> >> This is a request for an optimistic review to fork the sun.misc.Unsafe and >> jdk.internal.misc.Unsafe native method tables so that we can evolve the >> latter e.g. for VarH

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Mandy Chung
> On Nov 26, 2015, at 1:55 AM, Paul Sandoz wrote: > > Hi, > > This is a request for an optimistic review to fork the sun.misc.Unsafe and > jdk.internal.misc.Unsafe native method tables so that we can evolve the > latter e.g. for VarHandles unsafe work > > http://cr.openjdk.java.net/~psandoz

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Stefan Särne
Hi Paul, The reason we stick on standard jtreg tests is because it is simpler. For us, a java test is not a unit test, it is an application. :) I agree with you that when writing and debugging java code, I would choose testng over jtreg and run and debug it inside my java IDE. But debugging

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-02 Thread Paul Sandoz
Hi Christian, > On 1 Dec 2015, at 20:19, Christian Tornqvist > wrote: > > Hi Paul, > > Tests in hotspot/test/runtime needs to be jtreg tests. They are jtreg tests. They are require to be run (re: “launched") with jtreg see: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-

RE: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-01 Thread Christian Tornqvist
to:hotspot-compiler-dev-boun...@openjdk.java.net] On Behalf Of Paul Sandoz Sent: Tuesday, December 1, 2015 5:28 AM Cc: hotspot-compiler-...@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables > On 30

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-01 Thread Chris Hegarty
On 26 Nov 2015, at 12:00, Aleksey Shipilev wrote: > On 11/26/2015 12:55 PM, Paul Sandoz wrote: >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ > > Both JDK and Hotspot changes look good to

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-12-01 Thread Paul Sandoz
> On 30 Nov 2015, at 23:33, Paul Sandoz wrote: > > >> On 30 Nov 2015, at 23:05, Christian Tornqvist >> wrote: >> >> Because jtreg is the test framework that we use, we've been working hard to >> reduce the number of test frameworks in use. >> > > jtreg comes bundled with testng so what i

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Paul Sandoz
> On 30 Nov 2015, at 23:05, Christian Tornqvist > wrote: > > Because jtreg is the test framework that we use, we've been working hard to > reduce the number of test frameworks in use. > jtreg comes bundled with testng so what is there to reduce? It’s being used more and more core library te

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Christian Tornqvist
ember 30, 2015 4:57:13 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables > On 30 Nov 2015, at 22:17, Christian Tornqvist > wrote: > > Hi Paul, > > >>> Tests don't think we use

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Paul Sandoz
> On 30 Nov 2015, at 22:17, Christian Tornqvist > wrote: > > Hi Paul, > > >>> Tests don't think we use testng with any hotspot tests so not sure >>> about that part. >> >> There are already quite a few, primarily in the serviceability area, search >> for “testng”. > > We don't use te

RE: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Christian Tornqvist
these into normal jtreg tests. Thanks, Christian -Original Message- From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-boun...@openjdk.java.net] On Behalf Of Paul Sandoz Sent: Friday, November 27, 2015 4:06 AM Cc: hotspot compiler ; Java Core Libs Subject: Re: RFR 81

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-30 Thread Paul Sandoz
> On 29 Nov 2015, at 17:08, Alan Bateman wrote: > > On 27/11/2015 09:06, Paul Sandoz wrote: >> : >> >>> Also wondering how these tests will access jdk.internal once we're using >>> the modular image? >>> >> I believe it is sufficient to include: >> >> 28 * @modules java.base/jdk.internal.

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-29 Thread Alan Bateman
On 27/11/2015 09:06, Paul Sandoz wrote: : Also wondering how these tests will access jdk.internal once we're using the modular image? I believe it is sufficient to include: 28 * @modules java.base/jdk.internal.misc or: 28 * @modules java.base/sun.misc We will need to update all

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-27 Thread Paul Sandoz
> On 27 Nov 2015, at 01:59, David Holmes wrote: > > Hi Paul, > > On 26/11/2015 7:55 PM, Paul Sandoz wrote: >> Hi, >> >> This is a request for an optimistic review to fork the sun.misc.Unsafe and >> jdk.internal.misc.Unsafe native method tables so that we can evolve the >> latter e.g. for Var

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-26 Thread David Holmes
Hi Paul, On 26/11/2015 7:55 PM, Paul Sandoz wrote: Hi, This is a request for an optimistic review to fork the sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables so that we can evolve the latter e.g. for VarHandles unsafe work http://cr.openjdk.java.net/~psandoz/jdk9/JDK-814

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-26 Thread Paul Sandoz
> On 26 Nov 2015, at 13:00, Aleksey Shipilev > wrote: > > On 11/26/2015 12:55 PM, Paul Sandoz wrote: >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ >> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ > > Both JDK and Hotspot changes look g

Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

2015-11-26 Thread Aleksey Shipilev
On 11/26/2015 12:55 PM, Paul Sandoz wrote: > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/ > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/ Both JDK and Hotspot changes look good to me. > https://bugs.openjdk.java.net/browse/JDK-8143628 C1 L