Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 24.03.2010 19:48, schrieb Martin Buchholz: On Wed, Mar 24, 2010 at 10:22, Xueming Shen wrote: CR 6937842 Created, P4 java/classes_lang Unreadable \u in javadoc Thanks. The change fine. But maybe it would be better to "escape" the \u20ac as well, instead of simply deletin

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Wed, Mar 24, 2010 at 10:22, Xueming Shen wrote: > > CR 6937842 Created, P4 java/classes_lang Unreadable \u in javadoc Thanks. > The change fine. But maybe it would be better to "escape" the \u20ac as > well, instead of > simply deleting them. Not a big deal. I prefer to leave them out, b

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

CR 6937842 Created, P4 java/classes_lang Unreadable \u in javadoc The change fine. But maybe it would be better to "escape" the \u20ac as well, instead of simply deleting them. Not a big deal. -Sherman Martin Buchholz wrote: Xueming, I believe you still owe me a review and bug filed fo

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Xueming, I believe you still owe me a review and bug filed for http://cr.openjdk.java.net/~martin/webrevs/openjdk7/javadoc-unicode-escapes/ Martin On Wed, Sep 2, 2009 at 13:29, Martin Buchholz wrote: > On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: >> Am 02.09.2009 19:11, David M. Lloyd schrieb

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 06.09.2009 23:31, Ulf Zibis schrieb: Cosmetics for class Character is finished (there have been javadoc errors in String+AbstractStringbuilder too): https://bugs.openjdk.java.net/attachment.cgi?id=145&action=diff Update: https://bugs.openjdk.java.net/attachment.cgi?id=146&action=diff Bene

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Cosmetics for class Character is finished (there have been javadoc errors in String+AbstractStringbuilder too): https://bugs.openjdk.java.net/attachment.cgi?id=145&action=diff -Ulf Am 03.09.2009 21:51, Ulf Zibis schrieb: Am 03.09.2009 20:10, Martin Buchholz schrieb: I agree that the spec can

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Hello. Martin Buchholz wrote: Joe, here's a fix for the stray double quote. Mea culpa! I've used {...@code with \u005C with the hope of making Ulf happy. As usual, we'll need bug filed, etc... I've filed bug 6879368 "Remove stray quote in Character javadoc" for this issue. diff

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 04.09.2009 17:10, Martin Buchholz schrieb: On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, Do you know about "hg blame" ? Good idea. :-) I rarely used it. Thanks for remembering me. -Ulf

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Fri, Sep 4, 2009 at 02:14, Ulf Zibis wrote: > Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, Do you know about "hg blame" ?

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 04.09.2009 03:52, Martin Buchholz schrieb: When you say "you", I assume you are using the "royal you". That change was actually made by Joe Darcy. Martin Oops sorry, I only recognized javadoc update from 1.6.0_14 to 1.7.0 b70, so as this particular change was in similar flavour of your

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Joe, here's a fix for the stray double quote. I've used {...@code with \u005C with the hope of making Ulf happy. As usual, we'll need bug filed, etc... diff --git a/src/share/classes/java/lang/Character.java b/src/share/classes/java/lang/Character.java --- a/src/share/classes/java/lang/Character

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Thu, Sep 3, 2009 at 18:37, Ulf Zibis wrote: > Am 04.09.2009 00:15, Martin Buchholz schrieb: > In Character class you have inserted a typo: '\u007f'" at method > valueOf(char) (the additional " ) When you say "you", I assume you are using the "royal you". That change was actually made by Joe Dar

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 04.09.2009 00:15, Martin Buchholz schrieb: On Thu, Sep 3, 2009 at 12:51, Ulf Zibis wrote: Am 03.09.2009 20:10, Martin Buchholz schrieb: I like to finish the Character class and file the changes via patch on https://bugs.openjdk.java.net. So I would be happy If you could answer m

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Thu, Sep 3, 2009 at 12:51, Ulf Zibis wrote: > Am 03.09.2009 20:10, Martin Buchholz schrieb: > I like to finish the Character class and file the changes via patch on > https://bugs.openjdk.java.net. So I would be happy If you could answer my > question, if replacing all occurrences of ... by {..

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 03.09.2009 20:10, Martin Buchholz schrieb: I agree that the spec can be clarified. Another case is the similar http://java.sun.com/javase/6/docs/api/java/lang/String.html#replace(char, char) which states "Returns a new string", but then goes on to contradict itself, although the meaning is c

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

I agree that the spec can be clarified. Another case is the similar http://java.sun.com/javase/6/docs/api/java/lang/String.html#replace(char, char) which states "Returns a new string", but then goes on to contradict itself, although the meaning is clear. Webrev please. Martin On Thu, Sep 3, 20

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 22:29, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: Am 02.09.2009 19:11, David M. Lloyd schrieb: On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd mailto:[email protected]>> wrote: Why n

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 03.09.2009 00:10, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: Doesn't {...@code "t\u005Cu0131tle"} work too ? I think so. So can I securely replace all occurrences of ... by {...@code ...} using \u005Cu in Character.java ? -Ulf

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Wed, Sep 2, 2009 at 14:58, Ulf Zibis wrote: > Am 02.09.2009 22:29, Martin Buchholz schrieb: > Doesn't {...@code "t\u005Cu0131tle"} work too ? I think so. This would make it easier to globally replace with {...@code. Here's a bit of Emacs Lisp to get you started: (defun tt-code () (intera

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 22:29, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: Am 02.09.2009 19:11, David M. Lloyd schrieb: On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd mailto:[email protected]>> wrote: Why not

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Wed, Sep 2, 2009 at 12:46, Ulf Zibis wrote: > Am 02.09.2009 19:11, David M. Lloyd schrieb: >> >> On 09/02/2009 12:03 PM, Martin Buchholz wrote: >>> >>> On Wed, Sep 2, 2009 at 09:40, David M. Lloyd >> > wrote: >>>    Why not just do {...@code \uD800}?  I'm like 60%

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 19:11, David M. Lloyd schrieb: On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd > wrote: Why not just do {...@code \uD800}? I'm like 60% sure that would work just fine. :-) I'm pretty sure it would

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 18:27, Martin Buchholz schrieb: On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > wrote: Am 02.09.2009 05:21, Martin Buchholz schrieb: /** - * The minimum value of a Unicode surrogate code unit in the UTF-16 encoding. + * The minimum value o

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On 09/02/2009 12:03 PM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 09:40, David M. Lloyd mailto:[email protected]>> wrote: Why not just do {...@code \uD800}? I'm like 60% sure that would work just fine. :-) I'm pretty sure it would fail. Prove me wrong! Searching the JDK sour

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Wed, Sep 2, 2009 at 09:40, David M. Lloyd wrote: > On 09/02/2009 11:27 AM, Martin Buchholz wrote: > >> On Wed, Sep 2, 2009 at 01:07, Ulf Zibis > [email protected]>> wrote: >>Am 02.09.2009 05:21, Martin Buchholz schrieb: >> >>>On Tue, Sep 1, 2009 at 01:29, Ulf Zibis >>

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On 09/02/2009 11:27 AM, Martin Buchholz wrote: On Wed, Sep 2, 2009 at 01:07, Ulf Zibis mailto:[email protected]>> wrote: Am 02.09.2009 05:21, Martin Buchholz schrieb: On Tue, Sep 1, 2009 at 01:29, Ulf Zibis mailto:[email protected]>> wrote: {...@code is now the preferred way. I tried

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Wed, Sep 2, 2009 at 01:07, Ulf Zibis wrote: > Am 02.09.2009 05:21, Martin Buchholz schrieb: > > > > On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote: > > > {...@code is now the preferred way. I tried to modify the methods I changed, > but didn't try to change the whole file. > > > You also hav

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 05:21, Martin Buchholz schrieb: - I would like to see backwards-referring like: public static final int MIN_CODE_POINT = MIN_VALUE; public static final int MIN_SUPPLEMENTARY_CODE_POINT = MAX_VALUE + 1; Those would work, but would add to the confusion between

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Am 02.09.2009 05:21, Martin Buchholz schrieb: On Tue, Sep 1, 2009 at 01:29, Ulf Zibis > wrote: {...@code is now the preferred way. I tried to modify the methods I changed, but didn't try to change the whole file. You also have added old style, so I asked why you h

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

On Tue, Sep 1, 2009 at 01:29, Ulf Zibis wrote: > Martin, > > I like how you have enhanced javadoc for Character class. > > Some coments: > - You more like uppercased hex literals, so we are 2. :-) I like consistency more than I like either uppercase or lowercase. > > - you have mixed value an

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

I have separated the "cosmetics": https://bugs.openjdk.java.net/attachment.cgi?id=140&action=diff https://bugs.openjdk.java.net/attachment.cgi?id=141&action=diff -Ulf Am 01.09.2009 10:29, Ulf Zibis schrieb: Martin, I like how you have enhanced javadoc for Character class. Some comments: - Yo

Re: hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Martin, I like how you have enhanced javadoc for Character class. Some coments: - You more like uppercased hex literals, so we are 2. :-) - you have mixed value and {...@code value}. I more like the latter, it's compact and better readable - you have mixed U+1234 and \u1234 style. Why? - often

hg: jdk7/tl/jdk: 6860431: Character.isSurrogate(char ch)

Changeset: db5d6b4cbc11 Author:martin Date: 2009-08-31 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5d6b4cbc11 6860431: Character.isSurrogate(char ch) Summary: Add new method Character.isSurrogate(char ch) Reviewed-by: sherman, darcy, okutsu ! src/share/classes/jav