Hello,
Thanks for raising the defect. I see there is no patch now, so I
create one (as the defect mentioned jint may be good, I use jint here).
I have no Sun Online Account Id, would someone take a look?
diff --git a/src/windows/native/java/io/io_util_md.c
Jing LV wrote:
Hello,
Thanks for raising the defect. I see there is no patch now, so I
create one (as the defect mentioned jint may be good, I use jint here).
I have no Sun Online Account Id, would someone take a look?
The function prototypes would also require to be updated and
On 26/04/11 09:43, Alan Bateman wrote:
. Another point is that jdk8 will be our opportunity to remove the
dependencies on the JVM_* functions
That sounds interesting Alan - care to share more?
Xueming Shen wrote:
Thanks Mark!
Let's go with UNICODE_PROPERTY, if there is no objection.
I went through the updates to the javadoc and the approach looks good
and nicely done. A minor comment is that the compile(String,int) method
repeats the list of flags that are allowed so that should
Steve Poole wrote:
On 26/04/11 09:43, Alan Bateman wrote:
. Another point is that jdk8 will be our opportunity to remove the
dependencies on the JVM_* functions
That sounds interesting Alan - care to share more?
As you know, it's really hard to remove things from the JDK. Medals are
few.
Steve Poole wrote:
Ok Alan - thanks for the background. I must of missed the VM option
along the way - what's it called?
It's HotSpot specific and is named UseVMInterruptibleIO.
-Alan
Changeset: 8b36b1c4bb7f
Author:nloodin
Date: 2011-04-26 12:49 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8b36b1c4bb7f
7029383: Refresh of non-client demos
Reviewed-by: mchung, ohair
! src/share/classes/com/sun/tools/example/debug/bdi/AccessWatchpointSpec.java
!
Changeset: 147da2c8b749
Author:darcy
Date: 2011-04-26 10:35 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/147da2c8b749
7039369: Limit range of strictfp in FloatingDecimal
Summary: Additional reviews by sergey.kukse...@oracle.com
Reviewed-by: alanb
!
Hi Stuart,
Actually my comments more a response to Remi's assertion that clone
should have been used instead, without giving any technical rationale as
to why clone would be better, and so much better that it warranted Lance
changing the code.
Personally I think we should be steering people
Hello.
FYI, javac in JDK 7 does a more precise analysis than before on what
catch blocks can actually be reached and warnings are issued for
unreachable catch blocks. I've extracted those warnings from a recent
full JDK build in case anyone wants to update the code in question.
-Joe
Hi Joe,
I sent email to coin-dev on this yesterday but it doesn't seem to have
turned up - at least I haven't seen it.
In some cases at least these catch clauses are in fact reachable - e.g.
ThreadPoolExecutor. The analysis assumes that checked-exceptions can
only be thrown by methods that
Xueming Shen wrote:
I'm not a GC guy, so I might be missing something here, but if close()
is being explicitly invoked by some thread, means someone has a strong
reference to it, I don't think the finalize() can kick in until that
close() returns
This is not correct. You can re-publish the
Looks good to me - approved.
Thanks
Kumar
Hopefully all interested parties are addressed in the cc lists.
webrev at:
http://cr.openjdk.java.net/~dholmes/7022370/webrev/
The launcher ergonomics (ergo.c) currently relies on per-architecture,
eg ergo_sparc.c, ergo_i586.c, files to define the
Hi Neil;
I think your message presents the perfect Speak now or forever hold your
peace opportunity. Barring any new substantive objections (I think you have
addressed the previous objections more than adequately) I believe we should
commit your patch to EnumSet and I will do so at the end of
I'll defer to Kelly on the Makefile changes :)
--Sean
On 03/07/2011 02:39 PM, Rama Pulavarthi wrote:
Thanks for the review. We had to make additional changes to run the
tests. Hopefully this is the final webrev for this issue.
Please review this new webrev which also has changes to
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has been
updated - same location.
Verified with i586 and non-i586 builds.
Thanks,
David
Gary Benson said the following on 03/07/11 19:57:
Hi David,
I'm good
On 3/7/11 10:10 PM, David Holmes wrote:
There was a glitch with the use of CTARGDIR (which isn't defined), so
now we check for the ergo file in LAUNCHER_PLATFORM_SRC. Webrev has
been updated - same location.
Looks good. Sorry I didn't catch that CTARGDIR isn't defined as it
exists in the
Mandy Chung wrote:
:
As Eamonn said, I don't think we can change the default of
SimpleFormatter to one line as it would break existing
apps/scripts/tools that depend on the format.
When j.u.logging is enabled (e.g. the j.u.logging API is called), it
will use the SimpleFormatter as the
The webrev looks fine. I have only this minor comment:
* Inflater.c:
A minor suggestion: In inflateBytes, cases Z_OK and Z_NEED_DICT, I suggest
replacing:
this_off += this_len - strm-avail_in;
(*env)-SetIntField(env, this, offID, this_off);
with:
(*env)-SetIntField(env, this, offID,
Mandy Chung wrote:
:
Are you suggesting to have SimpleFormatter to support controling the
one-line format vs the current 2-line format?
Yes, that's what I was wondering about as it seems a bit strange that we
can configure the platform logger to generate one-line output but not
This is a review request for an issue which was previously committed in 2006
but was quickly withdrawn because it was believed to cause a regression in
other software. That removal was mistaken and this fix appears to be bona-fide
beneficial.
Changeset: 8ef60faa95d6
Author:vinnie
Date: 2011-03-11 09:55 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8ef60faa95d6
6986477: sun/security/mscapi/AccessKeyStore.sh test is failing on jdk7
Reviewed-by: valeriep
! test/sun/security/mscapi/access.policy
!
Changeset: ab13f19ee0ff
Author:chegar
Date: 2011-03-11 08:47 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab13f19ee0ff
7024560: InetAddress.getLocalHost().getHostName() returns localhost for
hostnames of length HOST_NAME_MAX
Reviewed-by: alanb, michaelm
!
Changeset: 05c9c157ec51
Author:alanb
Date: 2011-04-04 18:09 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05c9c157ec51
7029979: (fs) Path.toRealPath(boolean) should be toRealPath(LinkOption...)
Reviewed-by: sherman
! src/share/classes/java/nio/file/Path.java
!
Changeset: 3fdfa11ea5ac
Author:chegar
Date: 2011-03-11 13:50 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fdfa11ea5ac
7023363: URI(ftp, [www.abc.com], /dir1/dir2, query, frag) should
throw URISyntaxException
Reviewed-by: alanb, michaelm
!
http://cr.openjdk.java.net/~mduigou/4884238/0/webrev/
This webrev proposes a class java.nio.charset.Charsets to contain definitions
for the (currently) six standard character sets and a seventh definition for
the platform default character set. There are also minor amendments to the
existing
2011/4/12 10:38 -0700, mike.dui...@oracle.com:
On Apr 12 2011, at 03:33 , Alan Bateman wrote:
...
2. @see Charsets.DEFAULT, I assume this should be @see
Charsets#DEFAULT_CHARSET
Correct. I changed it to DEFAULT_CHARSET and forgot to fix this link.
Why is forcing people to type
Hi Lance,
- logSync is not declared final.
- the comment thow a SecurityException is not that useful
- in getDrivers(), I think you can use an ArrayList to gather
all drivers and use Collections.enumeration() at the end.
- also instead of
if (drivers == null || drivers.equals())
Neil,
You now have concurrency issues again. isClosed would need to be
volatile if the methods that set/check it aren't synchronized. Multiple
threads could call close() at the same time, and threads can call
available etc after close has finished its main work.
David
Neil Richards said
Ulf,
Ulf Zibis said the following on 04/15/11 04:02:
Oops, SystemRoot could be null theoretically. So forget my comment about
NUL termination.
But anyway, should we allow to have get(SystemRoot) !=
getEnv(SystemRoot)?
Is it correct to defaultly set the SystemRoot variable on non-Windows
Changeset: 0ba980dc486e
Author:alanb
Date: 2011-03-15 13:15 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0ba980dc486e
7026376: (dc) DatagramChannel created without specifying protocol family fails
to join IPv4 group
Reviewed-by: chegar
! make/java/nio/mapfile-linux
!
Changeset: 480de7832e2f
Author:bpatel
Date: 2011-03-15 14:19 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/480de7832e2f
4743537: Help doesn't say what All Classes and other links really mean
Reviewed-by: jjg
!
On Mon, 2011-04-18 at 13:33 +0100, Neil Richards wrote:
I think it's worthwhile trying to clear 'streams' entries from a
finalize method in ZFIIS, to help ensure they are cleared in a timely
manner.
In fact, it's probably clearer (more closely following the pattern
elsewhere in the file) for
On 3/18/2011 10:01 AM, assembling signals wrote:
Hello, community!
I noticed a new error since b134: Cannot use '' with anonymous inner
classes.
The code uses diamond syntax and was error-free before b134.
(Please see reproducible example at the end.)
Can someone explain: is this error even
Michael McMahon wrote:
This issue occurs on some versions of Windows since we switched compiler
to VC 2010. The new C runtime library requires the SystemRoot
environment
variable to be set, when launching sub-processes via Runtime.exec() or
ProcessBuilder.
The problem occurs in instances
On 04-13-2011 3:00 PM, Mike Duigou wrote:
Mike, can you share the results of performance testing at various compression levels? Is
there much difference between the levels or an apparent sweet spot?
For low hanging fruit for jdk 7 it might be worth considering raising the
default compression
Changeset: fb1d421c1e97
Author:jrose
Date: 2011-04-09 21:38 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fb1d421c1e97
7019529: JSR292: java/dyn/ClassValueTest.java depends on sub-test execution
order
Summary: Test should not use static variables, because they may contain
Changeset: 2473f7027ac5
Author:cl
Date: 2011-03-10 17:11 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/2473f7027ac5
Added tag jdk7-b133 for changeset 8e1148c7911b
! .hgtags
Changeset: 02d4672e8c05
Author:lana
Date: 2011-03-10 20:37 -0800
URL:
Changeset: fe232d7e4ff1
Author:dholmes
Date: 2011-03-22 18:56 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe232d7e4ff1
7025066: Build systems changes to support SE Embedded Integration
Summary: Define Embedded specific files and include them in the main files.
Allow
Changeset: 6dfcea9f7a4e
Author:schien
Date: 2011-04-07 15:21 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6dfcea9f7a4e
Added tag jdk7-b137 for changeset ccea3282991c
! .hgtags
Changeset: de11bd049d6f
Author:ohair
Date: 2011-04-06 20:16 -0700
URL:
On Mon, Apr 18, 2011 at 6:24 PM, Mike Duigou mike.dui...@oracle.com wrote:
The latest webrev : http://cr.openjdk.java.net/~mduigou/4884238/2/webrev/
Any other remaining feeback?
Mike,
You'll need to update the private constructor and AssertionError for
StandardCharset as the existing private
Changeset: 970c0898ded2
Author:ohair
Date: 2011-03-22 11:07 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/rev/970c0898ded2
6737397: Should support running JCK test suite with test/Makefile and JPRT
Reviewed-by: alanb
! make/jprt.properties
! test/Makefile
Looks good; approved,
-Joe
On 3/22/2011 1:12 PM, Mike Duigou wrote:
Hello all;
I have made a couple of styling improvements to the JavaDoc for SortedMap;
principally conversion of an inline list to use the HTMLol tag. The
remainder of the changes are updates to the standard javadoc tags.
Hi David,
I have a general code style question about this. This arose in the review of
Lance's webrevs for 7038565 [1] but I'm starting a new thread since I don't
want further discussion to drag out that review.
In that review, Lance initially used Arrays.copyOf() to do defensive copying of
On Apr 20, 2011, at 7:41 AM, Doug Lea wrote:
On 04/19/11 21:07, David Holmes wrote:
Hi Mike,
Mike Duigou said the following on 04/20/11 08:00:
Hello All;
Another collections javadoc review request. This change links the
(optional)
notes in on various Collection methods to text which
Neil Richards wrote:
Hi all,
Can I encourage further review / comment on my suggested fix (and
testcase) for this problem [1] [2], please ?
For reference, I include the 'hg export' for the latest version of the
change below,
I imported the change-set and re-freshed the webrev:
Changeset: e9ec52c63a9f
Author:dl
Date: 2011-04-21 17:00 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e9ec52c63a9f
7038542: Small performace regression in ConcurrentHashMap on c1 since CR 703655
Reviewed-by: chegar
!
Alan,
http://cr.openjdk.java.net/~ksrini/7031166/webrev.1
Fixed it per your suggestions.
Thanks
Kumar
Kumar Srinivasan wrote:
Hi,
Replaces some old nio code which copies over the test sdk to run
tests against.
http://cr.openjdk.java.net/~ksrini/7031166/webrev.0/
Thanks
Kumar
I see the
6381464: SimpleFormatter should use one single line format
This is a follow-up of the review for 7006814. I came up with a better
solution that allows a user to customize the output format for SimpleFormatter.
You can specify the format string using the java.util.Formatter syntax in
a new
Hi Neil;
I have run the jtreg regression suite against your webrev. I had to make one
change to IdentityHashMap to satisfy the Collection/MOAT test. The failure
condition involved calling EntrySet.remove() when there was no current entry
due to a prior remove() or because next() had never been
Thanks for cleaning it up.
Couple of questions:
Why we obtain HMODULE for kernel32 this way:
// get handle to kernel32
if (GetModuleHandleExW((GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS |
GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT),
Changeset: 4c5f13798b8d
Author:jjg
Date: 2011-04-25 15:56 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c5f13798b8d
7038363: cast from object to primitive should be for source = 1.7
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/code/Source.java
!
I think your suspicion is correct that the anonymous inner Object is used
rather than new Object so that it can be distinguished more easily in heap
dumps or via other tools. I would be fine with using Integer(0) as the sentinel
value. I've always used new String(something useful) rather than
Changeset: 9f08a221e5f2
Author:mduigou
Date: 2011-04-04 11:55 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f08a221e5f2
6565585: Remove critical section in Method.invoke, Constructor.newInstance,
Field.getFieldAccessor improving performance
Reviewed-by: alanb, dholmes,
Changeset: 244b27bb14f8
Author:ksrini
Date: 2011-04-06 19:31 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/244b27bb14f8
7033954: (launcher) Launchers not built with mapfiles
Reviewed-by: ohair
! make/com/sun/java/pack/Makefile
+
On Fri, 2011-04-08 at 16:40 +0100, Alan Bateman wrote:
Neil - I think I offered to help get this one in and I'm just
wondering if your patch of 3/24 is the latest? Just checking as it
would be good to get this one in before jdk7 gets locked down.
-Alan
Hi Alan, thanks for the prod (and
On Fri, 2011-04-08 at 20:53 -0700, Xueming Shen wrote:
Regression test /test/java/util/zip/ZipFile/FinalizeInflater.java failed
with this fix.
The possible solution I can think of now is to do nothing but simply
return the inflater back to the cache, but do an additional sanity
check when
ooks fne. ;^)
-kto
On Apr 12, 2011, at 10:57 AM, Lance Andersen - Oracle wrote:
Hi folks,
Looking for a reviewer for the following simple change to ResultSet to
address CR 7007772
hg diff
diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java
---
On 4/11/11 7:46 AM, Alan Bateman wrote:
Stuart Marks wrote:
Hi Core-Libs developers,
I'd like to solicit some advice and discussion about this bug and a potential
fix I'm cooking for it. Here is the bug report; it contains details about the
problem and my analysis of it:
Hi Mike,
apart from compression 0 it doesn't make a lot of difference as far as I see
it.
As I posted earlier, converting the file name to lower case seems (according
the
the NB profiler) to take more time than the compression
Bearing in mind that I have tweaked my system so that I am
Changeset: 2d89d0d1e0ff
Author:darcy
Date: 2011-04-14 21:27 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d89d0d1e0ff
6430675: Math.round has surprising behavior for 0x1.fp-2
Reviewed-by: alanb
! src/share/classes/java/lang/Math.java
!
Alan Bateman wrote:
Michael McMahon wrote:
On Windows, we are ensuring that SystemRoot will at a minimum always
be set.
Don't you still have the corner case where Runtime.exec is invoked
with an empty array and SystemRoot is not in the environment (launched
by an older JDK for example)? In
Oops, missed that one in my search-and-replace.
I've updated the online webrev.
Thanks!
Mike
On Apr 18 2011, at 16:13 , David Schlosnagle wrote:
On Mon, Apr 18, 2011 at 6:24 PM, Mike Duigou mike.dui...@oracle.com wrote:
The latest webrev :
On 18 April 2011 18:32, Xueming Shen xueming.s...@oracle.com wrote:
Hi Neil,
All tests passed.
I'm starting to push your last patch. I generated the webrev at
http://cr.openjdk.java.net/~sherman/7031076/webrev/
It should be exactly the same as your last patch.
Thanks,
Sherman
Hi
Hi Folks,
I am looking for a reviewer for this update to BatchUpdateException to address
a findbugs issue for exposing a mutable object.
The webrev is at http://cr.openjdk.java.net/~lancea/7038565/
Have a great weekend!
Regards,
lance
Lance Andersen| Principal Member of Technical Staff |
Changeset: 2c46bf0a462c
Author:mullan
Date: 2011-04-21 17:39 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c46bf0a462c
7038175: Expired PKITS certificates causing CertPathBuilder and
CertPathValidator regression test failures
Reviewed-by: xuelei
!
Changeset: 48f659a09ed4
Author:coffeys
Date: 2011-04-22 11:03 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48f659a09ed4
7025227: SSLSocketImpl does not close the TCP layer socket if a close notify
cannot be sent to the peer
6932403: SSLSocketImpl state issue
Reviewed-by:
(just saw your message; more e-mail delays I suppose)
2011/4/19 17:22 -0700, mike.dui...@oracle.com:
My sentiment is for StandardCharset.
I received offlist feedback which would support this. The pattern for
enum like collections of constants has been to use the singular form;
On 04-26-2011 2:20 AM, Alan Bateman wrote:
Xueming Shen wrote:
Thanks Mark!
Let's go with UNICODE_PROPERTY, if there is no objection.
I went through the updates to the javadoc and the approach looks good
and nicely done. A minor comment is that the compile(String,int)
method repeats the
69 matches
Mail list logo
